Deploy Checklist: New Expensify 2023-11-22

[github-actions]

Release Version: 1.4.2-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix spaces #2
• Unnecessary blank area is created when scrolling down while keyboard is open #19642 #21298
• Refactor HeaderGap #23238
• Add focus trap to the RHP (v2) #27670
• Fix: Task does not appear in LHN after self-assigning as a group member #27852
• [TS migration] Migrate 'fileDownload' lib to TypeScript  #28449
• feat(expensify-card): add get physical card button and routes #28453
• updated to function component #28625
• [TS migration] Migrate 'HttpUtils.js' lib to TypeScript #28691
• [No QA] [TS Migration] migrate AnimatedStep directory's files to TypeScript #29945
• Refactor save method in PersistedRequests #30425
• fix: 29378 Distance - Search is open in background on distance image preview #30556
• Restrict room rename for Task #30886
• [TS migration] Migrate 'EnvironmentBadge.js' component to TypeScript #30891
• fix: 30252 Animation is not visible on desktop but visible on Mobile in sign in Modal #30954
• fix 29852 #31046
• refactor(28902): migrate BaseAutoCompleteSuggestions from flatlist to flashlist #31057
• Pin workspace chats upon creation #31265
• [TS migration] Migrate 'ThumbnailImage.js' component to TypeScript #31269
• Correctly position cursor after pasting text containing emoji  #31279
• Onyx migration for transactions backups #31280
• fixes wrong fallback for goback in notification preference page #31287
• Fix: Update total amount in optimistic data #31292
• 31208 - Fix app error on chat bubble click from OD #31294
• perf: improve heavy operations when user starts to type #31295
• Fix/31104: Description is shown in preview #31348
• Adds Violations Requirements to MoneyRequestConfirmationList #31380
• [TS migration] Migrate 'PushNotification.js' lib to TypeScript #31444
• [TS Migration] remove KeyboardSpacer directory #31480
• [TS migration] Migrate 'ParentNavigationSubtitle.js' component to Typ… #31485
• Added patch to fix console error in pdf destroy #31489
• fix: Distance - The title 'Distance' changing to 'Merchant' when toggling on Billable #31491
• Fix:30734 - tag esc character issue #31494
• Extra bottom padding on the header in the sign-in modal #31517
• Fix optimistic members of restricted room #31526
• Disable complete task for anonymous user #31527
• [TS Migration] Migrate ReportHeaderSkeletonView.js to TypeScript #31545
• [No QA] Use relative paths for GitHub Actions #31575
• Remove CheckboxWithTooltip #31584
• fix: ensure composer not full size when onyx state missing #31602
• [ImgBot] Optimize images #31603
• bump expensify-common version to latest #31644
• [No QA] Fix deployBlocker workflow #31645
• Revert "Add focus trap to the RHP (v2)" #31738
• Revert "Refactor save method in PersistedRequests" #31743
• fix android file upload issue #31768

Deploy Blockers:

• [$500] IOU - Blue box surrounding the currency after the currency selection #31687
• [HOLD for payment 2023-12-04] [$500] Chat - Notification preferences page appears again after refreshing the page #31688
• [$500] Close account - No message about successful account closure #31690
• [HOLD for payment 2023-12-07] Personal details - Extra padding above "Address line 1" field in Address page #31704
• Workspace - Blue focus is shown when changing workspace name #31725
• BA - Error message doesn't stop displaying instantly after valid data is entered in date field #31734
• Attachment - File upload freezes when the application is reloaded #31745
• Chat - Original message appears after editing in offline mode and relaunch the app #31749
• Chat - Message deleted in offline mode is still displayed in offline mode after being online #31751
• Tag field shows required, but user allowed to create expense without selecting it #31752
• Web - User can not navigate to upload photo option while using Tab key #31755
• [HOLD for payment 2023-12-07] Tag - Child tags are not displayed in Recent #31760
• [HOLD for payment 2023-12-04] Android-Scan-Unable to create split scan request with 2 participants, unexpected error displayed #31763

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[melvin-bot]

📣 @github-actions[bot]! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

[os-botify]

Sorry, only members of @Expensify/Mobile-Deployers can close deploy checklists.
Reopening!

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.2-0 🚀

[mountiny]

Btw, made a PR to fix this issue with the checklist being closed upon creation https://github.com/Expensify/Web-Expensify/pull/39805

[kavimuru]

Regression is 24% progress

#31517 is blocked in Desktop and intended as per this comment #25790 (comment) and checking it off.
#31545 failing with #31707

[Julesssss]

@luacmartins blocker #31688 is about to be resolved here, but I might be out for the day by then. Would you mind keeping an eye on the fix and CPing it?

[luacmartins]

Checking off #31688. Demoted to NAB since it's a navigation wide issue that affects App on reloading a page and it's not that sensitive.

[luacmartins]

Checking off #31704. Demoted to NAB.

[luacmartins]

Checking off #31725 and #31734. We reverted the offending PR

[luacmartins]

Checking off #31690. We reverted the offending PR

[kavimuru]

Regression is 81% progress.
#31287 failing with 31688 and 31592 (KI)
#31294 failing with 31592 (KI)- ok to check it off?
#31517 and #31527 are blocked in Desktop and intended as per this comment #25790 (comment) and checking it off.
#31545 failing with #31707

[marcaaron]

Checking off #31745

[luacmartins]

Checking off #31749 and #31751. We reverted the offending PR and it's no longer reproducible in staging.

[luacmartins]

Checking off #31755. We reverted the PR that introduced this new functionality so the steps won't work.

[luacmartins]

Checking off #31752. Users can already do this, the PR is question is only adding the required copy to the input

[luacmartins]

@mvtglobally checking off #27670, since we reverted the PR

[luacmartins]

Checking off #31738 and #31743, tested in staging and related blockers are no longer reproducible

[luacmartins]

Checking off #31287. We merged a fix.

[luacmartins]

Checking off #31294. The type error no longer happens, but we hit another KI.

[luacmartins]

Checking off #31545. This is intended for now since we reverted the PR that introduced the skeleton, but just merged the PR that reintroduces it today.

[kavimuru]

Regression is just 3 steps left

#28453 failing with #31757

[luacmartins]

Checked off #31760. Demoted to NAB

[kavimuru]

Regression is completed.

Unchecked PR:

#28453 failing with #31757

[luacmartins]

Checking off #31763. We CPed a fix.

[luacmartins]

Checking off #28453, since the feature is still WIP and it doesn't break any functionality.

[luacmartins]

Checklist is clear. Kicking off the deploy.

[luacmartins]