[$500] Room settings-Members added/deleted in a room in offline mode are not grayed out/crossed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.2-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any Expensifail account
3. Open any room (or create it) -> Members
4. Turn off the internet connection
5. Invite some new members
6. Delete some members

Expected Result:

Members added offline are grayed out
Members removed offline are crossed out
We expect the same behavior as when removing/adding members offline in the workspace

Actual Result:

Members added offline are NOT grayed out
Members removed offline are NOT crossed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6287884_1700694133056.Recording__6866.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013f3cdcfb2a96a853
• Upwork Job ID: 1727466899004616704
• Last Price Increase: 2023-11-22
• Automatic offers:
• tienifr | Contributor | 27957669

Issue Owner

Current Issue Owner: @deetergp

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013f3cdcfb2a96a853

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room settings-Members added/deleted in a room in offline mode are not grayed out/crossed

What is the root cause of that problem?

When adding/deleting room members we did not store pendingAction like what we did with WS member

What changes do you think we should make in order to solve the problem?

Solution 1: Add new Onyx key roomMembers to store the members in room. When adding new member to room, we set pendingAction: add, when removing member, set pendingAction: delete (like what we did with WS (policyMembers).)

Then add pendingAction to result

Solution 2: To be simpler, we can just add new filed to report_{id} when adding/removing member to store pendingAction

    const participantAccountsOptimistic= _.object(inviteeAccountIDs, Array(inviteeAccountIDs.length).fill({pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD}))

    const participantAccountsSuccess= _.object(inviteeAccountIDs, Array(inviteeAccountIDs.length).fill({pendingAction: null}))

then add participantsOptimistic: participantAccountsOptimistic to optimisticData

participantsOptimistic: participantAccountsSuccess to successData

and generate errors to failureData

Do the same with removing room member

Finally, add pendingAction: participantsOptimistic[accountID].pendingAction to result

We should cover the case members are not in personalDetails

In inviteToRoom function

    const newPersonalDetailsOnyxData = PersonalDetailsUtils.getNewPersonalDetailsOnyxData(inviteeEmails, inviteeAccountIDs);

optimisticData: [
...
...newPersonalDetailsOnyxData.optimisticData
];

successData: [
...
...newPersonalDetailsOnyxData.successData
];

failureData: [
...
...newPersonalDetailsOnyxData.failureData
];

Result

Screen.Recording.2023-11-23.at.11.18.44.mov

[thirtyfoura34]

Contributor details
Your Expensify account email: thirtyfoura34@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01903eeeb0b0665a65

[melvin-bot]

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

[thirtyfoura34]

Contributor details
Your Expensify account email: thirtyfoura34@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01903eeeb0b0665a65

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[thirtyfoura34]

Contributor details
Your Expensify account email: thirtyfoura34@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01903eeeb0b0665a65

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[burczu]

Not overdue, I'll be reviewing this issue soon.

[burczu]

I think we should give a try the Solution 1 from the proposal of @tienifr - doing this the same way as for WS is a good idea as this is actually the same functionality.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tienifr]

@deetergp @burczu Thanks for choosing my proposal. In the first solution, I suggest adding roomMembers onyx key like what we did with WS, so we need fix BE as well to return roomMembers when users logout -> login. Should we hold this until BE fix? Thanks

[melvin-bot]

This issue has not been updated in over 15 days. @deetergp, @bfitzexpensify, @Christinadobrzyn, @alitoshmatov, @tienifr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[deetergp]

I think the PR is getting pretty close.

[deetergp]

Still some discussion going on in the PR.

[deetergp]

PR is mostly ready. There are a few merge conflicts that need resolved, but once those are sorted I think it'll be good to go.

[Christinadobrzyn]

working on PR - on hold for #16078

[tienifr]

@deetergp
To summary on this issue:

I spent time to work on first solution, but we decided to go with the second one. The created PR was almost merged, Unfortunately, it was fixed on other issue, but I still fixed other case(strike though), it would be out of scope. Can I get extra bounty in this case? Thanks cc @Christinadobrzyn

[Christinadobrzyn]

Hi @tienifr! Thanks for reaching out about the extra work - what bonus do you think would be fair for the extra work you did?

[tienifr]

My suggestion is 500$. The same situation is here. Wdyt? @Christinadobrzyn

[Christinadobrzyn]

Sounds good @tienifr! We'll add a $500 bonus to you on payout (you might need to remind us)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[tienifr]

It's not my regression

[deetergp]

It's not my regression

Can you elaborate @tienifr?

[tienifr]

@deetergp We already discussed in here

[deetergp]

Ah, nice. Thanks for the extra context @tienifr.

[tienifr]

@deetergp @Christinadobrzyn The PR was merged 3 weeks ago without any regressions. Should we go with payment? Thanks

[Christinadobrzyn]

Yes, thanks for catching that @tienifr - looks like the payment trigger didn't happen.

Payouts due:

• Contributor: $500 @tienifr + $500 bonus - (paid in Upwork - https://www.upwork.com/nx/wm/offer/27957669)
• Contributor +: $500 @alitoshmatov (Upwork offer - https://www.upwork.com/ab/applicants/1777525996418326528/offers)

Upwork job is here the posting is now closed.

Internal so no regression test. I think this can be closed. Let me know if I missed anything!

[alitoshmatov]

@Christinadobrzyn I worked as C+, I also require payment

[Christinadobrzyn]

Ah so sorry for missing that @alitoshmatov - thank you for letting me know, can you accept the Upwork offer here - https://www.upwork.com/ab/applicants/1777525996418326528/offers

[Christinadobrzyn]

Thanks, @alitoshmatov - I paid out the Upwork job based on this payment summary - #31764 (comment)

Closing! Feel free to let me know if I missed anything else!