Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [TS migration] Migrate 'ReportReactionList' component to TypeScript #31976

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 35 comments
Closed

[$250] [TS migration] Migrate 'ReportReactionList' component to TypeScript #31976

melvin-bot bot opened this issue Nov 27, 2023 · 35 comments
Assignees
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/home/report/ReactionList/reactionPropTypes.js 1
src/pages/home/report/ReactionList/HeaderReactionList.js 11
src/pages/home/report/ReactionList/BaseReactionList.js 15
src/pages/home/report/ReactionList/PopoverReactionList/index.js 3
src/pages/home/report/ReactionList/PopoverReactionList/BasePopoverReactionList.js 16
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011c880c9a39894d4a
  • Upwork Job ID: 1744724329006366720
  • Last Price Increase: 2024-01-09
  • Automatic offers:
    • getusha | Reviewer | 28091171
    • vadymbokatov | Contributor | 28091172
Copy link
Author

melvin-bot bot commented Dec 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. labels Jan 9, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'ReportReactionList' component to TypeScript [$500] [TS migration] Migrate 'ReportReactionList' component to TypeScript Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011c880c9a39894d4a

Copy link
Author

melvin-bot bot commented Jan 9, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 9, 2024
@mountiny mountiny removed Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 9, 2024
@melvin-bot melvin-bot bot removed the Monthly KSv2 label Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 9, 2024
@unidev727
Copy link
Contributor

I'd like to work on it.

2 similar comments
@MahmudjonToraqulov
Copy link
Contributor

I'd like to work on it.

@yh-0218
Copy link
Contributor

yh-0218 commented Jan 9, 2024

I'd like to work on it.

@vadymbokatov
Copy link
Contributor

Hi. I've been offline for a while and I would like to work on this. I think it would help me make a good comeback easier.

@ishpaul777
Copy link
Contributor

I'd like to work on it.

@mountiny mountiny changed the title [$500] [TS migration] Migrate 'ReportReactionList' component to TypeScript [$250] [TS migration] Migrate 'ReportReactionList' component to TypeScript Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Upwork job price has been updated to $250

@HezekielT
Copy link
Contributor

I'd like to work on this.

@MahmudjonToraqulov
Copy link
Contributor

I'd like to work on it.

Copy link
Author

melvin-bot bot commented Jan 9, 2024

📣 @vadymbokatov 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@vadymbokatov
Copy link
Contributor

Hi. I accepted the offer on Upwork and I'm starting my work on this. Will get the PR ready ASAP.

@melvin-bot melvin-bot bot added the Overdue label Jan 12, 2024
@isabelastisser
Copy link
Contributor

Not overdue.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 12, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Jan 16, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Feb 8, 2024
Copy link
Author

melvin-bot bot commented Feb 8, 2024

This issue has not been updated in over 15 days. @isabelastisser, @MonilBhavsar, @getusha, @vadymbokatov eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@getusha
Copy link
Contributor

getusha commented Feb 8, 2024

Reviewing the PR #34549

@vadymbokatov
Copy link
Contributor

Hi @MonilBhavsar
The PR has now two approves by @getusha and @blazejkustra , and is currentlly awaiting your kind consideration. Thanks. 🙏

@isabelastisser
Copy link
Contributor

Bump @MonilBhavsar for PR review. Thanks!

@MonilBhavsar
Copy link
Contributor

Yup, got assigned a review yesterday. It's on my list for today. Got a bit stretched by bugs, but will try to get to it before I end

@MonilBhavsar
Copy link
Contributor

PR is merged

@vadymbokatov
Copy link
Contributor

Thanks @MonilBhavsar for your effort on the review.

@vadymbokatov
Copy link
Contributor

Hi,

This issue was merged yesterday. Can we please mark it as done and close it, as well as releasing the payment on Upwork?

@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Feb 22, 2024

I believe it is going to be paid after regression period ends (7 days after PR is deployed to production). I would like @isabelastisser to confirm

@isabelastisser
Copy link
Contributor

That's correct, @MonilBhavsar!

@vadymbokatov
Copy link
Contributor

Hi. It's been a week since this issue was deployed to production. (based on this comment)
Just wanted to check if everything is fine and can we release the payment?
Thanks.

@isabelastisser isabelastisser added Daily KSv2 and removed Monthly KSv2 labels Mar 11, 2024
@isabelastisser
Copy link
Contributor

I will review this today.

@isabelastisser
Copy link
Contributor

The payments were processed in Upwork, all set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests