[HOLD for payment 2023-12-08] [HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when executing PR: #31401

Version Number: v1.4.4-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any expensifail account
3. Go to Settings -> Wallet -> Enable Wallet
4. Follow the flow until your reach the "Additional details" page
5. Fill the form with following data: First name: Alberta, Last name: Bobbeth, SSN: 1234, Any other information for the rest of the fields
6. Tap on "Save & continue"
7. Change the SSN for 123456789 -> Tap on "Save & continue"
8. Idology questions should appear
9. Don't fill anything and press Save & continue -> Errors should appear
10. Select any response -> Tap on "Save & continue"
11. Don't fill anything for second question and press Save & continue

Expected Result:

Errors should appear when pressing Save&Continue without filling anything in all idology questions

Actual Result:

No error message when press Save&Continue without filling anything in 2 and next idology question

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6292867_1701162387966.bandicam_2023-11-28_10-54-49-442.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01645371315accf60d
• Upwork Job ID: 1729462498357043200
• Last Price Increase: 2023-11-28

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01645371315accf60d

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tienifr]

I'm able to raise a PR ASAP if assigned

This comes from this PR.

Proposal

Please re-state the problem that we are trying to solve in this issue.

No error message when press Save&Continue without filling anything in 2 and next idology question

What is the root cause of that problem?

In this form, we're using the same inputID answer for all the questions, so when we move to the next question, the answer value in the form is still the answer of the previous question, leading to errors do not show.

What changes do you think we should make in order to solve the problem?

Have different inputID for different questions based on the currentQuestionIndex

const inputID = `answer${currentQuestionIndex}`;

And use it in place of the inputID in places like here and in here

So we still have 1 form, but the questions are separate, which makes sense since all questions are different items of the form and should not share the same ID.

We should understand this as "a Form with multiple different questions", rather than "Multiple forms, each has 1 question"

What alternative solutions did you explore? (Optional)

Set a height to the Form and use key={currentQuestionIndex} so we'll have a different form per question. The form height is because otherwise the form will be rerendered each time the question changes and will cause flickering.

Or we can manually clear the answer value of the form whenever the currentQuestionIndex changes, but I prefer separate inputID of the questions as mentioned in the main solution.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

From 2nd idology questions the error isn't shown

What is the root cause of that problem?

Seems the problem comes after this PR where the key isn't been set for FormProvider here

Reason: FormProvider component isn't reset/recreated but uses the old instance only and that leads to pass the validate function bcoz it contains the selected answer from the first idology question.

App/src/pages/EnablePayments/IdologyQuestions.js

Lines 115 to 119 in 70813db

	const validate = (values) => {
	const errors = {};
	if (!values.answer) {
	errors.answer = translate('additionalDetailsStep.selectAnswer');
	}

What changes do you think we should make in order to solve the problem?

We need to assign key to the FormProvider to recreate its instance on the question change.

key={currentQuestion.type}

App/src/pages/EnablePayments/IdologyQuestions.js

Lines 134 to 136 in 70813db

	<FormProvider
	formID={ONYXKEYS.WALLET_ADDITIONAL_DETAILS}
	onSubmit={submitAnswers}

Result

Screen.Recording.2023-11-28.at.18.22.46.mov

[aoneahsan]

i clicked the "Enable Wallet" and it redirected me here,
trying to re-create the issue looking before submitting a proposal,

if i try to add a bank manually it does not allow for a address from pakistan, so any idea how i get to the step where it's showing this error?

[situchan]

cc: @kowczarz @s77rt

[s77rt]

@kowczarz Can you please raise a PR fixing this since it's still within the regression period

[kowczarz]

Sure I will handle this tomorrow morning

[luacmartins]

We might just revert the original PR since it seems like there's another blocker associated with it. We can then work on reintroducing the refactor and fix all the known issues.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "[Form Provider Refactor] IdologyQuestions" #32138

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: [Form Provider Refactor] IdologyQuestions #31401

The rest of the checklist does not apply here. The PR got reverted and we should merge a new one that covers this regression as well

[kowczarz]

I've just introduced a PR with a fix of the issue.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "[Form Provider Refactor] IdologyQuestions" #32138

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@madmax330 / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@madmax330 / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@madmax330 / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@madmax330 / @luacmartins] Determine if we should create a regression test for this bug.
• [@madmax330 / @luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Provider Refactor] IdologyQuestions fixes #32196

If no regressions arise, payment will be issued on 2023-12-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@madmax330 / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@madmax330 / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@madmax330 / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@madmax330 / @luacmartins] Determine if we should create a regression test for this bug.
• [@madmax330 / @luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: