[HOLD for payment 2023-12-28] [$500] BA - Personal information / Beneficial Form entered offline isn't saved after returning online

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.1-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to staging.new Expensify.com or open Expensify App
2. Login with expensifail account
3. Go to existing or create new workspace
4. Go to Settings > Workspace > Bank Account
5. Select any connection type
6. Follow the flow until Personal Information page or Beneficial form page
7. Go offline
8. Fill out form
9. Reload page for web or kill app for apps
10. Go online
11. Go Settings > Workspace > Bank Account
12. Click / Tap 'Continue with setup'

Expected Result:

Information on Personal Information page or Beneficial form page entered offline should be saved

Actual Result:

Information on on Personal Information page or Beneficial form page was NOT saved

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6285023_1700543662363.Desktop-Beneficial-Form-note-saved-offline.mp4

Bug6285023_1700543662360.Desktop-Personal-Info-note-saved-offline.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0172d17b769e15f37c
• Upwork Job ID: 1726917672947712000
• Last Price Increase: 2023-11-21

Issue Owner

Current Issue Owner: @madmax330

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0172d17b769e15f37c

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[izarutskaya]

Not repro on production

20231121_100757.mp4

[s-alves10]

Looks like a regression of the PR #30568

[tienifr]

This affects multiple forms in the app, including all of the Forms in the bank account flow. I'm able to raise a PR immediately if assigned.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Information on on Personal Information page or Beneficial form page was NOT saved

What is the root cause of that problem?

There're some problems with the shouldSaveDraft implementation in FormProvider:

1. It's not using the correct prop to save the Form, it's using propsToParse.formID here which is not right since propsToParse is the props of the input, while the correct one to use is formID
2. It's not connecting to the draft values and override the values with the draft values

What changes do you think we should make in order to solve the problem?

1. Change propsToParse.formID here to formID
2. Connect to the draft values and initially set inputValues to the draft values, similar to what we're doing with the Form component here. We basically move the implementation of that behavior in Form over to the FormProvider.

What alternative solutions did you explore? (Optional)

NA

[s77rt]

We already have a PR that's adding the draft functionality #31401 cc @kowczarz

[luacmartins]

@tienifr are you still able to work on a fix for this? I know we already have a PR adding drafts back to FormProvider, but that PR's main focus is something else and it seems like it won't get merged soon.

[luacmartins]

I'm gonna demote this to NAB. This is an existing issue with all forms using FormProvider and we have a fix for it here

[abekkala]

@sakluger

STATUS:

I'm ooo through Jan 02

This is at the finish line and a PR has already been deployed to staging. after production the waiting period for payment will begin.

• Issue reported by: Applause-Internal Team
• Fix: @kowczarz
• PR Review: @s77rt

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix DatePicker not saving drafts #32815

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger / @abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Form migration NewDatePicker, DateOfBirthPage, EditRequestCreatedPage #29098
• The offending PR has been commented on: Form migration NewDatePicker, DateOfBirthPage, EditRequestCreatedPage #29098 (comment)
• A discussion in #expensify-bugs has been started: not needed
• Determine if we should create a regression test for this bug: Yes

---

Regression Test Proposal

1. Open App
2. Create a workspace if you don't have one
3. Go to Settings > Workspaces > workspace > Bank Account
4. Click Connect manually
5. Follow the flow until you reach the "Company information" step
6. In incorporation date, select any date
7. Refresh the page or restart the flow
8. Verify that the selected date is preserved

[melvin-bot]

@sakluger, @abekkala, @s77rt, @luacmartins Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@sakluger, @abekkala, @s77rt, @luacmartins Eep! 4 days overdue now. Issues have feelings too...

[sakluger]

@s77rt I sent you an offer via Upwork. Please let me know once you've accepted, thanks!

[s77rt]

@sakluger Accepted! Thanks!

[sakluger]

Perfect, thanks! All paid out, thanks everyone 🙇