[HOLD for payment 2023-11-29] [$125] [Form Provider Refactor] AdditionalDetailsStep

[luacmartins]

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/EnablePayments/AdditionalDetailsStep.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0152d37170bf8aab5d
• Upwork Job ID: 1716962802055196672
• Last Price Increase: 2023-10-26

Issue Owner

Current Issue Owner: @cdOut

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0152d37170bf8aab5d

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @cubuspl42 (Internal)

[luacmartins]

@cdOut will you be working on this issue too?

[cdOut]

@luacmartins yes, I will be working on this issue.

[cdOut]

Hello, I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency, and I would like to work on this task.

[melvin-bot]

Current assignee @cubuspl42 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Upwork job price has been updated to $125

[alexpensify]

Thank you for these updates!

[melvin-bot]

@cubuspl42, @alexpensify, @luacmartins, @cdOut Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

We have a draft PR

[luacmartins]

Same as above

[alexpensify]

Thanks for the update!

[cdOut]

Still working on it, this along with another issue is intertwined and I have to fix issues with both before proceeding further with it, it should be this week

[alexpensify]

Daily Update: The PR is under review!

[alexpensify]

Looks like the PR has been merged, so now we wait for automation.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.1-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Provider Refactor] AdditionalDetailsStep and AddressForm #30568

If no regressions arise, payment will be issued on 2023-11-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment
• @cdOut does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
• [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cubuspl42] Determine if we should create a regression test for this bug.
• [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

@cubuspl42 - to prepare for the payment date, can you please complete the checklist? Thanks!

[cubuspl42]

• The PR that introduced the bug has been identified. Link to the PR:
  • N/A (this is not a bug)
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • No need for additional discussion
• Determine if we should create a regression test for this bug.
  • No, we shouldn't (this is not a bug)
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • N/A

[alexpensify]

Here is the payment summary:

• External issue reporter - N/A
• Contributor that fixed the issue - @cdOut payment handled via vendor
• Contributor+ that helped on the issue and/or PR - $125 @cubuspl42

Upwork Job: https://www.upwork.com/jobs/~01af73ad283fbbe4ff

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: Payment was updated here - #30311 (comment)

---

@cubuspl42 - I've sent an offer in Upwork, please accept and I can complete the payment process there. Thanks!

[cubuspl42]

@alexpensify Done

[alexpensify]

Awesome-- I've completed the payment process in Upwork.