[HOLD for payment 2024-08-19] [HOLD] [$500] IOS - Bank account - Keyboard pulls up when redirected to BA page after tapping Pay with Expensify

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.4.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: The default currency for the workspace is USD.

1. Go to the workspace chat from the precondition.
2. Create a workspace expense (Manual).
3. Tap on the composer.
4. Tap Pay with Expensify.
5. Tap Business bank account.

Expected Result:

Describe what you think should've happened

Actual Result:

Keyboard pulls up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6293170_1701176884214.RPReplay_Final1701125134.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e85396f1cd4ec884
• Upwork Job ID: 1729490424428687360
• Last Price Increase: 2023-12-05
• Automatic offers:
• situchan | Reviewer | 103325898

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e85396f1cd4ec884

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Keyboard pulls up.

What is the root cause of that problem?

We're not dismissing the keyboard when opening the KYC wall

What changes do you think we should make in order to solve the problem?

Dismiss the keyboard when opening the KYC wall

Alternatively, we can wait until this is done, then set shouldRestoreKeyboard=false to the modal of the add payment method.

What alternative solutions did you explore? (Optional)

If we want to refocus on Composer after the KYCWall close, we can trigger the focus manually after KYCWall closes (without selecting any item), we can do this by modify the onClose callback to have a isItemSelected variable, if it's false, then trigger focusing on the composer manually.

[bernhardoj]

We should hold this for #24452 (comment)

[situchan]

Makes sense to hold

[melvin-bot]

@MitchExpensify, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[situchan]

Not overdue

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[MitchExpensify]

Not overdue, On Hold for #24452 (comment)

[melvin-bot]

@MitchExpensify, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

On hold

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @situchan

[johncschuster]

@situchan can we get a status on the review?

[situchan]

@situchan can we get a status on the review?

C+ approved

[johncschuster]

Looks like the PR above was deployed to staging 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix keyboard shows briefly when open BA page from payment method popover menu #46507

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @situchan requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

Acknowledged! I'll issue payment after the regression threshold is cleared.

[johncschuster]

Bumping this to reset the Melvin clock. I will pay this out on the 19th assuming no regressions.

[johncschuster]

Payment Summary:

Contributor: @bernhardoj paid $500 via NewDot
Contributor+: @situchan owed $500 via Upwork - PAID 🎉

[johncschuster]

@situchan, do you feel we need a regression test? If so, can you provide one?

[situchan]

I don't think we need regression test as this is iOS only issue and does not affect product.

[bernhardoj]

Requested in ND.

[johncschuster]

I don't think we need regression test as this is iOS only issue and does not affect product.

Awesome. In that case, I'll close this up since we don't need to keep it open for ND payments. Thank you both for your contributions!

[JmillsExpensify]

$500 approved for @bernhardoj