-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keyboard shows briefly when open BA page from payment method popover menu #46507
Fix keyboard shows briefly when open BA page from payment method popover menu #46507
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.mp4Android: mWeb Chromemchrome.mp4iOS: Nativeios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.movMacOS: Desktop |
"Pay with Expensify" automatically triggers plaid flow without selecting "Business bank account". This video is captured based on latest main branch: Screen.Recording.2024-07-30.at.2.11.37.PM.movkeyboard still shows briefly on this branch: Screen.Recording.2024-07-30.at.2.19.22.PM.mov |
Ah, yes, I forgot to inform you that the code will always select the personal bank account after the popover is shown. App/src/components/AddPaymentMethodMenu.tsx Lines 75 to 82 in f0d8114
I commented that code so it works properly again.
You need to select the payment option first. |
We can wait until #46490 is fixed today. |
That issue is fixed it seems, can we continue here? |
Merged with main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.18-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.18-10 🚀
|
Details
If we open the payment method menu while the input is focused, the OS will refocus on the input when the modal is closed which shows the keyboard briefly. This PR fix it by using the new focus management.
Fixed Issues
$ #32116
PROPOSAL: #32116 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mwev.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4