Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle notification #32144

Closed
hayata-suenaga opened this issue Nov 28, 2023 · 20 comments
Closed

Handle notification #32144

hayata-suenaga opened this issue Nov 28, 2023 · 20 comments
Assignees
Labels
NewFeature Something to build that is a new item. Weekly KSv2

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Nov 28, 2023

Implement a logic that handles notification according to the following two new requirements (part of Wave 8 Ideal Nav).

  1. When a notification is clicked/tapped, make sure that the currently-selected bottom tab item is "Chats".
  2. If the notification is about a report that doesn't belong to the currently-active workspace, the active workspace should change to the Expensify/All (which displays all reports across workspaces in addition to off-workspace reports that doesn't belong to any workspace).

Relevant section of the design doc.

@hayata-suenaga hayata-suenaga added the NewFeature Something to build that is a new item. label Nov 28, 2023
@hayata-suenaga hayata-suenaga self-assigned this Nov 28, 2023
Copy link

melvin-bot bot commented Nov 28, 2023

@hayata-suenaga
Copy link
Contributor Author

hayata-suenaga commented Nov 28, 2023

I gonna reassign a Bug Zero member when it's time for C+ review payment.

@hayata-suenaga hayata-suenaga changed the title Handle notification [Draft] Handle notification Nov 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 7, 2023
@hayata-suenaga
Copy link
Contributor Author

design doc review still going on

@melvin-bot melvin-bot bot removed the Overdue label Dec 7, 2023
@hayata-suenaga hayata-suenaga changed the title [Draft] Handle notification Handle notification Dec 12, 2023
@adamgrzybowski
Copy link
Contributor

@hayata-suenaga Is it still in review?

@adamgrzybowski
Copy link
Contributor

You can assign me here anyway

@hayata-suenaga hayata-suenaga added Daily KSv2 and removed Weekly KSv2 labels Dec 13, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 13, 2023
@hayata-suenaga
Copy link
Contributor Author

@hayata-suenaga Is it still in review?

Nop it's ready to be worked on. Let me know if you have any questions 👍

@hayata-suenaga
Copy link
Contributor Author

forgot to assign you here @adamgrzybowski sorry about that

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

@adamgrzybowski, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@hayata-suenaga
Copy link
Contributor Author

hayata-suenaga commented Dec 20, 2023

@adamgrzybowski I vaguely remember that you mentioned that you have to rethink about the implementation now that the some project requirements have changed (instead of storing the active Workspace ID, we decided to store the last visited path). How is your implementation planning going?

I know you're also working on the Bottom Navigation and some other issues. Are you planning to work on the notification after these other issues are done?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 20, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

@adamgrzybowski, @hayata-suenaga Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Dec 28, 2023

@adamgrzybowski, @hayata-suenaga Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Jan 1, 2024

@adamgrzybowski, @hayata-suenaga 10 days overdue. I'm getting more depressed than Marvin.

Copy link

melvin-bot bot commented Jan 2, 2024

@adamgrzybowski, @hayata-suenaga 12 days overdue now... This issue's end is nigh!

1 similar comment
Copy link

melvin-bot bot commented Jan 3, 2024

@adamgrzybowski, @hayata-suenaga 12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 8, 2024
Copy link

melvin-bot bot commented Jan 8, 2024

This issue has not been updated in over 14 days. @adamgrzybowski, @hayata-suenaga eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Jan 8, 2024
@hayata-suenaga
Copy link
Contributor Author

@adamgrzybowski let me know if you're working on this in the Software Mansions' internal branch

@melvin-bot melvin-bot bot added the Overdue label Jan 16, 2024
@hayata-suenaga
Copy link
Contributor Author

Asked on slack if SWM is working on this. Nevertheless, this will come later as the navigation structure is built.

@melvin-bot melvin-bot bot removed the Overdue label Jan 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@hayata-suenaga
Copy link
Contributor Author

@mateuuszzzzz could you confirm that we're handling notification outside the feature branch or does the feature branch already contains code to handle notifications?

@melvin-bot melvin-bot bot removed the Overdue label Jan 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 7, 2024
@hayata-suenaga
Copy link
Contributor Author

I haven't tested the notification. I'll do that and then close this issue

@melvin-bot melvin-bot bot removed the Overdue label Feb 7, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 15, 2024
@hayata-suenaga
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

3 participants