Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-12] Android - Room - Hard to focus the name input field after the error message appears #32402

Closed
1 of 6 tasks
kbecciv opened this issue Dec 2, 2023 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Dec 2, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.7-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open the App
  2. Log in with any Expensifail account
  3. Press + button > Press Start chat > Switch to # Room
  4. Enter incorrect data for receiving an error
  5. Focus on another input field
  6. Try to focus again on the name input field

Expected Result:

No any problems with focusing the name input field after the error message appears

Actual Result:

Hard to focus the name input field after the error message appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6298606_1701520803574.Record_2023-12-01-20-39-05_4f9154176b47c00da84e32064abf1c48.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Dec 2, 2023
Copy link
Contributor

github-actions bot commented Dec 2, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 2, 2023

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv
Copy link
Author

kbecciv commented Dec 2, 2023

Not reproduced on production

Screen_Recording_20231202_200933_New.Expensify.mp4

@luacmartins
Copy link
Contributor

Potentially caused by #30996

@luacmartins
Copy link
Contributor

Gonna see if the revert fixes this issue

@luacmartins
Copy link
Contributor

Fixed on this revert #32440

@dangrous
Copy link
Contributor

dangrous commented Dec 5, 2023

Thank you for handling! We should figure out why I was assigned an hourly on a weekend though - or was it just that everyone was off so it picked randomly?

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Dec 5, 2023
@melvin-bot melvin-bot bot changed the title Android - Room - Hard to focus the name input field after the error message appears [HOLD for payment 2023-12-12] Android - Room - Hard to focus the name input field after the error message appears Dec 5, 2023
Copy link

melvin-bot bot commented Dec 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@kowczarz
Copy link
Contributor

kowczarz commented Dec 5, 2023

I've tried to reproduce this issue on here #32432 (the #32440 is reverted, so the bug should occur) and I couldn't do it

Screen.Recording.2023-12-05.at.09.52.15.mov

@luacmartins
Copy link
Contributor

hmm that issue was resolved when I reverted #30996. Not sure why it's not reproducible. In that case, I'd just add a test step covering the issue so we make sure to test it and that's indeed fixed.

@kowczarz
Copy link
Contributor

kowczarz commented Dec 7, 2023

I know, but I tested it on a branch where I reverted that revert. I just added this flow to test scenarios in #32432

@luacmartins
Copy link
Contributor

Sounds good! Thanks for adding that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants