[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-12] [$500] Room - Error shows up when saving existing and valid room name with any changes

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.7-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to + > Start chat > Room.
3. Create a room with a valid name.
4. Go to the room > Click header > Settings.
5. Click Room name.
6. Click Save without any edit.

Expected Result:

Room name is saved successfully as the existing room name is valid.

Actual Result:

Error shows up when saving existing valid room name with any changes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6298723_1701527125984.bandicam_2023-12-02_20-36-02-824.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0106db335debd1ea53
• Upwork Job ID: 1731637112209268736
• Last Price Increase: 2023-12-04

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Issue is not reproduced on production

bandicam.2023-12-02.20-38-35-769.mp4

[ishpaul777]

regression from #30996

[ishpaul777]

Proposal

Problem

Room - Error shows up when saving existing and valid room name with any changes

Root Cause

inputValues[${inputID}ToDisplay] is not initialized unless the onChange is triggered on input. We have a displayvalueParser and valueParser which only called when there is a changes in input here so the value without input change has no change and conditon for early return when roomname === reportname failed hence we see a error.

Changes Suggested to fix

we need to initialize the inputValues[`${inputID}ToDisplay`] if there's a valueparser and displayParser when input is registered. Add below code here.

if (_.isUndefined(inputValues[inputID])) {
    const { defaultValue, valueParser, displayParser, valueType } = propsToParse;

    inputValues[inputID] = (valueParser && defaultValue) ? valueParser(defaultValue) : defaultValue || getInitialValueByType(valueType);

    if (displayParser) {
        inputValues[`${inputID}ToDisplay`] = displayParser(defaultValue);
    }
}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0106db335debd1ea53

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Current assignee @Santhosh-Sellavel is eligible for the External assigner, not assigning anyone new.

[nkuoch]

Privileging @kowczarz to do the fix as he is the author of the original PR.
If he can't do it in time, we can go with @ishpaul777.
If @kowczarz ends up using @ishpaul777 's proposal, we can pay @ishpaul777 25% (so $125).

[kowczarz]

Hello, I'm working on fix right now.

[melvin-bot]

📣 @Santhosh-Sellavel Please request via NewDot manual requests for the Reviewer role ($500)

[kowczarz]

@ishpaul777 has correctly localised the root problem, but my solution will slightly differ in syntax. I don't see any reasons to write another proposal. Can I proceed to the PR?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[yuwenmemon]

Revert deployed so removing the blocker label.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "[Form Provider Refactor] RoomNameInput fixes" #32440

If no regressions arise, payment will be issued on 2023-12-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel requires payment via manual request.
• @kowczarz does not require payment (Contractor)

[Santhosh-Sellavel]

No payments due as this was a regression & the PR caused this got reverted. We are good to close!

[luacmartins]

Sounds good. Thanks everyone!

[ishpaul777]

@nkuoch @luacmartins just curious if should expect a compensation as the new PR will include a solution similar to fix i suggested in proposal just different syntax wise #32398 (comment)

[nkuoch]

I think so, but let's wait for the new PR to be ready to be reviewed, tested and approved first. So we can make sure the solution worked.

[ishpaul777]

Okay! Thanks for clarifying!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Provider Refactor] RoomNameInput fixes #32432

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel requires payment through NewDot Manual Requests
• @kowczarz does not require payment (Contractor)