[HOLD for payment 2023-12-18] Remove sideloading of Onyx data forMoneyRequestView.js

[tgolen]

Coming from #27262

Problem

These methods are anti-patterns because they are most always used for loading data into a component without using withOnyx(). This breaks the data flow of a react application. (data is coming from somewhere that is not props or state and cannot be debugged in react dev tools).

Solution

Switch all references to properly use withOnyx() for components and connect() for libs.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.10-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Get the parent report action using withOnyx for the money request view #32446

If no regressions arise, payment will be issued on 2023-12-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[tgolen]

@trjExpensify Can you please help here with the payouts?

@Santhosh-Sellavel needs to be paid for a C+ review

[trjExpensify]

Yep, can do! This looks like a regular job, not something like TypeScript migration related. So I can confirm the payout is $500 for the C+ review of the internal PR.

@Santhosh-Sellavel once you've confirmed to have requested on NewDot, we can close this out.

[trjExpensify]

Bump @Santhosh-Sellavel have you requested?

[melvin-bot]

@tgolen, @trjExpensify Huh... This is 4 days overdue. Who can take care of this?

[tgolen]

Bump @Santhosh-Sellavel to accept request.

[Santhosh-Sellavel]

Feel free close this one, I'll request on ND later this week!

[Santhosh-Sellavel]

Requested on ND

[JmillsExpensify]

$500 payment approved for @Santhosh-Sellavel based on this comment.