-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Workspace creation - 'Hmm... it's not here' in NewDot after workspace creation under OldDot #32479
Comments
Job added to Upwork: https://www.upwork.com/jobs/~0196515bd9ca529284 |
Triggered auto assignment to @dylanexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Workspace creation - 'Hmm... it's not here' in NewDot after workspace creation under OldDot What is the root cause of that problem?In this PR while the new navigation was being made, it was decided that the user will be redirected to Lines 407 to 409 in 0a4db44
But actually we don't want to navigate to App/src/pages/LogOutPreviousUserPage.js Lines 57 to 60 in 9b71f23
This navigation will override What changes do you think we should make in order to solve the problem?In if (exitTo && !props.account.isLoading && !isLoggingInAsNewUser) {
Navigation.isNavigationReady()
.then(() => {
if(exitTo === ROUTES.WORKSPACE_NEW){
App.setUpPoliciesAndNavigate(props.session);
return;
}
Navigation.navigate(exitTo)
});
} ResultScreen.Recording.2023-12-05.at.9.29.33.PM.mov |
Reviewing shortly! |
Please note, I have significantly changed my proposal as I was not happy with it. |
@alitoshmatov could you please review the proposal? |
Reviewing |
@AmjedNazzal |
If you noticed this code is running first Lines 411 to 420 in 0a4db44
then code in logout user page is running. Why the first navigation is not taking effect? Even adding condition to prevent this whole navigation is from running is not helping App/src/pages/LogOutPreviousUserPage.js Lines 57 to 60 in 9b71f23
|
@alitoshmatov I did notice the double creation issue at some point in earlier code I was working with but it seemed like I resolved it but I guess not so I will look into that. also to be fair I did notice general navigation issues such as things not getting executed when they should be and things getting called multiple times so I will look into all that and update my proposal when I have something. |
Well, this issue has been resolved in this PR, not sure why that github issue was opened and worked on while this issue is ongoing but oh well. |
Oh ok, I was not aware of the duplicate issues, thanks for flagging |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): everyone
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/334523
Issue reported by: Applause
Slack conversation: N/A - short internal discussion here
Action Performed:
Prerequisites: Must log out from OldDot and NewDot
Expected Result:
Get logged in and directed to the Edit Workspace modal
Actual Result:
Get logged in and directed to 'Hmmm it's not there' error
Workaround:
Yes
Platforms:
Which of our officially supported platforms is this issue occurring on?
Probably all
Screenshots/Videos
Screen.Recording.2023-12-04.at.14.12.15.mov
Recording.1965.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: