[HOLD for payment 2024-01-09] BA - Previous month it's displayed on calendar after coming back to form

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.8-0
Reproducible in staging?: Y
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to any workspace
2. Select "Bank account"
3. Try to set up a bank account until you reach the "Company information" form
4. Fill the form, on the incorporation field select any 1st of the month date (e.g. December 1st, 2022)
5. Tap on "Save & continue"
6. Once you see the "Personal information" page, tap on the arrow to go back
7. Scroll down to the "Incorporation field" again

Expected Result:

The calendar should display the month the user selected

Actual Result:

The calendar shows the month prior to the one selected by the user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6302413_1701812765238.Krio7836_1_.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

Gonna remove the blocker because I think this is only getting reported because testers can't test on production. I would guess the problem exists there. But it is also very minor.

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Previous month is displayed on calendar reload when first day of month is previously selected
This happens only for users who are in negative timezone (GMT -x, not GMT +x)

What is the root cause of that problem?

App/src/components/DatePicker/CalendarPicker/index.js

Line 54 in 5a0b7fd

let currentDateView = new Date(props.value);

Here, props.value doesn't have any timezone info (i.e. 2022-12-01)
and new Date(props.value) parses date as GMT and resets date based on user timezone (i.e. if user timezone is GMT-4: Tue Nov 30 2022 20:00:00 GMT-0400)
So month is Nov instead of Dec

What changes do you think we should make in order to solve the problem?

use parseISO(props.value)
We already applied same solution in different place in #30845, #30923

[situchan]

This seems like another instance of new Date() not being replaced.
The proposal looks good.

@sophiepintoraetz I can take this as C+ if you don't mind as I already have context while reviewing similar PR

[sophiepintoraetz]

Perfect, will assign you!

[situchan]

Thanks @sophiepintoraetz

[situchan]

proposal
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[puneetlath]

Solution seems straightforward. Is there any way for us to prevent this type of issue in the future? Perhaps via linting or something?

[melvin-bot]

@puneetlath, @sophiepintoraetz, @mkhutornyi, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sophiepintoraetz]

@mkhutornyi - do you have a draft PR up? Can you keep track of your progress on here please?

[mkhutornyi]

Draft PR is up. Will get ready for review by tomorrow

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.20-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix previous month display on calendar after coming back to form #32889

If no regressions arise, payment will be issued on 2024-01-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mkhutornyi requires payment (Needs manual offer from BZ)
• @situchan requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sophiepintoraetz]

Offers sent! @situchan - I'll release payment once the checklist is completed

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: Reopened/Feature: Remove moment from datepicker #29984
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/29984/files#r1445708926
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. This was deploy blocker. QA team caught this during regression test on staging build. so N/A
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @mkhutornyi paid $(AMOUNT) via Upwork (LINK)
• ROLE: @situchan paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[sophiepintoraetz]

Hmm, not sure what that is about - paid contracts here:
@mkhutornyi - $500
@situchan $500