[PAID] LOW: [$500] Android-Thread-In Android, with uneven spacing as text entered, displayed in reply thread title

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a chat
3. Send a message with uneven spacing
4. Long press the message sent and select Reply in thread
5. Note the header in mweb
6. Launch app
7. Perform step 2-step4
8. Note the header in Android

Expected Result:

In reply thread page, in both mweb and Android, the title must be shown in a consistent way.

Actual Result:

In reply thread page, in mweb, text title is shown with normal spacing but in Android, with uneven spacing as text entered, it is displayed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6302743_1701842027653.reep.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01208eb9280d67b191
• Upwork Job ID: 1732348414892351488
• Last Price Increase: 2023-12-27
• Automatic offers:
• alitoshmatov | Reviewer | 28088147
• tienifr | Contributor | 28088148

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01208eb9280d67b191

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In reply thread page, in mweb, text title is shown with normal spacing but in Android, with uneven spacing as text entered, it is displayed.

What is the root cause of that problem?

We have white-space: nowrap set for the thread header so it doesn't preserve the white space in web. Making it inconsistent with Android.

What changes do you think we should make in order to solve the problem?

Remove white-space: nowrap for the thread header here so it preserves the white space in web. Or can add pre or pre-wrap as well.

To handle the text with new lines, we can format the text by removing line breaks similar to here

This approach is the same as in this PR where we fix this same problem in another place (LHN)

What alternative solutions did you explore? (Optional)

If we want to collapse white space, use whitespace: noWrap for the component of header for Android as well.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The thread title in header have a different white space behavior between native and mWeb.

What is the root cause of that problem?

We previously fixed this by adding a white-space of pre, but the title has a style of white-space: no-wrap which overrides the white-space from textStyles

App/src/components/DisplayNames/DisplayNamesWithTooltip.tsx

Line 50 in e1fcb42

style={[textStyles, styles.pRelative, numberOfLines === 1 ? styles.noWrap : {}]}

no-wrap will collapse the whitespace and white-sapce is only available on web, that's why we have a different whitespace behavior

no-wrap is added to fix an issue of a money request header title contains a multiline description.
#21664 (comment)

If we remove the no-wrap, a money request header with multiline description will shows as multi line.

What changes do you think we should make in order to solve the problem?

First, remove the white-space no-wrap style from DisplayNameWithTooltips.

Next, to fix the multiline issue, we can replace all new line from the money request description with an empty string, just like we did in #27822

App/src/libs/ReportUtils.ts

Line 1902 in bbe73ef

comment: transactionDetails?.comment ?? '',

comment: (transactionDetails?.comment ?? '').replace(CONST.REGEX.LINE_BREAK, '')

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The thread title in header have a different white space behavior between native and mWeb.

What is the root cause of that problem?

On mWeb, we use styles.noWrap and this make several space to one space.

App/src/components/DisplayNames/DisplayNamesWithTooltip.tsx

Line 50 in bbe73ef

style={[textStyles, styles.pRelative, numberOfLines === 1 ? styles.noWrap : {}]}

On native, we don't have that and that doesn't work on native.

App/src/components/DisplayNames/index.native.tsx

Line 12 in bbe73ef

style={textStyles}

What changes do you think we should make in order to solve the problem?

We need add new function for native

const title = String(fullTitle).trim().replace(/\s\s+/g, ' ').trim();

And use title instead of fullTitle

App/src/components/DisplayNames/index.native.tsx

Line 15 in bbe73ef

{fullTitle || translate('common.hidden')}

What alternative solutions did you explore? (Optional)

[strepanier03]

Raised for internal discussion, pausing.

[quinthar]

Let's keep this, cross-platform consistency ftw. Adding to VIP.

[strepanier03]

@quinthar - Is Daily still the right priority for this one or can we move it to at least weekly since it's low?

[strepanier03]

Moving this to weekly since it's Low priority. Please feel free to update labels as needed when priority changes.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[alitoshmatov]

Reviewing

[alitoshmatov]

@strepanier03 Can you clarify what is the expected outcome here.

If text with multiple consequent spaces are enter(hello world), how we should show it?

a) Collapse spaces - hello world
b) Keep them and display them as it is

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[techievivek]

Ooops sorry, I missed the ping.

[strepanier03]

Thanks @techievivek - @tienifr will you submit the draft PR soon?

[strepanier03]

All good Melvin.

[tienifr]

@strepanier03 Opps. I thought that's because I marked the PR ready when GH was down several days ago so there's error and nothing happened. Anw it's ready for review now.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Inconsistency of spacing in thread title #34128

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment automatic offer (Reviewer)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
• [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@alitoshmatov] Determine if we should create a regression test for this bug.
• [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alitoshmatov]

• The PR that introduced the bug has been identified. Link to the PR: allow Request money 'Description' to accept multiline #21664
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/21664/files#r1464963197
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
• Determine if we should create a regression test for this bug. No need

[alitoshmatov]

This is ready for payment

[strepanier03]

Dang, another one where the automation didn't work to move this over to Daily. I'll work on this now.

[strepanier03]

All paid up and contracts closed. Thanks everyone!