[HOLD for payment 2023-10-09] [$500] LHN - Extra spaces between text is not displayed on LHN (works fine on android app)

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send text with more then 1 space in between
4. Observe LHN
5. Send text with lots of space between text too trigger 3 dots in LHN
6. Edit the text and observe that it displays the full text for sometime before removing some to display 3 dots

Expected Result:

App should display all extra space between text in LHN and app should directly display 3 dots in LHN if text is big

Actual Result:

Extra spaces between text is not displayed on LHN and on edit, app displays full text for sometime before changing some to 3 dots

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70-5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

space.between.text.LHN.issue.mp4

Recording.30.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694605928056549

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014293d43d0d5d8fcf
• Upwork Job ID: 1703106405263683584
• Last Price Increase: 2023-09-16
• Automatic offers:
• DylanDylann | Contributor | 26848353

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Extra spaces between text is not displayed on LHN (works fine on android app)

What is the root cause of that problem?

• Because of using whiteSpace: noWrap for the LHN subtitle, all the extra spaces between text is not displayed
  

  App/src/components/LHNOptionsList/OptionRowLHN.js

  Lines 86 to 91 in 76c1559

  	const alternateTextStyle = StyleUtils.combineStyles(
  	props.viewMode === CONST.OPTION_MODE.COMPACT
  	? [textStyle, styles.optionAlternateText, styles.noWrap, styles.textLabelSupporting, styles.optionAlternateTextCompact, styles.ml2]
  	: [textStyle, styles.optionAlternateText, styles.noWrap, styles.textLabelSupporting],
  	props.style,
  	);

• To fix the issue: LHN alternativeText is also multilined, we have used the whiteSpace: noWrap style allow Request money 'Description' to accept multiline #21664 (comment).
• But here fix - Translate IOU contents to the correct langauage #25629, we have already changed the way to get the LHN subtitle, so the above bug is not appeared

What changes do you think we should make in order to solve the problem?

• As I mentioned in the RCA, now we can using whilteSpace: pre style with the LHN subtitle

Result

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014293d43d0d5d8fcf

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @johncschuster (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[MitchExpensify]

How does @DylanDylann 's proposal look to you @robertKozik ?

[robertKozik]

@DylanDylann @MitchExpensify sorry for the delay. I've checked your proposal and It looks great. I've double checked that there is no regression from the PR's you provided. Reverting noWrap to pre is causing no harm, and fixes our problem. Let's proceed with this one

Contributor: @DylanDylann
Proposal: #27586 (comment)

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @danieldoglas, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MitchExpensify]

Assigning @DylanDylann looks like the next step here @danieldoglas

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[DylanDylann]

@robertKozik PR #27822 is ready for review

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @DylanDylann got assigned: 2023-09-25 01:50:01 Z
• when the PR got merged: 2023-09-28 02:42:03 UTC
• days elapsed: 3

On to the next one 🚀

[DylanDylann]

The PR lasted a little longer than 3 days because of the timezone difference like this issue. Are we eligible for a bonus here?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/27586: Extra spaces between text is not displayed #27822

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @robertKozik does not require payment (Contractor)
• @DylanDylann requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Payment summary:

$50 @dhanashree-sawant Reporting (Please accept offer on the Upwok job here - https://www.upwork.com/jobs/~014293d43d0d5d8fcf)
$750 @DylanDylann requires payment offer (Contributor)

[MitchExpensify]

Added a reminder to pay out on the 9th

[dhanashree-sawant]

Hi @MitchExpensify, the following issue reporting bonus should had been 50$ but I have accepted the 250$ offer without cross checking 😅. Let me know what we can do to solve this issue.

[robertKozik]

BugZero Checklist:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: allow Request money 'Description' to accept multiline #21664
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: allow Request money 'Description' to accept multiline #21664 (comment)
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. It was visual bug which didn't influence any user flow, so I don't think the regression test is needed here
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[MitchExpensify]

Hi @MitchExpensify, the following issue reporting bonus should had been 50$ but I have accepted the 250$ offer without cross checking 😅. Let me know what we can do to solve this issue.

No worries! I'll just reduce the payment accordingly when the 9th comes around 👍

[MitchExpensify]

Paid @dhanashree-sawant

@DylanDylann I requested a refund because I paid too much via the bonus, sorry about that!

Once the refund is issued I'll close this out and end your contract @DylanDylann

Thanks, everyone!

[melvin-bot]

@danieldoglas, @MitchExpensify, @robertKozik, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[DylanDylann]

@MitchExpensify I've refunded, thank you!

[MitchExpensify]

Thanks @DylanDylann !