[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [HOLD #32672] [Theme Switching] 🐛 Web - Chat - The scroll bar is white in the emoji suggestion list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.9-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to any chat
4. Enter any emoji code (e.g: 👋 , 😬 , 😄 , etc) or "@" for opens a list of user suggestions

Expected Result:

The scroll bar is grey

Actual Result:

The scroll bar is white

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence


View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011c2daa05ba8f632d
• Upwork Job ID: 1732790748658282496
• Last Price Increase: 2023-12-07
• Automatic offers:
• shubham1206agra | Reviewer | 27999537

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[bondydaa]

taking a look at the staging checklists but I don't think this needs to block future deploys, it's a style thing which can be handled with a follow up PR.

[bondydaa]

hmm what makes you think that PR? I don't see that it touched anything with emojis or style sheets.

[situchan]

@bondydaa this came from this removal

[situchan]

I think we can demote this to NAB unless that offending PR caused any other regressions.

[ZhenjaHorbach]

Oh )
Sorry ))
Not this regression ))

[bondydaa]

yeah looks like we said we'd do a follow up PR to fix this #32259 (comment)

cc @grgia .

@situchan are you able to reproduce this? If so can you confirm if you're using windows? @parasharrajat same ❓ you a windows user? #32259 (review)

[situchan]

I reproduced this even on mac web. Re-adding those lines fixed the bug.

[bondydaa]

ok great thanks for confirming that

[grgia]

@bondydaa that change was part of the theme switching project. We can re-add it for now, but it will be very a temporary fix as it does not work to hard code that line as dark for light mode, which should be released in the next week.

cc @chrispader who worked on the scroll bar changes-

[grgia]

@bondydaa I'm also unable to reproduce on mac. If this is windows only, its not a bug

[situchan]

@grgia you need to type emoji code or mention @ in composer, not emoji button

Screen.Recording.2023-12-07.at.5.06.14.AM.mov

[grgia]

if the other scrollbars are working, I think there's an alternative fix @situchan

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji and mention suggestion scrollbar is white.

What is the root cause of that problem?

After the theme style migration PR, we removed the hard-coded color-scheme: dark from index.html and get replaced with ColorSchemeWrapper.

App/src/components/ColorSchemeWrapper/index.tsx

Lines 6 to 11 in 43b1722

	function ColorSchemeWrapper({children}: React.PropsWithChildren): React.ReactElement {
	const theme = useTheme();
	const styles = useThemeStyles();
	return <View style={[styles.flex1, styles.colorSchemeStyle(theme.colorScheme)]}>{children}</View>;
	}

We then wrap the whole app with ColorSchemeWrapper.

App/src/App.js

Lines 76 to 78 in 43b1722

	<ColorSchemeWrapper>
	<Expensify />
	</ColorSchemeWrapper>

But emoji and mention suggestions use a portal and we attach it to the body outside of <div id="root"> element.

What changes do you think we should make in order to solve the problem?

In AutoCompleteSuggestions, wrap the component with ColorSchemeWrapper. We did this in Modal and Popover too.

App/src/components/Modal/BaseModal.tsx

Line 211 in 43b1722

<ColorSchemeWrapper>{children}</ColorSchemeWrapper>

App/src/components/PopoverWithoutOverlay/index.js

Line 118 in 43b1722

<ColorSchemeWrapper>{props.children}</ColorSchemeWrapper>

<View style={StyleUtils.getBaseAutoCompleteSuggestionContainerStyle({left, width, bottom})}>
    <ColorSchemeWrapper>{componentToRender}</ColorSchemeWrapper>
</View>

[parasharrajat]

Yeah, we encountered these on the original PR and fixed as much as we noticed. We can fix the rest of these scrollbar issues in this GH.

I can reproduce this on Mac.

@bernhardoj proposal looks good to me. Let's wait for the audit before creating a PR.

@lanitochka17 Can you please do an audit and add all such scrollbar issues in this GH?

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @bondydaa is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[chrispader]

This issue is handled here: #32672

[parasharrajat]

#32672 is targeting a few style issues which will also solve this. so we can hold on to that PR. In the end, if that PR solves it, I don't think we need C+ payment here as that PR is originally linked to one existing issue with different C+ who is reviewing that PR.

[chrispader]

Based on #18963, @chrispader works with an agency so they do not require payment through Upwork. And @parasharrajat will be paid via NewDot manual request.

@bondydaa just to confirm, this will be fixed in #32672 correct?

yes!

[sakluger]

@parasharrajat thanks for clarifying, that helps! I've added a hold for #32672.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix issues with scrollbar and status bar color #32672

If no regressions arise, payment will be issued on 2023-12-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @chrispader does not require payment (Contractor)
• @parasharrajat requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix issues with scrollbar and status bar color #32672

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @chrispader does not require payment (Contractor)
• @parasharrajat requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

I'm offline this week, along with most of my team for the holidays. I'll handle payment as soon as I return on Jan 2.

[parasharrajat]

No payment is required here. We are good to close.

[sakluger]

Sounds good, closing.