Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-15] [Theme Switching Migration] - finalize theme hook migration for App #32257

Closed
grgia opened this issue Nov 30, 2023 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@grgia
Copy link
Contributor

grgia commented Nov 30, 2023

@chrispader

Issue OwnerCurrent Issue Owner: @JmillsExpensify
@grgia grgia self-assigned this Nov 30, 2023
@grgia grgia converted this from a draft issue Nov 30, 2023
@grgia grgia moved this to In Progress in Theme Switching / Light Mode Nov 30, 2023
@chrispader
Copy link
Contributor

comment for assignment :)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Monthly KSv2 labels Nov 30, 2023
@grgia grgia moved this from In Progress to Merged in Theme Switching / Light Mode Dec 6, 2023
Copy link

melvin-bot bot commented Dec 6, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 Monthly KSv2 labels Dec 8, 2023
@melvin-bot melvin-bot bot changed the title [Theme Switching Migration] - finalize theme hook migration for App [HOLD for payment 2023-12-15] [Theme Switching Migration] - finalize theme hook migration for App Dec 8, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 8, 2023
Copy link

melvin-bot bot commented Dec 8, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@grgia grgia moved this from Merged to Done - Live ✅ in Theme Switching / Light Mode Dec 14, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 14, 2023
Copy link

melvin-bot bot commented Dec 18, 2023

@chrispader, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

@chrispader, @grgia Eep! 4 days overdue now. Issues have feelings too...

@chrispader
Copy link
Contributor

@grgia can we close this out?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 19, 2023
@grgia grgia closed this as completed Dec 21, 2023
@grgia grgia reopened this Dec 21, 2023
@grgia grgia added the NewFeature Something to build that is a new item. label Dec 21, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Dec 21, 2023
@grgia
Copy link
Contributor Author

grgia commented Dec 21, 2023

@strepanier03 could you help ensure that the $500 C+ review payment for #32259 is made to @parasharrajat

@strepanier03
Copy link
Contributor

@grgia - Yes I can start working on this and see if I can get it all finished today. Otherwise I'm out until the 28th when I'll pick it back up.

@strepanier03 strepanier03 added Daily KSv2 and removed Weekly KSv2 labels Dec 21, 2023
@strepanier03
Copy link
Contributor

@parasharrajat - I've hired you to the job in Upwork, accept as soon as you can and I'll pay it out. I'm offline after today until the 28th.

@parasharrajat
Copy link
Member

parasharrajat commented Dec 22, 2023

@strepanier03 I am paid via Newdot so I will request it later. I just need a payment summary. Please cancel the offer and feel free to close this issue as well.

@melvin-bot melvin-bot bot added the Overdue label Dec 25, 2023
Copy link

melvin-bot bot commented Dec 25, 2023

@strepanier03, @chrispader, @parasharrajat, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 27, 2023

@strepanier03, @chrispader, @parasharrajat, @grgia Huh... This is 4 days overdue. Who can take care of this?

@strepanier03
Copy link
Contributor

@parasharrajat - Oops, sorry about that!

I have canceled the contract in Upwork and will post a payment summary directly after this.

@melvin-bot melvin-bot bot removed the Overdue label Dec 28, 2023
@strepanier03
Copy link
Contributor

strepanier03 commented Dec 28, 2023

Payment summary

  • Reporter - N/A
  • Contributor - N/A
  • C+ - @parasharrajat = $500 payment due via Manual Requests

@JmillsExpensify - A request should be coming in shortly from Rajat, thank you!

@parasharrajat
Copy link
Member

@strepanier03 Please close the issue as the request might take a long time from me. Thanks. I will track it myself.

@parasharrajat parasharrajat moved this from Merged to Done - Live ✅ in Theme Switching / Light Mode Dec 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 1, 2024
Copy link

melvin-bot bot commented Jan 1, 2024

@JmillsExpensify, @strepanier03, @chrispader, @parasharrajat, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

1 similar comment
Copy link

melvin-bot bot commented Jan 1, 2024

@JmillsExpensify, @strepanier03, @chrispader, @parasharrajat, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@grgia grgia closed this as completed Jan 2, 2024
@github-project-automation github-project-automation bot moved this from Done - Live ✅ to Merged in Theme Switching / Light Mode Jan 2, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@parasharrajat
Copy link
Member

Payment requested as per #32257 (comment)

@JmillsExpensify
Copy link

$500 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Development

No branches or pull requests

5 participants