Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Chat - When typing on emoji search the keyboard is dismissed after typing a character #32652

Closed
2 of 6 tasks
izarutskaya opened this issue Dec 7, 2023 · 19 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Dec 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.9-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

  1. Navigate to any chat
  2. Tap on the emoji icon
  3. Tap on the search field
  4. Try to tap more than 1 character

Expected Result:

The typed characters are added to the search and user can search on an emoji with more than one characters

Actual Result:

After typing on character the keyboard is dismissed. User needs to tap on search again and type each character this way one by one

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6304327_1701946927913.Production_az_recorder_20231207_041443.mp4
Bug6304327_1701946927898.az_recorder_20231207_040338.mp4

Bug6304327_1701946927913!expen-log2.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0155143f14cdcc7ef6
  • Upwork Job ID: 1732727287716786176
  • Last Price Increase: 2023-12-07
  • Automatic offers:
    • aimane-chnaif | Contributor | 28062291
@izarutskaya izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 7, 2023
@melvin-bot melvin-bot bot changed the title Chat - When typing on emoji search the keyboard is dismissed after typing a character [$500] Chat - When typing on emoji search the keyboard is dismissed after typing a character Dec 7, 2023
Copy link

melvin-bot bot commented Dec 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0155143f14cdcc7ef6

Copy link

melvin-bot bot commented Dec 7, 2023

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 7, 2023
Copy link

melvin-bot bot commented Dec 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Dec 7, 2023
Copy link

melvin-bot bot commented Dec 7, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 7, 2023

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@situchan
Copy link
Contributor

situchan commented Dec 7, 2023

Seems like regression from #31899

@yuwenmemon
Copy link
Contributor

Fix was CP'd to staging, removing the blocker label

@yuwenmemon yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label Dec 7, 2023
@dylanexpensify
Copy link
Contributor

Nice! @ArekChr what's the latest here?

@ArekChr
Copy link
Contributor

ArekChr commented Dec 11, 2023

Hi @dylanexpensify, this bug has been fixed in PR: #32654. I think we can close this issue.

@rlinoz
Copy link
Contributor

rlinoz commented Dec 15, 2023

Closing since this has been fixed and I think there is no due payment.

@rlinoz rlinoz closed this as completed Dec 15, 2023
@aimane-chnaif
Copy link
Contributor

@rlinoz I am eligible for reviewing #32654

@rlinoz
Copy link
Contributor

rlinoz commented Dec 15, 2023

Oh I am sorry, I will reopen it.

Should you be assigned to this issue then?

@rlinoz rlinoz reopened this Dec 15, 2023
@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Dec 15, 2023

Should you be assigned to this issue then?

yes please. And remove Reviewing label

@rlinoz rlinoz removed the Reviewing Has a PR in review label Dec 15, 2023
Copy link

melvin-bot bot commented Dec 15, 2023

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@rlinoz
Copy link
Contributor

rlinoz commented Dec 15, 2023

@dylanexpensify a PR has already fixed this issue and @aimane-chnaif did the review, but I am not sure how to proceed here.

@aimane-chnaif
Copy link
Contributor

PR was deployed to production on Nov 8 so today is payment date

@dylanexpensify
Copy link
Contributor

Aha! Amazing, sorry for delay, will work on this today!

@dylanexpensify
Copy link
Contributor

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants