[HOLD for payment 2024-01-31] [$500] Web - Compose box - The compose box displays duplicate characters upon pressing a single key

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.18-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

Action Performed:

1. Open a conversation
2. Click anywhere outside the compose box
3. Press on any character on the keyboard (Only once)
4. Observe the number of characters displayed inside of the compose box

Expected Result:

When a single key is pressed only a single character should be displayed inside the compose box

Actual Result:

When pressing only a single key duplicate characters are displayed inside the compose box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6327462_1703768050385.27.12.2023_22.13.56_REC.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e5ce38ee6504ce3e
• Upwork Job ID: 1740378947399057408
• Last Price Increase: 2024-01-04
• Automatic offers:
• situchan | Reviewer | 28090824
• bernhardoj | Contributor | 28090825

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e5ce38ee6504ce3e

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The text is doubled when pressing a key while the composer is not focused.

What is the root cause of that problem?

We have a key-down listener that will:

1. Focus on the composer
2. Add the pressed key to the composer

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js

Lines 455 to 472 in 88d837c

	const focusComposerOnKeyPress = useCallback(
	(e) => {
	const isComposerVisible = checkComposerVisibility();
	if (!isComposerVisible) {
	return;
	}
	if (!ReportUtils.shouldAutoFocusOnKeyPress(e)) {
	return;
	}
	// if we're typing on another input/text area, do not focus
	if (['INPUT', 'TEXTAREA'].includes(e.target.nodeName)) {
	return;
	}
	focus();
	replaceSelectionWithText(e.key, false);

The reason it added a duplicate character is, that the native input first receives the pressed key (because we focus on it, proof video below) and we manually add the pressed key to the composer.

Screen.Recording.2023-12-28.at.22.52.05.mov

What changes do you think we should make in order to solve the problem?

Remove replaceSelectionWithText after focusing on the composer.

What alternative solutions did you explore? (Optional)

An alternate solution is to call preventDefault so the input won't receive any key and we will still manually add it with replaceSelectionWithText.

[melvin-bot]

@strepanier03, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@strepanier03, @situchan Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

I've been OoO, taking a look now.

[strepanier03]

Weird, but reproducible.

Chrome/Web

2024-01-03_16-17-15.mp4

[strepanier03]

Checking internally, here, to see if it's a good fit for Wave 5.

[aswin-s]

This issue is already fixed in this PR. Sadly the review is blocked for quite some time now.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[situchan]

Seems like #30955 has been stale for long time.
I am not sure we should hold this for that. This issue is never related to emoji.

[situchan]

The current behavior is weird and I think we should fix this as urgency

Screen.Recording.2024-01-08.at.10.32.29.PM.mov

[situchan]

@bernhardoj please do regression test on these issues:

• [HOLD for payment 2023-12-15] [$500] Chat - The Emoji search field is focused when clicking on Modifier keys #30867
• [HOLD for payment 2023-12-18] [HOLD for payment 2023-12-15] [$500] Chat - Focus is lost after deleting letter in a word in the emoji search bar #32644
• [$500] Chat - When typing on emoji search the keyboard is dismissed after typing a character #32652

[strepanier03]

Raised again to try to tie to another project for priority purposes. Will update as soon as possible.

[bernhardoj]

@situchan I tested all 3 issues reproduction steps and the solution here won't cause that issue again.

[situchan]

Remove replaceSelectionWithText after focusing on the composer.

@bernhardoj can you find the exact PR which added that line?

[bernhardoj]

It was added since the first time of the feature #21583.

Probably we need it before because the focus is delayed inside InteractionManager.

I think it has the same root cause as #31210 https://github.com/Expensify/App/pull/24482/files#r1429943408.

[melvin-bot]

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @situchan

[quinthar]

What's the update on this? Who is doing what, and when will it be done? It looks like we have a 2-week old undeployed fix?

[bernhardoj]

Currently waiting for review.
cc: @situchan

[situchan]

Provided feedback. Was testing and finding any possible regressions

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.30-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix character is input twice to composer when pressing any key while composer is blurred #34169

If no regressions arise, payment will be issued on 2024-01-31. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @situchan requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

Pay date is tomorrow so I'll handle this then.

@situchan - Feel free to @ mention me when you post the checklist.

Be back to this tomorrow.

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: 16098 — selecting chat message and pressing any key focus the message instead of switch the focus to the composer #21583
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/21583/files#r1472023437
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

We can skip regression test as this was discovered by QA team

[strepanier03]

Awesome, thank you @situchan! Handling payment now for everyone.

[strepanier03]

Both @bernhardoj and @situchan have been paid. Closing this out as complete. Thanks everyone!