Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold for payment 2024-02-12] [$1500] Implement a new navigator for the Ideal Nav overhaul #32689

Closed
hayata-suenaga opened this issue Dec 7, 2023 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering NewFeature Something to build that is a new item.

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Dec 7, 2023

Implement the new navigation system for the Ideal Nav project.

The detailed requirements for the new navigation structure are stipulated in this design doc.

@adamgrzybowski from Software Mansion will do the implementation work. We will keep track of the progress using this issue.

Potential new requirement that hasn't made it to the design doc yet.

Child issues

@hayata-suenaga hayata-suenaga added Daily KSv2 NewFeature Something to build that is a new item. labels Dec 7, 2023
Copy link

melvin-bot bot commented Dec 7, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Dec 7, 2023
@adamgrzybowski
Copy link
Contributor

👋

@adamgrzybowski
Copy link
Contributor

Hey @hayata-suenaga this issue seems quite general. We divided our work on the structure of navigation into three separate task

Left hand navigator - @WojtekBoman
Full screen settings page - @kosmydel
Bottom tab navigator - @adamgrzybowski

Maybe we could create these issues to track progress more accurately?

@hayata-suenaga
Copy link
Contributor Author

hayata-suenaga commented Dec 12, 2023

Created an issue for each piece of the new navigation feature as listed above by Adam. These issues should appear below this comment as links.

Is @kosmydel working on the full screen settings page for the account for workspace or both? Seems like @kosmydel is working on the full screen page for the account settings page. Are you also planning to work on the workspace settings page? For the workspace settings page, you can use this issue.

@hayata-suenaga
Copy link
Contributor Author

I am assigning myself to this tracking issue for three navigation-related issues.

@adamgrzybowski if you need a feature branch to which to merge navigation-related branches, please use https://github.com/Expensify/App/tree/ideal-nav that Vit created.

@melvin-bot melvin-bot bot added the Overdue label Dec 21, 2023
@peterdbarkerUK peterdbarkerUK removed their assignment Dec 27, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 4, 2024
@s77rt
Copy link
Contributor

s77rt commented Jan 8, 2024

@hayata-suenaga Can you assign me here?

@hayata-suenaga
Copy link
Contributor Author

the work is on progress

@melvin-bot melvin-bot bot removed the Overdue label Jan 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@hayata-suenaga
Copy link
Contributor Author

the feature branch is very close to be merged

@melvin-bot melvin-bot bot removed the Overdue label Jan 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 7, 2024
@s77rt
Copy link
Contributor

s77rt commented Feb 7, 2024

@hayata-suenaga Can you please assign a BZ member for payment processing?

@melvin-bot melvin-bot bot removed the Overdue label Feb 7, 2024
@hayata-suenaga hayata-suenaga added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 7, 2024
@hayata-suenaga
Copy link
Contributor Author

An expert agency engineer authored the PR, so the only payment we need is for C+.

@lschurr The PR @s77rt (C+) reviewed was super huge. They deserve at least twice the usual payment. I'd say 3x.

@lschurr
Copy link
Contributor

lschurr commented Feb 9, 2024

Sounds good @hayata-suenaga! Can you link me to the specific PR so I can see when it's merged for payment?

@hayata-suenaga
Copy link
Contributor Author

ah sorry about that

here is the PR

@lschurr
Copy link
Contributor

lschurr commented Feb 9, 2024

Thanks! Looks like it was deployed to prod on Feb 5th, so we'll pay on Feb 12th.

@lschurr lschurr changed the title Implement a new navigator for the Ideal Nav overhaul [Hold for payment 2024-06-12] [$1500] Implement a new navigator for the Ideal Nav overhaul Feb 9, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@lschurr lschurr added the Awaiting Payment Auto-added when associated PR is deployed to production label Feb 9, 2024
@hayata-suenaga
Copy link
Contributor Author

by the way, there are multiple regressions that stemmed from the PR, but all these regressions were expected. They should not reduce the payout to @s77rt

@s77rt
Copy link
Contributor

s77rt commented Feb 9, 2024

Thank you! But I'm good with the standard $500. Not counting those regression is enough

@lschurr lschurr changed the title [Hold for payment 2024-06-12] [$1500] Implement a new navigator for the Ideal Nav overhaul [Hold for payment 2024-02-12] [$1500] Implement a new navigator for the Ideal Nav overhaul Feb 9, 2024
@lschurr
Copy link
Contributor

lschurr commented Feb 9, 2024

We discussed internally and decided $1500 is a fair price for the amount of work you put into this one @s77rt :)

@lschurr
Copy link
Contributor

lschurr commented Feb 9, 2024

Sent offer in Upwork: https://www.upwork.com/nx/wm/offer/100843971

@s77rt
Copy link
Contributor

s77rt commented Feb 9, 2024

Accepted! Thank you!

@melvin-bot melvin-bot bot added the Overdue label Feb 12, 2024
@lschurr
Copy link
Contributor

lschurr commented Feb 12, 2024

Paid in Upwork :)

@lschurr lschurr closed this as completed Feb 12, 2024
@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@hayata-suenaga
Copy link
Contributor Author

thank you so much and great work @s77rt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering NewFeature Something to build that is a new item.
Projects
No open projects
Development

No branches or pull requests

5 participants