[HOLD for payment 2024-05-08] HIGH: [Polish] [$500] Broken message text in LHN when Inviting someone to room.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.12.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @marcaaron
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1702330874424759

Action Performed:

1. Create a new workspace
2. Create a workspace room
3. Invite a workspace member to the room
4. Invite a non-workspace member to the room
5. View the chat as the non-workspace member

Expected Result:

The last message text correctly shows "invited 2 users"

Actual Result:

the message text says "invited and"

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d4986375431dd52a
• Upwork Job ID: 1734953294535315456
• Last Price Increase: 2024-02-06
• Automatic offers:
• DylanDylann | Contributor | 0
• dukenv0307 | Contributor | 0

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d4986375431dd52a

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[artus9033]

Seems like this issue is non-reproducible anymore on the current main branch:

[melvin-bot]

📣 @artus9033! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[sakluger]

Thanks @artus9033.

@m-natarajan are you still able to reproduce this issue?

[sakluger]

I also can't reproduce but may be following the steps incorrectly. I asked in the original Slack thread for help checking on reproduction.

[sakluger]

Closing as non-reproduceable.

[kbecciv]

@sakluger QA team found the reproducible steps for this issue:

1. Create a workspace room.
2. Invite users.
3. Send a message to another chat (if on web).
4. Log out and log in.
5. Refresh the page.
   Can you try again, please? Thank you!
   https://github.com/Expensify/App/assets/93399543/35f4287a-7e68-4631-9e8b-f9fe5948d36d

[sakluger]

@artus9033 are you able to reproduce with the above steps on iOS? If so, would you like to submit a proposal to fix?

[aimane-chnaif]

I reproduced. I think this should be fixed in backend.

Here's the root cause with example:

report data:

reportActions associated with this report doesn't exist before opening report so it just shows lastMessageText.

After opening report, reportActions comes from openReport api. So last message is composed from last report action (actionName, targetAccountIDs.length):

🎀 👀 🎀

[dukenv0307]

@jasperhuangg @DylanDylann Sorry for the delay on this PR, now we have a open PR here.
But as I mentioned in my proposal we need back-end change to return a field lastActionName to indicate the type of the last action, that will make things much cleaner and this field can be used for various purposes.
@jasperhuangg please ping me when back-end is updated.

[quinthar]

@jasperhuangg will be back tomorow!

[jasperhuangg]

Sounds good, I'll handle it!

[jasperhuangg]

Back-end PR up for review

[jasperhuangg]

Still waiting for a review before moving forward with this

[jasperhuangg]

The Auth PR is on production and the front end is ready to be worked on for this!

[jasperhuangg]

@dukenv0307 let me know if you can work on this, or if you need anything else.

[dukenv0307]

@jasperhuangg thank you, i'm working on this now

[dukenv0307]

@jasperhuangg I can see lastActionType in report when I call API OpenReport but when user logout and login again, it only calls openApp api but not openReport api so lastActionType is not returned, please return lastActionType in openApp api

[jasperhuangg]

@dukenv0307 ah my mistake, I'll have some changes up for you shortly. There were some changes that we had that should have been applied to OpenApp but don't seem to be there.

[jasperhuangg]

@dukenv0307 I submitted a PR to update the response, I'll let you know when it's on staging so you can start using the change.

You'll need to sign out/sign back into the account you're using in order for the change to take affect due to how our reliable updates work.

[jasperhuangg]

@dukenv0307 PR on staging

[dukenv0307]

@DylanDylann this PR is ready for preview.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix broken message text in LHN when Inviting someone to room #39313

If no regressions arise, payment will be issued on 2024-05-08. 🎊

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment automatic offer (Contributor)
• @DylanDylann requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307 / @DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@dukenv0307 / @DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dukenv0307 / @DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dukenv0307 / @DylanDylann] Determine if we should create a regression test for this bug.
• [@dukenv0307 / @DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

I paid out both contracts. @DylanDylann please complete the BZ checklist.

[DylanDylann]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Create a workspace room.
2. Invite users.
3. Send a message to another chat (if on web).
4. Log out and log in.
5. Refresh the page.
6. Verify that: The last message text correctly shows "invited x users"

Do we agree 👍 or 👎

[sakluger]

Thanks! I made a few small tweaks (I suggested inviting exactly 2 users) to make the instructions more specific.