Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOS - App crashes after entering phone number 2nd or 3rd time in invite member flow #33311

Closed
1 of 6 tasks
lanitochka17 opened this issue Dec 19, 2023 · 17 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.14-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when excuting PR #31010

Action Performed:

  1. Open the app and log in
  2. Create a workspace if there is no one
  3. Tap FAB > Start Chat > Room
  4. Create a room
  5. Open the created room and
  6. Tap the header > Members > Invite
  7. Enter the phone number and tap "Invite"
  8. Enter the same phone number

Expected Result:

The message " is already a member of " should appear

Actual Result:

The app crashes after waiting for some time. Sometimes it crashes only after 3rd time entering the same phone number

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6320121_1703012128728.IMG_4160.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b236fe00f56d57e3
  • Upwork Job ID: 1737240068424257536
  • Last Price Increase: 2023-12-19
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 19, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 19, 2023

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@situchan
Copy link
Contributor

@lanitochka17 do you have crash log?

@lanitochka17
Copy link
Author

@situchan Hello
yes please
Bug278!log.txt

@yuwenmemon
Copy link
Contributor

Not able to reproduce locally on staging on my iPhone.

@situchan
Copy link
Contributor

The log file is super long so not able to point out exact crash log 😞

@yuwenmemon
Copy link
Contributor

Can't reproduce on a simulated iOS device either. Unfortunately if it's not a reliably reproducible crash I'm not sure how we're going to fix it so I'm going to at least remove the deploy blocker label and put this issue for triage.

@yuwenmemon yuwenmemon added External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 19, 2023
@melvin-bot melvin-bot bot changed the title Room - App crashes after entering phone number 2nd or 3rd time in invite member flow [$500] Room - App crashes after entering phone number 2nd or 3rd time in invite member flow Dec 19, 2023
@yuwenmemon yuwenmemon removed their assignment Dec 19, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b236fe00f56d57e3

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 19, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 19, 2023
@yuwenmemon yuwenmemon added Bug Something is broken. Auto assigns a BugZero manager. and removed External Added to denote the issue can be worked on by a contributor labels Dec 19, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Dec 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Dec 22, 2023
Copy link

melvin-bot bot commented Dec 25, 2023

@mananjadhav, @muttmuure Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Dec 27, 2023

@mananjadhav, @muttmuure Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Dec 29, 2023

@mananjadhav, @muttmuure 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@kbecciv kbecciv changed the title [$500] Room - App crashes after entering phone number 2nd or 3rd time in invite member flow [$500] IOS - App crashes after entering phone number 2nd or 3rd time in invite member flow Dec 29, 2023
Copy link

melvin-bot bot commented Jan 2, 2024

@mananjadhav @muttmuure this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Jan 2, 2024

@mananjadhav, @muttmuure 12 days overdue now... This issue's end is nigh!

@muttmuure
Copy link
Contributor

The change to handling phone numbers was reverted

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants