Fix/30190: Duplicate phone number can be invited to room #31010

DylanDylann · 2023-11-07T16:24:17Z

Details

Room - Can invite valid phone account multiple times into the room

Fixed Issues

$ #30190
PROPOSAL: #30190 (comment)

Tests

Create a WS
Create a room with workspace
Click room header => Members => Invite
Input an phone (eg: +3233232432) then select and click invite
Input the phone number in step 4 in search box again
Observe that there is no option to select and the message ${login} is already a member of ${name} is displayed

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a WS
Create a room with workspace
Click room header => Members => Invite
Input an phone (eg: +3233232432) then select and click invite
Input the phone number in step 4 in search box again
Observe that there is no option to select and the message ${login} is already a member of ${name} is displayed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screencast.from.08-11-2023.11.38.17.webm

Android: mWeb Chrome

Screencast.from.08-11-2023.10.35.17.webm

iOS: Native

Screencast.from.08-11-2023.09.38.35.webm

iOS: mWeb Safari

Screencast.from.08-11-2023.10.15.46.webm

MacOS: Chrome / Safari

Screencast.from.07-11-2023.23.56.47.webm

MacOS: Desktop

Screencast.from.08-11-2023.09.12.48.webm

DylanDylann · 2023-11-07T16:40:23Z

src/pages/RoomInvitePage.js

+    const excludedUsers = useMemo(
+        () => _.map([...lodashGet(props.report, 'participants', []), ...CONST.EXPENSIFY_EMAILS], (participant) => OptionsListUtils.addSMSDomainIfPhoneNumber(participant)),
+        [props.report],
+    );


There is a minor change in my original proposal

In the original, I will "add the @expensify.sms with the phone number when calling API "InviteToRoom".

But when implementing the PR, I found that if we do like above, the unexpected personalProfile account will be returned by BE. So I will keep the current logic when calling API "InviteToRoom", and just add the "@expensify.sms" to the excludeUser

melvin-bot · 2023-11-08T03:39:27Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2023-11-09T18:03:17Z

@rushatgabhane Please help review this PR

src/libs/OptionsListUtils.js

…t-multiple-times

DylanDylann · 2023-11-16T02:40:11Z

@rushatgabhane Please help review this PR again in case you miss it

rushatgabhane

@DylanDylann
The bug is still reproducible.

Invite a number from same country
Invite them again

Screen.Recording.2023-11-17.at.12.29.23.mov

DylanDylann · 2023-11-17T07:18:46Z

@rushatgabhane This issue appears when we invite user to room (Based on issue `s title and reproduce steps), not a workspace. So I think we need to confirm that, in this PR, whether we should fix case invite user to workspace or not

rushatgabhane · 2023-11-17T07:21:55Z

yea I think we should fix it everywhere

DylanDylann · 2023-11-18T03:56:28Z

yea I think we should fix it everywhere

@rushatgabhane Updated. Please help check

DylanDylann · 2023-11-23T13:07:53Z

@rushatgabhane Please help review this once you have a chance

DylanDylann · 2023-12-01T03:38:48Z

@rushatgabhane In case you miss it

DylanDylann · 2023-12-05T03:53:23Z

@rushatgabhane Please help review this PR again

DylanDylann · 2023-12-11T08:24:37Z

@rushatgabhane In case you miss it

rushatgabhane · 2023-12-15T12:45:29Z

sorry this one slipped

rushatgabhane · 2023-12-15T12:45:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-12-15.at.18.28.43.mov

MacOS: Desktop

Beamanator · 2023-12-15T13:37:40Z

Sorry but seems the last commit here was about a month ago, right? IF so, @DylanDylann can you please merge main & retest?

rushatgabhane · 2023-12-15T13:39:55Z

@Beamanator im testing by merging with latest main
do we still need to @DylanDylann to retest?

Beamanator · 2023-12-15T13:41:05Z

@rushatgabhane aah you're testing locally with latest main? That shoulddddd be fine

rushatgabhane · 2023-12-15T13:43:44Z

yepp we can merge if this looks good to you

Beamanator

LGTM!

OSBotify · 2023-12-15T13:49:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-19T02:42:18Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-19T03:45:39Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-21T05:13:14Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.14-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

…-invite-valid-phone-account-multiple-times" This reverts commit f5696ff, reversing changes made to e23eebe.

OSBotify · 2023-12-26T00:37:27Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

mountiny · 2023-12-26T11:06:41Z

@DylanDylann @Beamanator This was reverted as the additional phone check on the Search page has been causing the app to hang/ crash for Account Manager users who have thousands of people with sms number in their contacts

With the next attempt, lets make an Adhoc build and ask internal users like @conorpendergrast or @muttmuure to test the build search page performance

rushatgabhane · 2023-12-26T11:14:57Z

ooo i wonder if we should add performance test for Search page.
In the next attempt, we could also benchmark before and after to prove that there is no performance impact

mountiny · 2023-12-26T11:24:22Z

We are working on that with Callstack and reassure tool in performance room

OSBotify · 2023-12-27T16:10:30Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.17-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

DylanDylann · 2024-01-04T08:51:32Z

@rushatgabhane @mountiny I just created the new PR here

DylanDylann added 2 commits November 7, 2023 23:17

fix duplicate phone number can be invited to room

874c81a

fix remove console log

443b270

DylanDylann commented Nov 7, 2023

View reviewed changes

DylanDylann marked this pull request as ready for review November 8, 2023 03:39

DylanDylann requested a review from a team as a code owner November 8, 2023 03:39

melvin-bot bot removed the request for review from a team November 8, 2023 03:39

melvin-bot bot requested a review from rushatgabhane November 8, 2023 03:39

DylanDylann mentioned this pull request Nov 8, 2023

[$500] Room - Can invite valid phone account multiple times into the room #30190

Closed

6 tasks

fix remove redandunt changes

6f4569a

rushatgabhane reviewed Nov 13, 2023

View reviewed changes

src/libs/OptionsListUtils.js Outdated Show resolved Hide resolved

DylanDylann and others added 2 commits November 13, 2023 14:34

Merge branch 'main' into fix/30190-room-can-invite-valid-phone-accoun…

2a31c75

…t-multiple-times

fix comment

95283d6

rushatgabhane suggested changes Nov 17, 2023

View reviewed changes

DylanDylann added 2 commits November 18, 2023 10:34

fix merge main

d5448cd

fix workspace invite page

974f7dc

rushatgabhane approved these changes Dec 15, 2023

View reviewed changes

melvin-bot bot requested a review from Beamanator December 15, 2023 13:32

Beamanator approved these changes Dec 15, 2023

View reviewed changes

Beamanator merged commit f5696ff into Expensify:main Dec 15, 2023
16 checks passed

github-actions bot mentioned this pull request Dec 19, 2023

Deploy Checklist: New Expensify 2023-12-19 #33264

Closed

98 tasks

kbecciv mentioned this pull request Dec 19, 2023

[HOLD for payment 2024-02-01] [$500] Room - Error is "No results found" when re-inviting contact number without country code #33301

Closed

6 tasks

lanitochka17 mentioned this pull request Dec 19, 2023

[$500] IOS - App crashes after entering phone number 2nd or 3rd time in invite member flow #33311

Closed

6 tasks

mountiny added a commit that referenced this pull request Dec 22, 2023

Revert "Merge pull request #31010 from DylanDylann/fix/30190-room-can…

fd282de

…-invite-valid-phone-account-multiple-times" This reverts commit f5696ff, reversing changes made to e23eebe.

mountiny mentioned this pull request Dec 22, 2023

[CP Staging] Revert "fix: treat certain US numbers as invalid" #33496

Merged

45 tasks

github-actions bot mentioned this pull request Dec 26, 2023

Deploy Checklist: New Expensify 2023-12-26 #33576

Closed

42 tasks

mountiny mentioned this pull request Dec 26, 2023

fix: treat certain US numbers as invalid #31726

Merged

47 tasks

DylanDylann mentioned this pull request Jan 4, 2024

Fix: Duplicate phone number can be invited #33928

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/30190: Duplicate phone number can be invited to room #31010

Fix/30190: Duplicate phone number can be invited to room #31010

DylanDylann commented Nov 7, 2023 •

edited by github-actions bot

Loading

DylanDylann Nov 7, 2023

melvin-bot bot commented Nov 8, 2023

DylanDylann commented Nov 9, 2023

DylanDylann commented Nov 16, 2023

rushatgabhane left a comment •

edited

Loading

DylanDylann commented Nov 17, 2023 •

edited

Loading

rushatgabhane commented Nov 17, 2023

DylanDylann commented Nov 18, 2023

DylanDylann commented Nov 23, 2023

DylanDylann commented Dec 1, 2023

DylanDylann commented Dec 5, 2023

DylanDylann commented Dec 11, 2023

rushatgabhane commented Dec 15, 2023

rushatgabhane commented Dec 15, 2023 •

edited

Loading

Beamanator commented Dec 15, 2023

rushatgabhane commented Dec 15, 2023

Beamanator commented Dec 15, 2023

rushatgabhane commented Dec 15, 2023

Beamanator left a comment

OSBotify commented Dec 15, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 21, 2023

OSBotify commented Dec 26, 2023

mountiny commented Dec 26, 2023

rushatgabhane commented Dec 26, 2023 •

edited

Loading

mountiny commented Dec 26, 2023

OSBotify commented Dec 27, 2023

DylanDylann commented Jan 4, 2024

Fix/30190: Duplicate phone number can be invited to room #31010

Fix/30190: Duplicate phone number can be invited to room #31010

Conversation

DylanDylann commented Nov 7, 2023 • edited by github-actions bot Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

DylanDylann Nov 7, 2023

Choose a reason for hiding this comment

melvin-bot bot commented Nov 8, 2023

DylanDylann commented Nov 9, 2023

DylanDylann commented Nov 16, 2023

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

DylanDylann commented Nov 17, 2023 • edited Loading

rushatgabhane commented Nov 17, 2023

DylanDylann commented Nov 18, 2023

DylanDylann commented Nov 23, 2023

DylanDylann commented Dec 1, 2023

DylanDylann commented Dec 5, 2023

DylanDylann commented Dec 11, 2023

rushatgabhane commented Dec 15, 2023

rushatgabhane commented Dec 15, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Beamanator commented Dec 15, 2023

rushatgabhane commented Dec 15, 2023

Beamanator commented Dec 15, 2023

rushatgabhane commented Dec 15, 2023

Beamanator left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 15, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 21, 2023

OSBotify commented Dec 26, 2023

mountiny commented Dec 26, 2023

rushatgabhane commented Dec 26, 2023 • edited Loading

mountiny commented Dec 26, 2023

OSBotify commented Dec 27, 2023

DylanDylann commented Jan 4, 2024

DylanDylann commented Nov 7, 2023 •

edited by github-actions bot

Loading

rushatgabhane left a comment •

edited

Loading

DylanDylann commented Nov 17, 2023 •

edited

Loading

rushatgabhane commented Dec 15, 2023 •

edited

Loading

rushatgabhane commented Dec 26, 2023 •

edited

Loading