[HOLD for payment 2024-01-24] [$500] Profile - No profile image displayed for specific users in header&profile page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.15-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap search
3. Scroll ,find and select user with green avatar as shown in below image
4. Note in header, profile image is not displayed
5. Tap on header
6. In profile page also, note profile image is not displayed

Expected Result:

Profile image must be displayed for specific users in both header and profile page. If no custom image set, default profile image must be displayed

Actual Result:

No profile image displayed for specific user in both header and profile page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6323045_1703182419893.img.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01df3f6538112432f6
• Upwork Job ID: 1737941070550650880
• Last Price Increase: 2023-12-21
• Automatic offers:
• gijoe0295 | Contributor | 28088902

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01df3f6538112432f6

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No profile image displayed for specific users in header&profile page

What is the root cause of that problem?

The issue happens with profiles using OldDot default avatar.

Avatar of the profile in OP points to a default avatar from OldDot. Default avatar URLs are prefixed with default-avatar_ or avatar_.

The regex to generate hash does not include avatar_ prefix, thus making the hash null:

App/src/libs/UserUtils.ts

Line 108 in 6fc83d5

const match = avatarURL.match(/(default-avatar_)(\d+)(?=\.)/);

What changes do you think we should make in order to solve the problem?

Modify the regex to include the avatar_ prefix as well. We should create a CONST for these prefixes.

/(default-avatar_|avatar_)(\d+)(?=\.)/

What alternative solutions did you explore? (Optional)

In getIconsForParticipants, we can check whether personalDetails?.[accountID]?.avatar is a string then called getAvatarUrl as it indicates an URL, otherwise call getAvatar.

[ahsanfarooq3423]

The users are not listing for me. Am I missing something?

[melvin-bot]

📣 @ahsanfarooq3423! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

@trjExpensify, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Santhosh-Sellavel]

@gijoe0295's proposal looks good to me.
Need some clarification on other possible prefixes waiting for CME's input on that!

C+ Reviewed
🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Santhosh-Sellavel]

@hayata-suenaga let me know your thoughts on #33452 (comment)

[melvin-bot]

@trjExpensify, @Santhosh-Sellavel, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@trjExpensify, @Santhosh-Sellavel, @hayata-suenaga 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[trjExpensify]

@hayata-suenaga this one is waiting on your secondary review please!

[melvin-bot]

@trjExpensify @Santhosh-Sellavel @hayata-suenaga this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[trjExpensify]

Same Melv, awaiting @hayata-suenaga's secondary review!

[melvin-bot]

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[gijoe0295]

@hayata-suenaga Needs your clarification on this: Default avatar in URL are prefixed with default-avatar_ or avatar_. Is there any other default prefix like that?

[hayata-suenaga]

I'm not super familiar with the avatar URL prefixes. Whenever you have a question about a specific part of the App, the best place to ask is open-soource-channel of Slack 🙇

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show default avatar from OldDot #34122

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel requires payment through NewDot Manual Requests
• @gijoe0295 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

👋 checklist time, @Santhosh-Sellavel!

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: fix: Avatar changes when from offline to online #32090
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/32090/files#r1466714675
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: We can skip this, as this should have been while proposal/PR review.
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. We can skip this, as user avatar are covered basically in all flows we don't seperate regression tests here
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

Yo! When you answer N/A can you provide reasoning?

[trjExpensify]

In the meantime, confirming payments are as follows:

• $500 to @gijoe0295 for the fix
• $500 to @Santhosh-Sellavel for the review

[Santhosh-Sellavel]

Yo! When you answer N/A can you provide reasoning?

We are skipping Regression so N/A for the 5th item. Added more reasoning why we can skip it.

[trjExpensify]

Nice one, thanks for expanding on the reasoning. Makes sense!

Feel free to request. @gijoe0295 you've been paid!

[Santhosh-Sellavel]

Requested on ND

[JmillsExpensify]

$500 approved for @Santhosh-Sellavel based on summary above.