[$500] [MEDIUM] LHN - Green dot(IOU) disappears from WS conversation in LHN when going offline-online

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

⚠️ To reproduce you need an account that has the beta: excludedFromReliableUpdates.

1. Open New Expensify app
2. Log in with any account
3. Create new workspace
4. Request money on that workspace
5. Go to offline mode and after a few seconds return to online mode

Expected Result:

The IOU green dot must be present in the LHN in any mode of operation until the IOU request is paid or an IOU error occurs.

Actual Result:

The green dot IOU disappears from the LHN if the user goes offline and comes back online.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6324826_1703328627225.Recording__981.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019c2e500b47b7def2
• Upwork Job ID: 1738525487918645248
• Last Price Increase: 2024-01-31

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019c2e500b47b7def2

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[paultsimura]

First of all, this is not a deploy blocker – it's happening in prod as well:

We're potentially facing the out-of-order Onyx updates again:
When coming back online, 2 conflicting responses set report.hasOutstandingChildRequest:

First comes the ReconnectApp that sets it to false via the mergeCollection action:

Second comes the ReconnectToReport, which should set the value to true, but this value is ignored. I suppose it gets overwritten by the mergeCollection from above similar to what was happening in #28737

This particular issue can be fixed by making sure the ReconnectApp returns report.hasOutstandingChildRequest: true (which is correct), but the Onyx issue should be addressed as well.

cc: @Julesssss for the out-of-order updates

[melvin-bot]

📣 @aim-salam! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[aim-salam]

Contributor details
Your Expensify account email: aimsalam.com@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0165dd5f4e0e952fdd

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

Current assignee @alitoshmatov is eligible for the Internal assigner, not assigning anyone new.

[BartoszGrajdek]

Hi! I'm Bartosz from Software Mansion, I was working on this issue yesterday (I wanted to run a few more tests today) and I think that it may have been fixed with navigation rework. Following these steps here's the result:

lhn-test.mp4

[aldo-expensify]

oh, nice! thanks for taking a look @BartoszGrajdek

[aldo-expensify]

👋 @BartoszGrajdek where you able to run more tests?

[BartoszGrajdek]

Oh, I took it as if you didn't need any more help, so I just shared what I have found out. I tested out several scenarios with going online/offline and it really looks like it got fixed. I can investigate what might have fixed this problem if you want to - just let me know 😄

[aldo-expensify]

I can investigate what might have fixed this problem if you want to - just let me know 😄

No need @BartoszGrajdek , thank you again. If we can't reproduce, we can just close this.

[lanitochka17]

Issue is still reproducible on the latest build 1.4.40-1

Recording.1331.mp4

[BartoszGrajdek]

Well, that's strange. I tested it by trying both steps found here and here. I also tried it on multiple browsers just to be sure and I still couldn't reproduce the problem.

Maybe I'm missing something, or this is some edge case and we still haven't figured out all the necessary steps. I'm attaching a video of how it behaves for me (build 1.4.40-4) @lanitochka17 let me know if there's anything I have done incorrectly there.

[aldo-expensify]

For some reason I'm not being able to reproduce in main in my dev environment but I was able to reproduce in https://staging.new.expensify.com/

Screen.Recording.2024-02-13.at.11.14.10.AM.mov

[aldo-expensify]

From looking at ReconnectApp and OpenReport response, I agree with @paultsimura 's findings here and it does look like ReconnectApp calculates hasOutstandingChildRequest incorrectly.

[aldo-expensify]

Reproduced in dev, the key is that the account has to have the beta excludedFromReliableUpdates. Accounts under expensifail.com , applause.expensifail.com and some big domains have this, so I guess that explain why @BartoszGrajdek can't reproduce.

[aldo-expensify]

I have a fix here https://github.com/Expensify/Auth/pull/9929, I just need to add the tests and I'll make it ready for review

[Christinadobrzyn]

Yay! Exciting @aldo-expensify!

[aldo-expensify]

PR was deployed

[aldo-expensify]

Tested and now it is working:

Screen.Recording.2024-02-14.at.12.42.17.PM.mov

In the video we can see that the policyExpenseChat (reportID: 2130476157825373) comes with hasOutstandingChildRequest: true in ReconnectApp

[Christinadobrzyn]

hey @aldo-expensify or @alitoshmatov do we need to pay out anyone for this?

[aldo-expensify]

@Christinadobrzyn not as far as I know, the backend PR wasn't reviewed by C+