[HOLD for payment 2024-01-09][$250] Mentions - @ Here icon is black

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.17-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to any chat.
2. Type @ here.

Expected Result:

Here icon is green.

Actual Result:

Here icon is black.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014f2330f066b567e3
• Upwork Job ID: 1739644027587080192
• Last Price Increase: 2023-12-26
• Automatic offers:
• paultsimura | Contributor | 28070446

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014f2330f066b567e3

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In mention list for here the icon is black

What is the root cause of that problem?

In this PR we have removed the fill property for the avatar.
https://github.com/Expensify/App/pull/30905/files#diff-3e66159ec7e545cdb519881ff0194d3e2151d3d3c9a963bf2b82e46b3119a92cL75

What changes do you think we should make in order to solve the problem?

We can add the fill property with fill={theme.success} again here to make it a green icon.

App/src/components/MentionSuggestions.tsx

Lines 68 to 74 in de5a943

	<Avatar
	source={item.icons[0].source}
	size={isIcon ? CONST.AVATAR_SIZE.MENTION_ICON : CONST.AVATAR_SIZE.SMALLER}
	name={item.icons[0].name}
	type={item.icons[0].type}
	fallbackIcon={item.icons[0].fallbackIcon}
	/>

[paultsimura]

This was missed and should be fixed as a follow-up of the #29067

[melvin-bot]

Upwork job price has been updated to $250

[mountiny]

Decreasing the price as this should be very simple fix from the regression PR.

@Pujan92 can you raise the PR quickly?

[paultsimura]

If @Pujan92 is unavailable, I can make the quick PR.
Didn't bother posting a full-scale proposal because I thought it would be handled by the original PR author.

[mountiny]

Yeah they are ooo though so I have decreased the reward.

I think that given this is a deploy blocker and you are available, I am going to assign you. This is not common so sorry to @Pujan92 that this was not handled earlier when they were on but we need to treat this with urgency

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: Make the "@here" mention icon green #33634

If no regressions arise, payment will be issued on 2024-01-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@paultsimura] Determine if we should create a regression test for this bug.
• [@paultsimura] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.20-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Fix remove the fill for non-icon mentions #33668

If no regressions arise, payment will be issued on 2024-01-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@paultsimura] Determine if we should create a regression test for this bug.
• [@paultsimura] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @michaelhaxhiu you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[mountiny]

This was a deploy blocker caused by a big change in how we handle images, using expo-image package. I think that has been stated already and there was bunch of other small issues so no need to dig more into that, the checklist can be omitted in this case

[Pujan92]

@mountiny Am I eligible for partial compensation here for providing the proposal which is used?

[mountiny]

@Pujan92 the solution based on your proposal did cause a regression so I would say no in this case

[Pujan92]

Agree, my bad. Sorry for the ask.

[mountiny]

no problem, one has to try

[mountiny]

@bfitzexpensify this should be $250 to @paultsimura please

[michaelhaxhiu]

I can step in for Ben!

[michaelhaxhiu]

paid.

[michaelhaxhiu]

Good to close?

[mountiny]

I think so thanks!