[HOLD for payment 2024-01-09] [$250] Chat - When mentioning users, the avatar icon is blank

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.18-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33479

Action Performed:

1. Access the New Expensify App
2. Sign into a valid account (I used a HT account)
3. Go to any chat and use the mention feature "@"and search for a user like "Expensify Concierge" for example

Expected Result:

User expects all avatars to show when using the mention feature

Actual Result:

Multiple users avatars are missing, showing as blank green icon (Repro on both light and dark mode)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6326945_1703701681524.Mention_avatars_are_not_showing_for_several_users.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0140012cc347f832e3
• Upwork Job ID: 1740090789811859456
• Last Price Increase: 2023-12-28
• Automatic offers:
• shubham1206agra | Reviewer | 28071843
• paultsimura | Contributor | 28071844

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0140012cc347f832e3

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[Pujan92]

@paultsimura Seems it is after PR, We only need to consider here for filling the success color.

fill={isIcon ? theme.success : undefined}

https://github.com/Expensify/App/pull/33634/files#diff-3e66159ec7e545cdb519881ff0194d3e2151d3d3c9a963bf2b82e46b3119a92cR75

[paultsimura]

@Pujan92 thanks for the tag. Could you reproduce this issue on your side?
I couldn't neither on Prod nor in Dev. Tried incognito mode just to make sure there is no cache – still couldn't reproduce. Both dark and light themes:

[Pujan92]

I am able to reproduce it on the native(bcoz of tintColor of the expo image).

App/src/components/ImageSVG/index.native.tsx

Line 7 in 9e81447

const tintColorProp = fill ? {tintColor: fill} : {};

Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-12-28.at.01.12.24.mp4

[paultsimura]

You're right @Pujan92, thank you for pointing this out.
Looks like this is a regression from #33589. I will spin up a fixing PR now.

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Assigning @paultsimura as this is related to PR from them and me as a reviewer, but no payment for the PR as its a regression

[mountiny]

Given the original issue where the fix caused this regression was $250, I am going to adjust the value here to $250 too as it would not make sense to have this fix higher reward than the original

[melvin-bot]

Upwork job price has been updated to $250

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.20-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Fix remove the fill for non-icon mentions #33668

If no regressions arise, payment will be issued on 2024-01-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Contributor)
• @shubham1206agra requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

@shubham1206agra can you please complete the above checklist?

[slafortune]

@shubham1206agra @paultsimura please accept the offers that had been sent, I'll adjust the amount from $500 to $250 when I pay them.

[shubham1206agra]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: [CP Staging] fix: Make the "@here" mention icon green #33634
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/33634/files#r1447454237
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
• [@shubham1206agra] Determine if we should create a regression test for this bug. No as Applause already has this test in deploy suite here [HOLD for payment 2024-01-09][$250] Mentions - @ Here icon is black #33589
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[shubham1206agra]

Accepted the offer

[paultsimura]

Accepted, thanks.