[HOLD for payment 2024-02-15] [$500] IOU - LHN preview for IOU report does not update to the latest amount when amount is changed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.19-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to FAB > Request money > Manual
2. Create a manual request
3. Click on IOU preview twice to go to details view
4. Click Amount and change the amount
5. Return to IOU report

Expected Result:

The amount requested in LHN for the IOU report will update to the latest amount

Actual Result:

The amount requested in LHN for the IOU report does not update to the latest amount

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

20231229_183508.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e4739cbceab8e8b5
• Upwork Job ID: 1740529182306668544
• Last Price Increase: 2024-01-05

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e4739cbceab8e8b5

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

@allroundexperts, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@allroundexperts, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[laurenreidexpensify]

Waiting for proposals

[laurenreidexpensify]

Still waiting for proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[laurenreidexpensify]

No proposals yet - waiting to see if we get any

[koko57]

@laurenreidexpensify I can look into it, as I was working on LHN previews 🙂 But I also see that the total is not updated here (right upper corner) am I right?

cc @mountiny

[kameshwarnayak]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - LHN preview for IOU report does not update to the latest amount when amount is changed

What is the root cause of that problem?

The API call UpdateMoneyRequestAmountAndCurrency does not change the total value in the report_XXXXXXX onyx data instead adds the diff to nonReimbursableTotal as seen in the screenshot below. Similarly the originalMessage?.amount has the original values when the record was created

But the LHN and Title reads from originalMessage?.amount and report.total respectively which still has old value as seen in the below codes.

App/src/libs/ReportUtils.ts

Line 2141 in 76e5b1c

const amount = originalMessage?.amount;

App/src/libs/ReportUtils.ts

Line 1697 in 76e5b1c

const total = moneyRequestReport?.total ?? 0;

What changes do you think we should make in order to solve the problem?

To solve this we need to subtract nonReimbursableTotal from the total. Make the following changes to achieve the right result
Replace

App/src/libs/ReportUtils.ts

Line 1697 in 76e5b1c

const total = moneyRequestReport?.total ?? 0;

With

    let nonReimbursableSpend = moneyRequestReport?.nonReimbursableTotal ?? 0;
    const total = (moneyRequestReport?.total ?? 0) - nonReimbursableSpend;

Replace

App/src/libs/ReportUtils.ts

Lines 2141 to 2147 in 76e5b1c

	const amount = originalMessage?.amount;
	const currency = originalMessage?.currency ?? report.currency ?? '';
	const amountToDisplay = CurrencyUtils.convertToDisplayString(Math.abs(amount), currency);
	// We only want to show the actor name in the preview if it's not the current user who took the action
	const requestorName = lastActorID && lastActorID !== currentUserAccountID ? getDisplayNameForParticipant(lastActorID, !isPreviewMessageForParentChatReport) : '';
	return `${requestorName ? `${requestorName}: ` : ''}${Localize.translateLocal('iou.requestedAmount', {formattedAmount: amountToDisplay})}`;

With (amountToDisplay becomes in formattedAmount in the return)

    // We only want to show the actor name in the preview if it's not the current user who took the action
    const requestorName = lastActorID && lastActorID !== currentUserAccountID ? getDisplayNameForParticipant(lastActorID, !isPreviewMessageForParentChatReport) : '';
    return `${requestorName ? `${requestorName}: ` : ''}${Localize.translateLocal('iou.requestedAmount', {formattedAmount: formattedAmount})}`;

And finally replace

App/src/libs/ReportUtils.ts

Line 1720 in 76e5b1c

let totalSpend = moneyRequestReport.total ?? 0;

with

    let totalSpend = (moneyRequestReport.total ?? 0) - nonReimbursableSpend;

This will fix the discrepancy in the split that we see in the report split seen below

The above fix also works when we have multiple requests in one report

Result :

Single request

screen-recording-2024-01-10.mp4

Multiple requests

multiple-requests.mp4

What alternative solutions did you explore? (Optional)

NA

[mountiny]

thanks @koko57 I think the proposal from @kameshwarnayak looks good

@grgia or @luacmartins would you like to take this one as CME since you have experience with this?

[luacmartins]

Yea, I can take this one. Thanks for the work so far @koko57 and @kameshwarnayak. I looked at the OP and I actually think this is a backend issue. We're not updating the report total on the new method. Here's the PR to fix that https://github.com/Expensify/Auth/pull/9629

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: display iou amount and currency from the last transaction #35818

If no regressions arise, payment will be issued on 2024-02-15. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @situchan paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@laurenreidexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1740529182306668544/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[laurenreidexpensify]

Offer sent to @situchan in Upwork https://www.upwork.com/jobs/~0194ec363293ea15d0

[kbecciv]

@laurenreidexpensify Do you need to include this issue in weekly retest? It has weekly re-test label.

[laurenreidexpensify]

@luacmartins can you confirm if payment is bundled under a payment in #35818 or needs additional payment - I got a little confused here. Thanks!

[situchan]

The PR linked 2 issues. I am not assigned in #34411 so payment can be handled here.
cc: @mountiny

[luacmartins]

Agree that we can handle it here since @situchan is not assigned in #34411

[mountiny]

Sounds good, lets handle the $500 payment here

[laurenreidexpensify]

Payment Summary:

C+: $500 payment issued in Upwork @situchan

[laurenreidexpensify]

@situchan pls complete any necessary checklists

[situchan]

Originally, issue was in backend as per #33733 (comment).
We can skip regression test as reported by QA team.

[mvtglobally]

Issue not reproducible during KI retests. (First week)