[WAITING ON CHECKLIST][$500] IOU-Order of display of date and distance is different in distance confirmation & details page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.19-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a Workspace chat
3. Tap plus icon ---- Request money ---- Distance
4. Enter start and finish waypoints
5. Tap next
6. Note in distance request confirmation page, first date and then distance section is displayed.
7. Tap distance
8. Tap on distance request created to open distance request details page
9. Note in distance request details page, first distance and then date section is displayed.

Expected Result:

The order of display of date and distance must be same in distance confirmation & details page.

Actual Result:

The order of display of date and distance is different in distance confirmation & details page.

In distance request confirmation page, first date and then distance section is displayed. In distance request details page, first distance and then date section is displayed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6328225_1703840114361.dus.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014b42dbccdf1e5222
• Upwork Job ID: 1740699117183172608
• Last Price Increase: 2024-01-05
• Automatic offers:
• fedirjh | Reviewer | 28091364
• dukenv0307 | Contributor | 28091366

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014b42dbccdf1e5222

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The order of display of date and distance is different in distance confirmation & details page.

What is the root cause of that problem?

The MenuItemWithTopDescription for date and distance are just in different order between the 2 pages here and here.

What changes do you think we should make in order to solve the problem?

Make the MenuItemWithTopDescription for date and distance are the same between the 2 pages. I think the user is interested in Distance first so it should go first, but the other way is fine.

Also the Merchant and Date order for non-distance are also inconsistent due to the same reason, we should make them consistent too (Merchant should likely be first)

We can apply the ordering to MoneyRequestConfirmationList as well besides the MoneyTemporaryForRefactorRequestConfirmationList.

What alternative solutions did you explore? (Optional)

NA

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU-Order of display of date and distance is different in distance confirmation & details page

What is the root cause of that problem?

in confirmation date comes before distance

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Lines 649 to 673 in 7d1b0f8

	{shouldShowDate && (
	<MenuItemWithTopDescription
	shouldShowRightIcon={!isReadOnly}
	title={iouCreated || format(new Date(), CONST.DATE.FNS_FORMAT_STRING)}
	description={translate('common.date')}
	style={[styles.moneyRequestMenuItem]}
	titleStyle={styles.flex1}
	onPress={() => {
	if (isEditingSplitBill) {
	Navigation.navigate(ROUTES.EDIT_SPLIT_BILL.getRoute(reportID, reportActionID, CONST.EDIT_REQUEST_FIELD.DATE));
	return;
	}
	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DATE.getRoute(iouType, transaction.transactionID, reportID, Navigation.getActiveRouteWithoutParams()));
	}}
	disabled={didConfirm}
	interactive={!isReadOnly}
	brickRoadIndicator={shouldDisplayFieldError && TransactionUtils.isCreatedMissing(transaction) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}
	error={shouldDisplayFieldError && TransactionUtils.isCreatedMissing(transaction) ? translate('common.error.enterDate') : ''}
	/>
	)}
	{isDistanceRequest && (
	<MenuItemWithTopDescription
	shouldShowRightIcon={!isReadOnly && isTypeRequest}
	title={iouMerchant}
	description={translate('common.distance')}

while it is oposite for request view

App/src/components/ReportActionItem/MoneyRequestView.js

Lines 228 to 263 in 7d1b0f8

	{isDistanceRequest ? (
	<OfflineWithFeedback pendingAction={lodashGet(transaction, 'pendingFields.waypoints') || lodashGet(transaction, 'pendingAction')}>
	<MenuItemWithTopDescription
	description={translate('common.distance')}
	title={hasPendingWaypoints ? transactionMerchant.replace(CONST.REGEX.FIRST_SPACE, translate('common.tbd')) : transactionMerchant}
	interactive={canEdit && !isSettled}
	shouldShowRightIcon={canEdit && !isSettled}
	titleStyle={styles.flex1}
	onPress={() => Navigation.navigate(ROUTES.EDIT_REQUEST.getRoute(report.reportID, CONST.EDIT_REQUEST_FIELD.DISTANCE))}
	/>
	</OfflineWithFeedback>
	) : (
	<OfflineWithFeedback pendingAction={lodashGet(transaction, 'pendingFields.merchant') || lodashGet(transaction, 'pendingAction')}>
	<MenuItemWithTopDescription
	description={translate('common.merchant')}
	title={transactionMerchant}
	interactive={canEdit}
	shouldShowRightIcon={canEdit}
	titleStyle={styles.flex1}
	onPress={() => Navigation.navigate(ROUTES.EDIT_REQUEST.getRoute(report.reportID, CONST.EDIT_REQUEST_FIELD.MERCHANT))}
	brickRoadIndicator={hasErrors && isEmptyMerchant ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}
	error={hasErrors && isEmptyMerchant ? translate('common.error.enterMerchant') : ''}
	/>
	</OfflineWithFeedback>
	)}
	<OfflineWithFeedback pendingAction={getPendingFieldAction('pendingFields.created')}>
	<MenuItemWithTopDescription
	description={translate('common.date')}
	title={transactionDate}
	interactive={canEdit && !isSettled}
	shouldShowRightIcon={canEdit && !isSettled}
	titleStyle={styles.flex1}
	onPress={() => Navigation.navigate(ROUTES.EDIT_REQUEST.getRoute(report.reportID, CONST.EDIT_REQUEST_FIELD.DATE))}
	brickRoadIndicator={hasErrors && transactionDate === '' ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}
	error={hasErrors && transactionDate === '' ? translate('common.error.enterDate') : ''}
	/>

What changes do you think we should make in order to solve the problem?

We should choose one oreder and make it consistent for both

What alternative solutions did you explore? (Optional)

[dukenv0307]

Proposal updated to add permalinks to pages, also to clarify the following additional issue

Also the Merchant and Date order for non-distance are also inconsistent due to the same reason, we should make them consistent too (Merchant should likely be first)

[melvin-bot]

@jliexpensify, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@jliexpensify, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jliexpensify]

Can repro on v1.4.20-2. Going to let Dylan know in the #wave5 channel - https://expensify.slack.com/archives/C05DWUDHVK7/p1704161483557099

[jliexpensify]

@fedirjh - please review proposals!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[fedirjh]

@dukenv0307 Proposal looks good to me , the fix looks simple and straightforward.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@deetergp, @jliexpensify, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[fedirjh]

Awaiting the green light from @deetergp for #33751 (comment)

[deetergp]

I agree, let's go with @dukenv0307's proposal 👍

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@fedirjh The PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Re-order merchant and date field in confirm page #34201

If no regressions arise, payment will be issued on 2024-01-22. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment automatic offer (Reviewer)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

@fedirjh bump to complete the checklist please!

[jliexpensify]

Payment Summary

• Contributor: @dukenv0307 $500
• C+: @fedirjh $500

Upwork job

[jliexpensify]

Paid and posting removed. Waiting on checklist from @fedirjh

[fedirjh]

BugZero Checklist:

• Link to the PR: Refactor the money request creation flow #28618
• Link to comment: Refactor the money request creation flow #28618 (comment)
• Link to discussion: N/A
• Determine if we should create a regression test for this bug: Yes

1. Open App
2. Create a distance request
3. In the confirm page, verify that the distance field is above the date field
4. Confirm the request and go to the transaction thread report
5. Verify that the distance field is above the date field