[$500] Split - Billable toggle is disabled in split details view when it is enabled during creation #33763

kbecciv · 2023-12-29T17:31:05Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.19-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

User is an employee of a Collect workspace.
The Collect workspace has "Re-bill expenses to clients" set to "Default to billable".
1 Go to workspace chat as employee.

Click + > Split bill > Manual.
Enter amount > Proceed to confirmation page.
Split the bill with "Default to billable" toggled on.
Click on the split details view.
Click on "Default to billable" toggle.
Go to expense details page for the split.

Expected Result:

In Step 5 and 7, "Default to billable" toggle is enabled.

Actual Result:

In Step 5 and 7, "Default to billable" toggle is disabled when it is toggled on during creation. It cannot be toggled on in split details page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6328518_1703867572502.20231229_205310.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ac2c6e9de8acf9c4
Upwork Job ID: 1740787546852888576
Last Price Increase: 2024-01-05
Automatic offers:

dukenv0307 | Contributor | 28120009

Issue Owner

Current Issue Owner: @sobitneupane

melvin-bot · 2023-12-29T17:31:09Z

Job added to Upwork: https://www.upwork.com/jobs/~01ac2c6e9de8acf9c4

melvin-bot · 2023-12-29T17:31:11Z

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-12-29T17:31:13Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-12-29T17:31:15Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

unidev727 · 2023-12-29T17:50:58Z

Proposal

from: @unicorndev-727

Please re-state the problem that we are trying to solve in this issue.

Split - Billable toggle is disabled in split details view when it is enabled during creation

What is the root cause of that problem?

The root cause is that we don't send billable value to buildOptimisticTransaction method so that default value(false) is set when creating splitTransaction.

App/src/libs/actions/IOU.js

Lines 1151 to 1165 in 595bf40

    
           const splitTransaction = TransactionUtils.buildOptimisticTransaction( 
        
               amount, 
        
               currency, 
        
               CONST.REPORT.SPLIT_REPORTID, 
        
               comment, 
        
               '', 
        
               '', 
        
               '', 
        
               merchant, 
        
               undefined, 
        
               undefined, 
        
               undefined, 
        
               category, 
        
               tag, 
        
           );

App/src/libs/TransactionUtils.ts

Lines 76 to 90 in 595bf40

    
           function buildOptimisticTransaction( 
        
               amount: number, 
        
               currency: string, 
        
               reportID: string, 
        
               comment = '', 
        
               created = '', 
        
               source = '', 
        
               originalTransactionID = '', 
        
               merchant = '', 
        
               receipt: Receipt = {}, 
        
               filename = '', 
        
               existingTransactionID: string | null = null, 
        
               category = '', 
        
               tag = '', 
        
               billable = false,

What changes do you think we should make in order to solve the problem?

We need to send billable value down to buildOptimisticTransaction when creating IOU request.

App/src/libs/actions/IOU.js

Line 1141 in 595bf40

    
           function createSplitsAndOnyxData(participants, currentUserLogin, currentUserAccountID, amount, comment, currency, category, tag, existingSplitChatReportID = '', merchant) {

to

function createSplitsAndOnyxData(participants, currentUserLogin, currentUserAccountID, amount, comment, currency, merchant, category, tag, existingSplitChatReportID = '', billable = false) {
    const currentUserEmailForIOUSplit = OptionsListUtils.addSMSDomainIfPhoneNumber(currentUserLogin);
    const participantAccountIDs = _.map(participants, (participant) => Number(participant.accountID));
    const existingSplitChatReport =
        existingSplitChatReportID || participants[0].reportID
            ? allReports[`${ONYXKEYS.COLLECTION.REPORT}${existingSplitChatReportID || participants[0].reportID}`]
            : ReportUtils.getChatByParticipants(participantAccountIDs);
    const splitChatReport = existingSplitChatReport || ReportUtils.buildOptimisticChatReport(participantAccountIDs);
    const isOwnPolicyExpenseChat = splitChatReport.isOwnPolicyExpenseChat;

    const splitTransaction = TransactionUtils.buildOptimisticTransaction(
        amount,
        currency,
        CONST.REPORT.SPLIT_REPORTID,
        comment,
        '',
        '',
        '',
        merchant || Localize.translateLocal('iou.request'),
        undefined,
        undefined,
        undefined,
        category,
        tag,
        billable
    );

App/src/libs/actions/IOU.js

Line 1484 in 595bf40

    
           function splitBill(participants, currentUserLogin, currentUserAccountID, amount, comment, currency, category, tag, existingSplitChatReportID = '', merchant) {

to

function splitBill(participants, currentUserLogin, currentUserAccountID, amount, comment, currency, merchant, category, tag, existingSplitChatReportID = '', billable = false) {
    const {splitData, splits, onyxData} = createSplitsAndOnyxData(
        participants,
        currentUserLogin,
        currentUserAccountID,
        amount,
        comment,
        currency,
        merchant,
        category,
        tag,
        existingSplitChatReportID,
        billable 
    );

App/src/pages/iou/request/step/IOURequestStepConfirmation.js

Lines 213 to 228 in 595bf40

    
                   transaction.tag, 
        
                   report.reportID, 
        
                   transaction.merchant, 
        
               ); 
        
               return; 
        
           } 
        
           // If the request is created from the global create menu, we also navigate the user to the group report 
        
           if (iouType === CONST.IOU.TYPE.SPLIT) { 
        
               IOU.splitBillAndOpenReport( 
        
                   selectedParticipants, 
        
                   currentUserPersonalDetails.login, 
        
                   currentUserPersonalDetails.accountID, 
        
                   transaction.amount, 
        
                   trimmedComment, 
        
                   transaction.currency,

if (iouType === CONST.IOU.TYPE.SPLIT && !transaction.isFromGlobalCreate) {
                IOU.splitBill(
                    selectedParticipants,
                    currentUserPersonalDetails.login,
                    currentUserPersonalDetails.accountID,
                    transaction.amount,
                    trimmedComment,
                    transaction.currency,
                    transaction.merchant,
                    transaction.category,
                    transaction.tag,
                    report.reportID,
                    transaction.billable
                );
                return;
            }

Above solution is only for split money request in workspace and this error is happened because we didn't consider billable state when creating transaction so we would need to check transaction creation workflow in money request and would add billable values here for other edge cases.

App/src/pages/iou/request/step/IOURequestStepConfirmation.js

Line 191 in 595bf40

const createTransaction = useCallback(

What alternative solutions did you explore? (Optional)

N/A

melvin-bot · 2024-01-01T18:23:44Z

@sobitneupane, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

laurenreidexpensify · 2024-01-02T12:40:01Z

@sobitneupane bump for review of the proposal above thanks

dukenv0307 · 2024-01-03T09:17:53Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Default to billable" toggle is disabled when it is toggled on during creation. It cannot be toggled on in split details page.

What is the root cause of that problem?

In optimistic data, we don't pass billable to buildOptimisticTransaction which makes it's false by default

App/src/libs/actions/IOU.js

Line 1185 in 2fe1174

tag,

When creating the split bill, we don't pass billable to the payload of the API

What changes do you think we should make in order to solve the problem?

In each function of split bill request like splitBill, splitBillAndOpenReport, createSplitsAndOnyxData and startSplitBill, add an extra param billable with default value is false. And pass this param to buildOptimisticTransaction.
On confirm page, we will pass transaction.billable to the function when we create the split bill.
In SplitBillDetailsPage, pass iouIsBillable into MoneyRequestConfirmList.
I tested adding billable as true to the payload of splitBill API but BE still returns billable as false. So if we allow billable for split bill we should also fix from BE to return billable as true if the billable in the payload is true.

What alternative solutions did you explore? (Optional)

If the expected behavior is not enabled billable for split bill we should hide billable option if the request is split bill or disable billable section if the request is split bill.

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Line 273 in 2fe1174

    
           const shouldShowBillable = !lodashGet(policy, 'disabledFields.defaultBillable', true);

laurenreidexpensify · 2024-01-05T10:05:35Z

@sobitneupane please review the proposals above thank you

melvin-bot · 2024-01-05T16:00:08Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

sobitneupane · 2024-01-05T16:29:21Z

I tested to add billable as true to the payload of splitBill API but BE still returns billable as false. So if we allow billable for split bill we should also fix from BE to return billable as true if the billable in the payload is true.

As pointed out by @dukenv0307 in his proposal, this should probably be handled in BE as well. @laurenreidexpensify Can we assign internal engineer to investigate issue on backend.

melvin-bot · 2024-01-08T10:42:04Z

Current assignee @sobitneupane is eligible for the Internal assigner, not assigning anyone new.

melvin-bot · 2024-01-08T10:42:18Z

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

laurenreidexpensify · 2024-01-08T10:42:34Z

@francoisl assigning internal as this is BE fix

francoisl · 2024-01-11T23:59:39Z

Backend fixes are in review, I'll update here when they're deployed to staging.

francoisl · 2024-01-16T21:02:09Z

The backend fixes are on staging now, feel free to test your proposals again by passing billable to the API. Let me know if something's not working as expected.

sobitneupane · 2024-01-18T00:39:52Z

@dukenv0307 Do you want to update your proposal? Is backend responding as expected?

dukenv0307 · 2024-01-18T04:22:35Z

@sobitneupane I tested and BE returns billable correctly now. And my proposal #33763 (comment) already has the fix in front-end now.

sobitneupane · 2024-01-24T02:37:00Z

Proposal from @dukenv0307 looks good to me.

🎀👀🎀 C+ reviewed

melvin-bot · 2024-01-24T02:37:06Z

Current assignee @francoisl is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot · 2024-01-24T18:49:12Z

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

dukenv0307 · 2024-01-25T03:59:54Z

@sobitneupane The PR is ready for review.

laurenreidexpensify · 2024-02-08T17:49:29Z

Deployed to prod #35125 (comment) 3 days ago, so should be paid on 12 feb

laurenreidexpensify · 2024-02-20T11:32:57Z

Ah yikes the automation failed here!! Let's get this paid!!

laurenreidexpensify · 2024-02-20T11:35:00Z

Payment Summary:

Contributor @dukenv0307 $500 paid in upwork
C+ @sobitneupane $500 please request payment in newdot

laurenreidexpensify · 2024-02-20T11:35:18Z

@sobitneupane please complete a checklist and confirm if we need regression steps thanks

laurenreidexpensify · 2024-02-27T06:18:34Z

@sobitneupane bump for checklist and regression steps thanks

laurenreidexpensify · 2024-03-01T07:34:29Z

@sobitneupane bump thanks

sobitneupane · 2024-03-04T07:41:33Z

@laurenreidexpensify As the issue was reported by Applause Team, I believe the regression tests are already included. In case it is requried:

Precondition:

User is an employee of a Collect workspace.
The Collect workspace has "Re-bill expenses to clients" set to "Default to billable".

Steps:

Go to workspace chat or announce room as employee.
Create a split bill with default billable is toggled on
Open split bill detail page and verify that billable is toggled on
Open expense detail page of the split bill and verify that billable is also toggled on

JmillsExpensify · 2024-03-12T03:07:12Z

$500 approved for @sobitneupane based on this summary.

kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 29, 2023

melvin-bot bot changed the title ~~Split - Billable toggle is disabled in split details view when it is enabled during creation~~ [$500] Split - Billable toggle is disabled in split details view when it is enabled during creation Dec 29, 2023

melvin-bot bot assigned laurenreidexpensify Dec 29, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 29, 2023

melvin-bot bot assigned sobitneupane Dec 29, 2023

melvin-bot bot added the Overdue label Jan 1, 2024

melvin-bot bot removed the Overdue label Jan 2, 2024

melvin-bot bot added the Overdue label Jan 4, 2024

melvin-bot bot removed the Overdue label Jan 5, 2024

melvin-bot bot added the Overdue label Jan 8, 2024

laurenreidexpensify added the Internal Requires API changes or must be handled by Expensify staff label Jan 8, 2024

laurenreidexpensify added the Engineering label Jan 8, 2024

melvin-bot bot assigned francoisl Jan 8, 2024

melvin-bot bot removed the Overdue label Jan 8, 2024

melvin-bot bot added the Overdue label Jan 10, 2024

francoisl added the Reviewing Has a PR in review label Jan 11, 2024

melvin-bot bot removed the Overdue label Jan 11, 2024

laurenreidexpensify added Weekly KSv2 and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 11, 2024

francoisl assigned dukenv0307 Jan 24, 2024

francoisl removed the Internal Requires API changes or must be handled by Expensify staff label Jan 24, 2024

dukenv0307 mentioned this issue Jan 25, 2024

Implement billable for split bill #35125

Merged

50 tasks

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 25, 2024

laurenreidexpensify added Daily KSv2 and removed Weekly KSv2 labels Feb 20, 2024

laurenreidexpensify closed this as completed Mar 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$500] Split - Billable toggle is disabled in split details view when it is enabled during creation #33763

[$500] Split - Billable toggle is disabled in split details view when it is enabled during creation #33763

kbecciv commented Dec 29, 2023 •

edited by laurenreidexpensify

Loading

melvin-bot bot commented Dec 29, 2023

melvin-bot bot commented Dec 29, 2023

melvin-bot bot commented Dec 29, 2023

melvin-bot bot commented Dec 29, 2023

unidev727 commented Dec 29, 2023 •

edited

Loading

melvin-bot bot commented Jan 1, 2024

laurenreidexpensify commented Jan 2, 2024

dukenv0307 commented Jan 3, 2024 •

edited

Loading

laurenreidexpensify commented Jan 5, 2024

melvin-bot bot commented Jan 5, 2024

sobitneupane commented Jan 5, 2024

melvin-bot bot commented Jan 8, 2024

melvin-bot bot commented Jan 8, 2024

laurenreidexpensify commented Jan 8, 2024

francoisl commented Jan 11, 2024

francoisl commented Jan 16, 2024

sobitneupane commented Jan 18, 2024

dukenv0307 commented Jan 18, 2024

sobitneupane commented Jan 24, 2024

melvin-bot bot commented Jan 24, 2024

melvin-bot bot commented Jan 24, 2024

dukenv0307 commented Jan 25, 2024

laurenreidexpensify commented Feb 8, 2024

laurenreidexpensify commented Feb 20, 2024

laurenreidexpensify commented Feb 20, 2024

laurenreidexpensify commented Feb 20, 2024

laurenreidexpensify commented Feb 27, 2024

laurenreidexpensify commented Mar 1, 2024

sobitneupane commented Mar 4, 2024

JmillsExpensify commented Mar 12, 2024

[$500] Split - Billable toggle is disabled in split details view when it is enabled during creation #33763

[$500] Split - Billable toggle is disabled in split details view when it is enabled during creation #33763

Comments

kbecciv commented Dec 29, 2023 • edited by laurenreidexpensify Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Dec 29, 2023

melvin-bot bot commented Dec 29, 2023

melvin-bot bot commented Dec 29, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Dec 29, 2023

unidev727 commented Dec 29, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Jan 1, 2024

laurenreidexpensify commented Jan 2, 2024

dukenv0307 commented Jan 3, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

laurenreidexpensify commented Jan 5, 2024

melvin-bot bot commented Jan 5, 2024

sobitneupane commented Jan 5, 2024

melvin-bot bot commented Jan 8, 2024

melvin-bot bot commented Jan 8, 2024

laurenreidexpensify commented Jan 8, 2024

francoisl commented Jan 11, 2024

francoisl commented Jan 16, 2024

sobitneupane commented Jan 18, 2024

dukenv0307 commented Jan 18, 2024

sobitneupane commented Jan 24, 2024

melvin-bot bot commented Jan 24, 2024

melvin-bot bot commented Jan 24, 2024

dukenv0307 commented Jan 25, 2024

laurenreidexpensify commented Feb 8, 2024

laurenreidexpensify commented Feb 20, 2024

laurenreidexpensify commented Feb 20, 2024

laurenreidexpensify commented Feb 20, 2024

laurenreidexpensify commented Feb 27, 2024

laurenreidexpensify commented Mar 1, 2024

sobitneupane commented Mar 4, 2024

JmillsExpensify commented Mar 12, 2024

kbecciv commented Dec 29, 2023 •

edited by laurenreidexpensify

Loading

unidev727 commented Dec 29, 2023 •

edited

Loading

dukenv0307 commented Jan 3, 2024 •

edited

Loading