[$500] Expense - System message for paid expense shows payer, while the copied content is workspace #33819

lanitochka17 · 2024-01-01T18:22:54Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.20-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

[Member] Request money in workspace chat
[Admin] Pay the request
[Member] Click on the expense preview to go to expense report
[Member] Right click on the paid system message > Copy to clipboard
[Member] Paste the content
Note that

Expected Result:

The system message should always start with the action, not the actor, regardless of who is viewing the chat. So the system message should read paid $10 rather than John paid $10 or John's Workspace paid $10.
When a user copies a system message, we should copy only what is printed, rather than adding the actor (so we should copy paid $10 instead of copying John Doe paid $10)

Actual Result:

Depending on who is viewing the report, the system message shows either paid amount elsewhere or [admin] paid amount elsewhere.
When the user copies and pastes the system message, it shows something different from what was printed originally (it shows [Workspace name] paid amount elsewhere.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6329831_1704112491311.bandicam_2023-12-30_12-33-56-983.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015bfbfa9935f7c034
Upwork Job ID: 1741887749877055488
Last Price Increase: 2024-01-22
Automatic offers:

DylanDylann | Reviewer | 28147572
dukenv0307 | Contributor | 28147573

The text was updated successfully, but these errors were encountered:

melvin-bot · 2024-01-01T18:22:58Z

Job added to Upwork: https://www.upwork.com/jobs/~015bfbfa9935f7c034

melvin-bot · 2024-01-01T18:23:00Z

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2024-01-01T18:23:01Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2024-01-01T18:23:04Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

rrrshtt · 2024-01-01T18:57:02Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clipboard information is different from what you see in chat after the expense paid action.

What is the root cause of that problem?

App/src/libs/ReportUtils.ts

Line 4106 in fe49e4f

    
           const payerName = isExpenseReport(iouReport) ? getPolicyName(iouReport) : getDisplayNameForParticipant(iouReport?.managerID, true);

App/src/libs/ReportUtils.ts

Line 2011 in fe49e4f

    
           const payerName = isExpenseReport(report) ? policyName : getDisplayNameForParticipant(report.managerID, !isPreviewMessageForParentChatReport);

As you can see, in these two lines, we choose payerName for information in the clipboard and also for showing in the system message.

What changes do you think we should make in order to solve the problem?

App/src/libs/ReportUtils.ts

Lines 4124 to 4133 in cafe831

    
           switch (originalMessage.paymentType) { 
        
               case CONST.IOU.PAYMENT_TYPE.ELSEWHERE: 
        
                   translationKey = 'iou.paidElsewhereWithAmount'; 
        
                   break; 
        
               case CONST.IOU.PAYMENT_TYPE.EXPENSIFY: 
        
               case CONST.IOU.PAYMENT_TYPE.VBBA: 
        
                   translationKey = 'iou.paidWithExpensifyWithAmount'; 
        
                   break; 
        
               default: 
        
                   translationKey = 'iou.payerPaidAmount';

Here are three different options with "PayerName": paidElsewhereWithAmount, paidWithExpensifyWithAmount, payerPaidAmount. Simply remove PayerName in their translation function, and then remove payerName on every usage of these functions (they are also used in another function called getReportPreviewMessage()).

I think there is a reason for a different function. At first glance, I won't remove the function getIOUReportActionDisplayMessage().

What alternative solutions did you explore? (Optional)

gijoe0295 · 2024-01-01T19:33:06Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

System message for paid expense shows payer, while the copied content is workspace

What is the root cause of that problem?

We show policy name instead of payer display name in case of policy:

App/src/libs/ReportUtils.ts

Line 4093 in 70967dd

    
           const payerName = isExpenseReport(iouReport) ? getPolicyName(iouReport) : getDisplayNameForParticipant(iouReport?.managerID, true);

What changes do you think we should make in order to solve the problem?

The problem here is about the inconsistency between the system message and the copied content. According to this issue:

The reportAction added to the iouReport/expenseReport comes from the reimburser who paid

We no longer need to show workspace name for reimbursement messages because it will always show the actual payer name. And thus we should remove the isExpenseReport check and always show display name:

App/src/libs/ReportUtils.ts

Line 4093 in 70967dd

    
           const payerName = isExpenseReport(iouReport) ? getPolicyName(iouReport) : getDisplayNameForParticipant(iouReport?.managerID, true);

The check (i.e. show workspace or payer name) is now only necessary for LHN or report preview.

What alternative solutions did you explore? (Optional)

NA

dukenv0307 · 2024-01-02T09:51:14Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The system message shows paid amount elsewhere, but the copied content is paid amount elsewhere

What is the root cause of that problem?

In getReportPreviewMessage function, we show the payment type for the case request is settled

App/src/libs/ReportUtils.ts

Line 2284 in d338621

let translatePhraseKey: TranslationPaths = 'iou.paidElsewhereWithAmount';

When we click on copy to clipboard, we use getIOUReportActionDisplayMessage function to get the display message and in this function, we will display the workspace name instead of the actor name.

App/src/libs/ReportUtils.ts

Line 4093 in 70967dd

    
           const payerName = isExpenseReport(iouReport) ? getPolicyName(iouReport) : getDisplayNameForParticipant(iouReport?.managerID, true);

but when we display this action, we use getReportPreviewMessage function to get iouMessage.

App/src/pages/home/report/ReportActionItemMessage.tsx

Line 56 in 70967dd

    
           iouMessage = ReportUtils.getReportPreviewMessage(ReportUtils.getReport(iouReportID), action);

What changes do you think we should make in order to solve the problem?

In getReportPreviewMessage, for the settled case we can use iou.payerPaidAmount translation key to not display the payment type of the settle message if we get this message for report preview. We can add an extra param to know whether we get the message for the report preview. We should add an extra prop to know whether we should hide the payerName.

App/src/libs/ReportUtils.ts

Line 2284 in d338621

let translatePhraseKey: TranslationPaths = 'iou.paidElsewhereWithAmount';

And then when we get the message here we will pass this param as true to hide the payerName in system paid message.

App/src/pages/home/report/ReportActionItemMessage.tsx

Line 56 in 70967dd

    
           iouMessage = ReportUtils.getReportPreviewMessage(ReportUtils.getReport(iouReportID), action);

When we click on copy to clipboard, we should copy the same message displayed by using getReportPreviewMessage function in the same way we do here.

App/src/libs/ReportUtils.ts

Line 4093 in 70967dd

    
           const payerName = isExpenseReport(iouReport) ? getPolicyName(iouReport) : getDisplayNameForParticipant(iouReport?.managerID, true);

App/src/pages/home/report/ReportActionItemMessage.tsx

Line 56 in 70967dd

    
           iouMessage = ReportUtils.getReportPreviewMessage(ReportUtils.getReport(iouReportID), action);

What alternative solutions did you explore? (Optional)

For point 2, we can remove the payerName in getIOUReportActionDisplayMessage function. But I'd like to use getReportPreviewMessage rather than update getIOUReportActionDisplayMessage function because if we make an update in getReportPreviewMessage function, we don't need to update other functions anymore.

sakluger · 2024-01-02T22:06:19Z

Something is definitely wrong here, but I'm not sure what the expected behavior is. Should the system message show the admin's name, the workspace's name, or neither? I'm confident that the system message should NOT show the admin's name, but I'm not sure which of the other two it should show.

I asked for the team's feedback in Slack: https://expensify.slack.com/archives/C02MW39LT9N/p1704233160288869

aim-salam · 2024-01-03T04:12:50Z

.

gijoe0295 · 2024-01-03T05:00:54Z

@sakluger You can refer to this issue: #30042.

sakluger · 2024-01-04T21:13:17Z

I updated the expected behavior and actual behavior. Expected result is now:

The system message should always start with the action, not the actor, regardless of who is viewing the chat. So the system message should read paid $10 rather than John paid $10 or John's Workspace paid $10.
When a user copies a system message, we should copy only what is printed, rather than adding the actor (so we should copy paid $10 instead of copying John Doe paid $10)

@rrrshtt @gijoe0295 @dukenv0307 would you like to update your proposal based on the new expected result?

dukenv0307 · 2024-01-04T22:22:27Z

Updated proposal.

gijoe0295 · 2024-01-04T22:33:41Z

Updated Proposal

Please re-state the problem that we are trying to solve in this issue.

System message for paid expense shows payer, while the copied content is workspace

What is the root cause of that problem?

We show policy name instead of payer display name in case of policy:

App/src/libs/ReportUtils.ts

Line 4093 in 70967dd

    
           const payerName = isExpenseReport(iouReport) ? getPolicyName(iouReport) : getDisplayNameForParticipant(iouReport?.managerID, true);

What changes do you think we should make in order to solve the problem?

Based on the latest expectation:

The system message should always start with the action

There are cases that needs getting rid of actor: here, here, here, and here

I'm not sure the expectation with LHN preview but I'm assuming that LHN preview message should still have actor name. Because getReportPreviewMessage is used for LHN preview as well, we should use the check isForListPreview.

We should copy only what is printed

We should use getReportPreviewDisplay for consistency:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 285 in cafe831

    
           const displayMessage = ReportUtils.getIOUReportActionDisplayMessage(reportAction);

What alternative solutions did you explore? (Optional)

NA

rrrshtt · 2024-01-04T22:57:08Z

Proposal

Updated

sakluger · 2024-01-05T20:16:50Z

@0xmiroslav hopefully one of the above proposals does the trick! Mind taking a look when you hae a chance?

melvin-bot · 2024-01-08T16:00:07Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

0xmiros · 2024-01-08T16:03:50Z

reviewing

sakluger · 2024-01-10T23:08:29Z

@0xmiroslav friendly bump.

0xmiros · 2024-01-12T11:52:47Z

updating today

melvin-bot · 2024-02-07T05:38:49Z

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2024-02-07T05:39:52Z

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-02-07T05:39:57Z

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

dukenv0307 · 2024-02-10T18:52:51Z

@DylanDylann The PR is ready for review.

DylanDylann · 2024-02-15T08:36:35Z

@trjExpensify Currently, I see that in some cases the preview message and the message from the "Copy to clipboard" button are different.

Screen.Recording.2024-02-15.at.15.30.42.mov

In the above video:

Preview message in LHN: Scan in progress…
The message from "Copy to clipboard": requested ₫0

Is this expected? What do you think about displaying The message from "Copy to clipboard" similar to Preview message in LHN

cc @dukenv0307 @srikarparsi

trjExpensify · 2024-02-15T14:10:19Z

What do you think about displaying The message from "Copy to clipboard" similar to Preview message in LHN

Yeah, I think generally what you copy should be what you see, so let's copy the message being previewed.

P.s why does the receipt thumbnail appear to zoom like that, man? 😂 👀

melvin-bot · 2024-02-20T16:05:05Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot · 2024-02-20T16:23:03Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

flodnv · 2024-02-20T18:20:23Z

We are reverting the PR: #36932

I think a few considerations were missed as part of the planning of this ~~feature request~~ bug.

dukenv0307 · 2024-02-21T04:17:00Z

@flodnv I created a PR to fix the current issue and all related issues here #36993.

srikarparsi · 2024-02-21T05:31:02Z

Left a comment here, I think it might be better to merge the revert PR first and then focus on fixing this issue after.

DylanDylann · 2024-03-11T03:00:05Z

@sakluger The PR was deployed to production 2 weeks ago. Please help to process the next step

DylanDylann · 2024-03-14T09:55:17Z

@sakluger Bump this comment

cc @srikarparsi

sakluger · 2024-03-18T17:36:59Z

Sorry! All paid out now.

lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 1, 2024

melvin-bot bot changed the title ~~Expense - System message for paid expense shows payer, while the copied content is workspace~~ [$500] Expense - System message for paid expense shows payer, while the copied content is workspace Jan 1, 2024

melvin-bot bot assigned sakluger Jan 1, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 1, 2024

melvin-bot bot assigned 0xmiros Jan 1, 2024

melvin-bot bot added the Overdue label Jan 8, 2024

melvin-bot bot added Overdue and removed Overdue labels Jan 8, 2024

melvin-bot bot removed the Overdue label Jan 10, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 7, 2024

srikarparsi assigned dukenv0307 Feb 7, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 7, 2024

melvin-bot bot added the Overdue label Feb 9, 2024

dukenv0307 mentioned this issue Feb 10, 2024

Consistent system paid message #36298

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Feb 10, 2024

dukenv0307 mentioned this issue Feb 19, 2024

[$500] We are displaying the wrong messages for money request actions #36793

Closed

6 tasks

flodnv removed the Reviewing Has a PR in review label Feb 20, 2024

dukenv0307 mentioned this issue Feb 21, 2024

Fix system paid message #36993

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 21, 2024

sakluger closed this as completed Mar 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$500] Expense - System message for paid expense shows payer, while the copied content is workspace #33819

[$500] Expense - System message for paid expense shows payer, while the copied content is workspace #33819

lanitochka17 commented Jan 1, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jan 1, 2024

melvin-bot bot commented Jan 1, 2024

melvin-bot bot commented Jan 1, 2024

melvin-bot bot commented Jan 1, 2024

rrrshtt commented Jan 1, 2024 •

edited

Loading

gijoe0295 commented Jan 1, 2024 •

edited

Loading

dukenv0307 commented Jan 2, 2024 •

edited

Loading

sakluger commented Jan 2, 2024

aim-salam commented Jan 3, 2024

gijoe0295 commented Jan 3, 2024

sakluger commented Jan 4, 2024

dukenv0307 commented Jan 4, 2024

gijoe0295 commented Jan 4, 2024 •

edited

Loading

rrrshtt commented Jan 4, 2024

sakluger commented Jan 5, 2024

melvin-bot bot commented Jan 8, 2024

0xmiros commented Jan 8, 2024

sakluger commented Jan 10, 2024

0xmiros commented Jan 12, 2024

melvin-bot bot commented Feb 7, 2024

melvin-bot bot commented Feb 7, 2024

melvin-bot bot commented Feb 7, 2024

dukenv0307 commented Feb 10, 2024

DylanDylann commented Feb 15, 2024

trjExpensify commented Feb 15, 2024

melvin-bot bot commented Feb 20, 2024

melvin-bot bot commented Feb 20, 2024

flodnv commented Feb 20, 2024

dukenv0307 commented Feb 21, 2024

srikarparsi commented Feb 21, 2024 •

edited

Loading

DylanDylann commented Mar 11, 2024

DylanDylann commented Mar 14, 2024

sakluger commented Mar 18, 2024

[$500] Expense - System message for paid expense shows payer, while the copied content is workspace #33819

[$500] Expense - System message for paid expense shows payer, while the copied content is workspace #33819

Comments

lanitochka17 commented Jan 1, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jan 1, 2024

melvin-bot bot commented Jan 1, 2024

melvin-bot bot commented Jan 1, 2024

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Jan 1, 2024

rrrshtt commented Jan 1, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

gijoe0295 commented Jan 1, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dukenv0307 commented Jan 2, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

sakluger commented Jan 2, 2024

aim-salam commented Jan 3, 2024

gijoe0295 commented Jan 3, 2024

sakluger commented Jan 4, 2024

dukenv0307 commented Jan 4, 2024

gijoe0295 commented Jan 4, 2024 • edited Loading

Updated Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

rrrshtt commented Jan 4, 2024

Proposal

sakluger commented Jan 5, 2024

melvin-bot bot commented Jan 8, 2024

0xmiros commented Jan 8, 2024

sakluger commented Jan 10, 2024

0xmiros commented Jan 12, 2024

melvin-bot bot commented Feb 7, 2024

melvin-bot bot commented Feb 7, 2024

melvin-bot bot commented Feb 7, 2024

dukenv0307 commented Feb 10, 2024

DylanDylann commented Feb 15, 2024

trjExpensify commented Feb 15, 2024

melvin-bot bot commented Feb 20, 2024

melvin-bot bot commented Feb 20, 2024

flodnv commented Feb 20, 2024

dukenv0307 commented Feb 21, 2024

srikarparsi commented Feb 21, 2024 • edited Loading

DylanDylann commented Mar 11, 2024

DylanDylann commented Mar 14, 2024

sakluger commented Mar 18, 2024

lanitochka17 commented Jan 1, 2024 •

edited by melvin-bot bot

Loading

rrrshtt commented Jan 1, 2024 •

edited

Loading

gijoe0295 commented Jan 1, 2024 •

edited

Loading

dukenv0307 commented Jan 2, 2024 •

edited

Loading

gijoe0295 commented Jan 4, 2024 •

edited

Loading

srikarparsi commented Feb 21, 2024 •

edited

Loading