[$500] IOU - 'You marked this report...' message only appears on the second visit to IOU report

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. From user A, make an IOU request to user B
2. Sign in with user B
3. Open the IOU request from user A
4. Click on the IOU preview component
5. Click on 'Pay elsewhere' button
6. Navigate back to the parent report
7. Click on the IOU preview component of the settled request

Expected Result:

'You marked this report as manually reimbursed. This report will be reimbursed outside of Expensify' should be displayed in IOU report on step 5

Actual Result:

'You marked this report as manually reimbursed. This report will be reimbursed outside of Expensify' is displayed in IOU report in step 7

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6332692_1704416150287.Screen_Recording_2024-01-05_at_1.15.56_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01913119946e4f8e1d
• Upwork Job ID: 1743143357085888512
• Last Price Increase: 2024-01-05

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

This appears to be a back-end issue. It seems like we're notifying of the latest IOU action paid $XXX elsewhere here, but we're not notifying of the MARK_REIMBURSED action.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01913119946e4f8e1d

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @shubham1206agra (Internal)

[jasperhuangg]

Ah wait, after taking another look it seems we're not setting an optimistic MARKED_REIMBURSED in Onyx. That should probably be fixed.

Still, I don't think we need to block deploy on this, since if we can get a PR up sending out the Pusher data in the back-end that should remedy most of the problem.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[brunovjk]

Cool, I'm going to close this revert for now in the interest of keeping things consistent: https://github.com/Expensify/Web-Expensify/pull/40581.

It sounds like all we need to do in order to prevent this report action from showing (quickly) is to remove the MARKED_REIMBURSED action from here. This should cause it to get filtered out.

Can we close this issue?

[jasperhuangg]

@Beamanator can I get a second look at this issue? I'm not entirely sure if it's been solved yet.

[Beamanator]

Yeah sorry @jasperhuangg are you asking if we think the bug still exists or if we've agreed on the solution we want to move forward with? 😅 I believe I've seen the bug when testing in main yesterday, and I think the agreed upon solution is here? Def let me know if I'm missing something in your question :D 🙏

[brunovjk]

Proposal

Updated following discussion above. @jasperhuangg and @Beamanator can you take a look please? Thanks.

[bfitzexpensify]

Are we good to move forward with @brunovjk's proposal @Beamanator / @jasperhuangg?

[Beamanator]

I was waiting on @jasperhuangg to confirm we're on the same page with next steps 😅

[jasperhuangg]

@Beamanator ah sorry, I misunderstood. I think the proposal makes sense–as long as the Paid $ elsewhere report actions appear then that should be the expected behavior, correct?

[jasperhuangg]

@brunovjk feel free to move forward with your proposal!

[brunovjk]

Thank you. I aim to have a PR for your review by 02/23 and will notify if it's ready sooner.
I should not raise the PR until I am assigned. Correct?

[Beamanator]

@Beamanator ah sorry, I misunderstood. I think the proposal makes sense–as long as the Paid $ elsewhere report actions appear then that should be the expected behavior, correct?

Ok cool we're on the same page then! Yes exactly - I mean, as long as we we don't have any flow from OldDot that results in NO report action shown in NewDot, right?

[brunovjk]

I'm still waiting for confirmation to start. Thanks.

[jasperhuangg]

@brunovjk go for it! You've been assigned to the issue.

[brunovjk]

Sorry, I hadn't noticed, let's get to work :D thank you @jasperhuangg

[brunovjk]

PR ready for review.

[brunovjk]

@jasperhuangg and @bfitzexpensify Can you confirm if this issue/PR is valid for payment? Thanks.

[jasperhuangg]

@brunovjk ah yes, sorry I think our automated messages were broken for a bit– @bfitzexpensify do you mind handling payouts here? We need to pay out @brunovjk for implementing the fix and @akinwale for PR review

[bfitzexpensify]

You bet - offers sent @brunovjk and @akinwale

[akinwale]

@bfitzexpensify Accepted. Thanks!

[brunovjk]

Accepted. Thanks!

[bfitzexpensify]

Great - all paid out. Apologies for the delay!