Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unvalidated Sign-Up] Include a magic link in every unread message summary footer and use it for any CTAs in the email as well #34166

Closed
anmurali opened this issue Jan 9, 2024 · 37 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@anmurali
Copy link

anmurali commented Jan 9, 2024

Problem:
Email notifications from New Dot have links to go to new.expensify.com to respond, or approve, or pay etc.
Clicking on this simply brings you to new.expensify.com like any other site visitor and you have to sign in from scratch.
This feels like a sub optimal experience since we already know the user (we emailed them), and we know where they need to go (we included the CTA in the email), and yet we force them to sign in from scratch and navigate to where they need to go on their own

Solution:

  1. IF the account is unvalidated (ie, nobody has ever signed in)
  • THEN make every link we send via UnreadMessageSummary into a magic link (because there's nothing in the account yet to steal)
  1. However, after you click it the first time, you have an infinite session, so in theory you shouldn't need a magic link when clicking the link the next time. This would mean:
  • The first link you click drops you straight into the product
  • The second link requires authentication with a magic link, if you don't already have an infinite session (eg, if you are on a new device)
  1. Use that same logic for any link that would be used for any "calls to action" in the body of the email, which will soon be refactored to look exactly like the product UI.
@anmurali anmurali added Engineering Improvement Item broken or needs improvement. labels Jan 9, 2024
Copy link

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@tylerkaraszewski
Copy link
Contributor

Sorry Melvin, my plate is full.

@MitchExpensify
Copy link
Contributor

@techievivek
Copy link
Contributor

I can work on this one. Thanks. 🙌

Copy link

melvin-bot bot commented Jan 15, 2024

@techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

@techievivek
Copy link
Contributor

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 16, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

@techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MitchExpensify
Copy link
Contributor

Copy link

melvin-bot bot commented Jan 29, 2024

@techievivek 12 days overdue. Walking. Toward. The. Light...

@techievivek
Copy link
Contributor

Sorry, I couldn't prioritize this today. I will work on it tomorrow :for-sure:, I also replied to the thread here: https://expensify.slack.com/archives/C05NJ4SLBMF/p1706595259842319

@melvin-bot melvin-bot bot removed the Overdue label Jan 30, 2024
@techievivek
Copy link
Contributor

@melvin-bot melvin-bot bot added the Overdue label Feb 2, 2024
@techievivek
Copy link
Contributor

Added an updated here: https://expensify.slack.com/archives/C05NJ4SLBMF/p1707141774434789?thread_ts=1706915414.620219&cid=C05NJ4SLBMF

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 5, 2024
@trjExpensify trjExpensify added Weekly KSv2 and removed Reviewing Has a PR in review Monthly KSv2 labels May 15, 2024
@melvin-bot melvin-bot bot added the Overdue label May 15, 2024
@techievivek
Copy link
Contributor

As discussed here https://expensify.slack.com/archives/C036QM0SLJK/p1716211040969329?thread_ts=1715336674.469839&cid=C036QM0SLJK, I will review this and the main GH #30794 along with the linked PR by tomorrow.

@melvin-bot melvin-bot bot removed the Overdue label May 20, 2024
@quinthar
Copy link
Contributor

Excited for this! Let's chat in realtime here: https://expensify.slack.com/archives/C066HJM2CAZ/p1716892649705859

@melvin-bot melvin-bot bot added the Overdue label May 28, 2024
@techievivek
Copy link
Contributor

Still discussing potential solution on above thread.

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2024
@techievivek techievivek added Daily KSv2 and removed Weekly KSv2 labels May 29, 2024
@techievivek techievivek changed the title [Unvalidated Sign-Up] Include a magic link in every unread message summary footer and use it for any CTAs in the email as well Include a magic link in every unread message summary footer and use it for any CTAs in the email as well May 30, 2024
@melvin-bot melvin-bot bot added the Overdue label May 31, 2024
@techievivek
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Jun 3, 2024
@techievivek
Copy link
Contributor

@trjExpensify trjExpensify changed the title Include a magic link in every unread message summary footer and use it for any CTAs in the email as well [Unvalidated Sign-Up] Include a magic link in every unread message summary footer and use it for any CTAs in the email as well Jun 5, 2024
@trjExpensify trjExpensify moved this from Release 2: Summer 2024 (Aug) to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect Jun 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 6, 2024
@techievivek
Copy link
Contributor

Auth PR is deployed to PROD. Web-E we will get it merge it today.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 7, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

@techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jun 12, 2024

@techievivek Eep! 4 days overdue now. Issues have feelings too...

@techievivek
Copy link
Contributor

techievivek commented Jun 13, 2024

This is done and released under Xerocon milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants