Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone - App detects incorrect timezone when automatic timezone is enabled #34247

Closed
6 tasks done
lanitochka17 opened this issue Jan 10, 2024 · 10 comments
Closed
6 tasks done
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.24-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

  • Device timezone is set to automatic
  • App timezone is set to automatic
  • User lives in Malaysia with GMT+8 (Asia/Kuala_Lumpur) timezone
  1. Go to Settings > Profile > Timezone

Expected Result:

The correct timezone is detected

Actual Result:

The incorrect timezone is detected
User lives in Malaysia with GMT+8 (Asia/Kuala_Lumpur) timezone, while app shows Asia/Singapore as the automatic timezone, where Singapore is a neigbor of Malaysia

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337781_1704899025363!bandicam_2024-01-10_18-36-36-107__1_

Bug6337781_1704899025363.Screen_Recording_20240110_224011_New_Expensify.mp4

Bug6337781_1704899025367!IMG_1583

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@shubham1206agra
Copy link
Contributor

Offending PR #31074

@shubham1206agra
Copy link
Contributor

Not a big deal tbh. Both have same timezone.

@situchan
Copy link
Contributor

This is not new bug - #31074 (comment)

@situchan
Copy link
Contributor

@tienifr please check this

@tienifr
Copy link
Contributor

tienifr commented Jan 10, 2024

Sure let me take a look.

@tienifr
Copy link
Contributor

tienifr commented Jan 10, 2024

Asia/Kuala_Lumpur is an obsolete timezone and linked to Asia/Singapore instead (reference). But they all point to the same timezone GMT+8 so not a big deal.

@situchan
Copy link
Contributor

ok I will defer to @marcochavezf whether to treat this as bug or not. At least not deploy blocker

@marcochavezf
Copy link
Contributor

Thanks for the investigation @tienifr, I suppose the change is because of the new polyfill, correct? Also, given the reason here and the priorities I'm inclined to close it, we can re-open it if there other impacts of the introduced polyfill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants