[HOLD for payment 2024-03-25] [HOLD 31374,30874] [$500] Room - Email id searched not found is not displayed in "Invite" page on tapping invite #34301

lanitochka17 · 2024-01-10T22:00:37Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.24
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Go to https://staging.new.expensify.com/
Tap on a room chat
Tap header---- members
In "Find a member" section, enter an email id which is not found
Tap invite
In "Invite new members" page , note the email id not found in "members" page is not displayed
Navigate to KHN
Tap profile icon
Tap Workspaces ----- Workspace ---- Members
In "Find a member" section, enter an email id which is not found
Tap invite
In "Invite new members" page , note the email id not found in "members" page is displayed

Expected Result:

In room, members page, email id searched not found must be displayed in "Invite new members" page when tapping "invite" like in Workspace "Invite new members" page

Actual Result:

In room, members page, email id searched not found is not displayed in "Invite new members" page when tapping "invite" like in Workspace "Invite new members" page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6338147_1704917609704.r.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fabaa72dd4c7bad6
Upwork Job ID: 1745204029918879744
Last Price Increase: 2024-01-10

Issue Owner

Current Issue Owner: @dylanexpensify

melvin-bot · 2024-01-10T22:00:41Z

Job added to Upwork: https://www.upwork.com/jobs/~01fabaa72dd4c7bad6

melvin-bot · 2024-01-10T22:00:44Z

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2024-01-10T22:00:46Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

neonbhai · 2024-01-10T22:07:31Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search term lost for room invites

What is the root cause of that problem?

This happens as we are missing the search input preserving logic in RoomMembersPage

What changes do you think we should make in order

We should use SearchInputManager to preserve the search input for room members invite like we did for workspace members page.

We will:

Set up SearchInputManager to update the initial value and clean it up using a useEffect

const isFocusedScreen = useIsFocused();

useEffect(() => {
   if (!SearchInputManager.searchInput) {
       return;
   }
   setSearchValue(SearchInputManager.searchInput);
}, [isFocusedScreen]);

useEffect(() => () => (SearchInputManager.searchInput = ''), []);

Add a useEffect to set the value on mount:

useEffect(() => {
   if (!SearchInputManager.searchInput) {
       return;
   }
   setSearchTerm(SearchInputManager.searchInput);
}, []);

Update onChangeText:

onChangeText={(value) => {
   SearchInputManager.searchInput = value;
   setSearchValue(value);
}}

dukenv0307 · 2024-01-11T03:41:34Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

In room, members page, email id searched not found is not displayed in "Invite new members" page when tapping "invite" like in Workspace "Invite new members" page

What is the root cause of that problem?

For RoomMemberPage and RoomInvitePage, we don't use SearchInputManager to share the search input value

What changes do you think we should make in order to solve the problem?

On RoomMemberPage and RoomInvitePage, we should use SearchInputManager to share the search input value as we do in the WorkspaceMemberPage and WorkspaceInvitePage

For RoomMemberPage

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 92 to 96 in 823c5e2

    
           useEffect(() => { 
        
               setSearchValue(SearchInputManager.searchInput); 
        
           }, [isFocusedScreen]); 
        
           useEffect(() => () => (SearchInputManager.searchInput = ''), []);

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 479 to 482 in 823c5e2

    
           onChangeText={(value) => { 
        
               SearchInputManager.searchInput = value; 
        
               setSearchValue(value); 
        
           }}

For RoomInvitePage

App/src/pages/workspace/WorkspaceInvitePage.js

Lines 79 to 82 in 823c5e2

    
           useEffect(() => { 
        
               setSearchTerm(SearchInputManager.searchInput); 
        
           }, []);

App/src/pages/workspace/WorkspaceInvitePage.js

Lines 275 to 277 in 823c5e2

    
           onChangeText={(value) => { 
        
               SearchInputManager.searchInput = value; 
        
               setSearchTerm(value);

What alternative solutions did you explore? (Optional)

NA

aimane-chnaif · 2024-01-11T03:49:27Z

We should hold this for #31374, #30874
Discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1703557793897069?thread_ts=1703360093.158969&cid=C01GTK53T8Q

dylanexpensify · 2024-01-15T11:37:07Z

put on hold

dylanexpensify · 2024-01-23T13:20:30Z

holding

dylanexpensify · 2024-01-29T11:55:28Z

holding

dylanexpensify · 2024-02-07T10:28:41Z

holding

dylanexpensify · 2024-02-13T20:21:16Z

same

dylanexpensify · 2024-02-21T10:44:19Z

same

dylanexpensify · 2024-02-28T08:58:22Z

same!

dylanexpensify · 2024-03-06T11:01:04Z

same

dylanexpensify · 2024-03-13T10:42:26Z

Same

melvin-bot · 2024-03-18T16:08:44Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-03-18T16:08:47Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix member search input does not display in invite search input #38276

If no regressions arise, payment will be issued on 2024-03-25. 🎊

For reference, here are some details about the assignees on this issue:

@jjcoffee requires payment (Needs manual offer from BZ)
@dukenv0307 requires payment (Needs manual offer from BZ)

melvin-bot · 2024-03-18T16:08:49Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@jjcoffee / @dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
[@jjcoffee / @dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jjcoffee / @dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jjcoffee / @dukenv0307] Determine if we should create a regression test for this bug.
[@jjcoffee / @dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

dylanexpensify · 2024-03-20T10:56:48Z

Payment coming up!

jjcoffee · 2024-03-25T10:27:44Z

The PR that introduced the bug has been identified. Link to the PR: N/A - this is more of a feature request, I think
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Create a private room
Go to the room > header > member
Search for an email that isn't already a member
Click on the invite button
Verify that the email that we entered in (3) is displayed in the search input of the invite page
Invite some users
After we go back to the invite page, verify that the search input is cleared

Do we agree 👍 or 👎

jjcoffee · 2024-03-27T10:38:47Z

@dylanexpensify Friendly bump for payment 🙇

dylanexpensify · 2024-03-27T11:19:55Z

Will pay today! Thanks for the bump, Joel! Dylan Courtney (He/Him/His)

…

On Wed, 27 Mar 2024 at 10:39, Joel Davies ***@***.***> wrote: @dylanexpensify <https://github.com/dylanexpensify> Friendly bump for payment 🙇 — Reply to this email directly, view it on GitHub <#34301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOKVCABDP52UG757I37GKT3Y2KHTZAVCNFSM6AAAAABBVPZ6GGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRSGQZTONBQGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

dukenv0307 · 2024-04-01T03:29:05Z

Will pay today!

@dylanexpensify any update on this?

Thank you!

jjcoffee · 2024-04-08T10:09:56Z

@dylanexpensify Friendly bump for payment on this 🙇

dylanexpensify · 2024-04-08T11:00:48Z

Payment summary!

Contributor: @dukenv0307 $500
Contributor+: @jjcoffee $500

Please apply here!!

jjcoffee · 2024-04-08T11:05:06Z

@dylanexpensify Many thanks, applied!

dylanexpensify · 2024-04-08T11:06:28Z

Offer sent @jjcoffee!!

jjcoffee · 2024-04-08T11:16:01Z

@dylanexpensify Cheers, accepted! 🙏

dylanexpensify · 2024-04-08T11:16:27Z

@jjcoffee paidddd! 🤑

dukenv0307 · 2024-04-08T17:35:35Z

Please apply here!!

@dylanexpensify I've applied, thank you!

dylanexpensify · 2024-04-08T18:06:19Z

@dukenv0307 sent offer!

dukenv0307 · 2024-04-09T16:50:01Z

@dukenv0307 sent offer!

@dylanexpensify I've accepted 🙏

puneetlath · 2024-04-17T20:49:22Z

@dylanexpensify can we pay this and close it out?

dukenv0307 · 2024-04-23T14:43:28Z

@dylanexpensify can we pay this and close it out?

@dylanexpensify friendly bump on the above!

dylanexpensify · 2024-04-23T19:13:21Z

Apologies for delay here - done!!

lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 10, 2024

melvin-bot bot changed the title ~~Room - Email id searched not found is not displayed in "Invite" page on tapping invite~~ [$500] Room - Email id searched not found is not displayed in "Invite" page on tapping invite Jan 10, 2024

melvin-bot bot assigned dylanexpensify Jan 10, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 10, 2024

melvin-bot bot assigned jjcoffee Jan 10, 2024

melvin-bot bot added the Overdue label Jan 13, 2024

dylanexpensify changed the title ~~[$500] Room - Email id searched not found is not displayed in "Invite" page on tapping invite~~ [HOLD 31374,30874] [$500] Room - Email id searched not found is not displayed in "Invite" page on tapping invite Jan 15, 2024

dylanexpensify added Weekly KSv2 and removed Daily KSv2 labels Jan 15, 2024

melvin-bot bot removed the Overdue label Jan 15, 2024

melvin-bot bot added the Overdue label Feb 6, 2024

melvin-bot bot removed the Overdue label Feb 7, 2024

barros001 mentioned this issue Feb 10, 2024

[HOLD] [$500] Workspace - WS member list when inviting users to workspace and room appears different #31374

Closed

6 tasks

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 18, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Mar 18, 2024

melvin-bot bot added the Overdue label Apr 5, 2024

melvin-bot bot removed the Overdue label Apr 8, 2024

melvin-bot bot added the Overdue label Apr 16, 2024

dylanexpensify closed this as completed Apr 23, 2024

melvin-bot bot removed the Overdue label Apr 23, 2024

[HOLD for payment 2024-03-25] [HOLD 31374,30874] [$500] Room - Email id searched not found is not displayed in "Invite" page on tapping invite #34301

[HOLD for payment 2024-03-25] [HOLD 31374,30874] [$500] Room - Email id searched not found is not displayed in "Invite" page on tapping invite #34301

Comments

lanitochka17 commented Jan 10, 2024 • edited by puneetlath Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jan 10, 2024

melvin-bot bot commented Jan 10, 2024

melvin-bot bot commented Jan 10, 2024

neonbhai commented Jan 10, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order

dukenv0307 commented Jan 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

aimane-chnaif commented Jan 11, 2024

dylanexpensify commented Jan 15, 2024

dylanexpensify commented Jan 23, 2024

dylanexpensify commented Jan 29, 2024

dylanexpensify commented Feb 7, 2024

dylanexpensify commented Feb 13, 2024

dylanexpensify commented Feb 21, 2024

dylanexpensify commented Feb 28, 2024

dylanexpensify commented Mar 6, 2024

dylanexpensify commented Mar 13, 2024

melvin-bot bot commented Mar 18, 2024

melvin-bot bot commented Mar 18, 2024

melvin-bot bot commented Mar 18, 2024 • edited by puneetlath Loading

dylanexpensify commented Mar 20, 2024

jjcoffee commented Mar 25, 2024

jjcoffee commented Mar 27, 2024

dylanexpensify commented Mar 27, 2024 via email

dukenv0307 commented Apr 1, 2024

jjcoffee commented Apr 8, 2024

dylanexpensify commented Apr 8, 2024

jjcoffee commented Apr 8, 2024

dylanexpensify commented Apr 8, 2024

jjcoffee commented Apr 8, 2024

dylanexpensify commented Apr 8, 2024

dukenv0307 commented Apr 8, 2024

dylanexpensify commented Apr 8, 2024

dukenv0307 commented Apr 9, 2024

puneetlath commented Apr 17, 2024

dukenv0307 commented Apr 23, 2024

dylanexpensify commented Apr 23, 2024

lanitochka17 commented Jan 10, 2024 •

edited by puneetlath

Loading

neonbhai commented Jan 10, 2024 •

edited

Loading

melvin-bot bot commented Mar 18, 2024 •

edited by puneetlath

Loading