[HOLD for payment 2024-02-26] Cancel payment - Inconsistency in amount update in system messages when amount is updated

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to workspace chat
2. Create a manual expense
3. Go to expense report
4. Pay elsewhere the report
5. Click 3-dot menu > Cancel payment
6. Edit the requested amount
7. Return to expense report

Expected Result:

The amount in owe message updates to the latest amount, while the amount in cancellation message should remain as the original amount since user cancels the payment for the initial amount

Actual Result:

The amount in owe message does not update, but the amount in cancellation message updates to the latest amount, when it should be the other way around

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6345383_1705504650466.bandicam_2024-01-17_21-21-44-483__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d75fd8b772fee381
• Upwork Job ID: 1747650076861669376
• Last Price Increase: 2024-01-17

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

cc @Gonals Seems like the cancelled report action is connected to the transaction but it should keep the cancelled request amount/ currency in its message field so it represents the historical datapoint correctly

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The amount in owe message does not update, but the amount in cancellation message updates to the latest amount, when it should be the other way around

What is the root cause of that problem?

Actually, we are getting the amount and currency from report so it's updated when we change the amount and currency.

App/src/libs/ReportUtils.ts

Line 1613 in 3033f99

const amount = CurrencyUtils.convertToDisplayString(Math.abs(report?.total ?? 0), report?.currency);

What changes do you think we should make in order to solve the problem?

We should get amount and currency from reportAction it self to keep the correct history action data.

App/src/libs/ReportUtils.ts

Line 1613 in 3033f99

const amount = CurrencyUtils.convertToDisplayString(Math.abs(report?.total ?? 0), report?.currency);

What alternative solutions did you explore? (Optional)

NA

[dukenv0307]

@mountiny Actually, cancel request action doesn't have any information about the total and the currency. So we should update the BE as well.

[mountiny]

I know, discussing in Slack

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d75fd8b772fee381

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[mananjadhav]

@mountiny @Gonals Are we tracking the BE fix here? or elsewhere?

[Gonals]

We can track it here, but it'll still take me a couple of days before I get to it

[Gonals]

This will be fixed with the new Cancel Payment development

[Gonals]

Moving to weekly until then

[mananjadhav]

@Gonals Is the PR ready for review? Also I saw that another C+ is assigned for the PR related to this issue where I am assigned.

[Gonals]

@Gonals Is the PR ready for review? Also I saw that another C+ is assigned for the PR related to this issue where I am assigned.

We reverted the original cancel payment PR, so this issue basically stopped existing. I'm keeping it around for tracking purposes (so I don't forget to implement this in the new Cancel Payments PR).

I think we can actually go ahead and close this one new tht the backend changes merged.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Cancel Payment command (again and again) #34719

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests