Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2024-02-26] Cancel payment - Red dot persists in LHN after dismissing payment cancellation error #36599

Closed
6 tasks done
kbecciv opened this issue Feb 15, 2024 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Feb 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.42-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

  • Admin and member are in the same free workspace.
  • Admin and member have bank account set up.
  1. [Member] Go to workspace chat.
  2. [Member] Create a manual request.
  3. [Admin] Pay the request with Expensify.
  4. [Admin] Go to expense report > 3-dot menu > Cancel payment.
  5. [Admin] Cancel the payment.
  6. [Admin] Dismiss cancellation error message.

Expected Result:

The red dot in LHN will disappear after dismissing the error.

Actual Result:

The red dot still persists in LHN after dismissing the error.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6380774_1708008755881.bandicam_2024-02-15_17-51-41-403.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fff48c8d19d46bc2
  • Upwork Job ID: 1762613556955721728
  • Last Price Increase: 2024-02-27
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Feb 15, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Feb 15, 2024

We think that this bug might be related #wave5-free-submitters
CC @dylanexpensify

Copy link

melvin-bot bot commented Feb 15, 2024

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@tgolen
Copy link
Contributor

tgolen commented Feb 15, 2024

@Gonals Do you think this relates to #34719?

@tgolen
Copy link
Contributor

tgolen commented Feb 15, 2024

Alberto confirmed it was caused from that PR. He will be able to fix this tomorrow morning.

@tgolen tgolen assigned Gonals and unassigned tgolen Feb 15, 2024
@Gonals
Copy link
Contributor

Gonals commented Feb 15, 2024

@kbecciv, do you know why you are getting the error in the first place?

@Gonals Gonals added the Reviewing Has a PR in review label Feb 15, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Hourly KSv2 labels Feb 15, 2024

This comment was marked as off-topic.

@Beamanator
Copy link
Contributor

Should have been unblocked by #36631

@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label Feb 19, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 19, 2024
@melvin-bot melvin-bot bot changed the title Cancel payment - Red dot persists in LHN after dismissing payment cancellation error [HOLD for payment 2024-02-26] Cancel payment - Red dot persists in LHN after dismissing payment cancellation error Feb 19, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-26. 🎊

@hoangzinh
Copy link
Contributor

@Gonals could you help to assign me and Bug label to this issue (so a BZ member will be auto-assigneed)? Thanks

@Beamanator Beamanator added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 20, 2024
@Beamanator
Copy link
Contributor

Beamanator commented Feb 20, 2024

Adding bugzero team member to help with payment 🙏 (Not due until Feb 26?)

@alexpensify
Copy link
Contributor

Noted!

@alexpensify alexpensify added Weekly KSv2 and removed Daily KSv2 labels Feb 21, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@hoangzinh
Copy link
Contributor

@alexpensify @Gonals could you help assign me to this issue? I helped review the PR #36631. Thanks

@alexpensify
Copy link
Contributor

I'll be working on the payment process later today

@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label Feb 27, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-02-26] Cancel payment - Red dot persists in LHN after dismissing payment cancellation error [$500] [HOLD for payment 2024-02-26] Cancel payment - Red dot persists in LHN after dismissing payment cancellation error Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01fff48c8d19d46bc2

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.

@alexpensify alexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
@alexpensify
Copy link
Contributor

Here is the payment summary:

  • External issue reporter - N/A
  • Contributor that fixed the issue - N/A
  • Contributor+ that helped on the issue and/or PR - @hoangzinh $500

Upwork Job: https://www.upwork.com/jobs/~01fff48c8d19d46bc2

Extra Notes regarding payment:

@hoangzinh - this is ready for you to accept. Thanks!

@hoangzinh
Copy link
Contributor

Accepted. Thanks @alexpensify

@alexpensify
Copy link
Contributor

Done, the payment has been completed in Upwork!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants