Deploy Checklist: New Expensify 2024-02-15

[github-actions]

Release Version: 1.4.42-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• [TS migration] Migrate 'TextInputWithCurrencySymbol.js' component to … #33648
• Simplify native attachment gallery paging context and improve code #34080
• Fix selection list focus #34196
• [TS migration] Migrate 'DistanceRequest' component to TypeScript #34335
• fixes : copy to clipboard mention whisper message and hide mention whisper on any action #34560
• Cancel Payment command (again and again) #34719
• [TS migration] Migrate 'Details' page to TypeScript #34811
• Replace usages of isInModal and shouldShowSmallScreen props in components #34837
• [NO QA] Update comment #34937
• [TS Migration] Migrate EditSplitBillPage to typescript #35053
• [TS migration] Migrate Signin to TypeScript #35294
• feat: Troubleshooting page & resetting Onyx state #35306
• prevent profile view of expensify notification email #35385
• Improved country search (v2) #35408
• Fix enter doesn't work after going back from referral page  #35415
• fix IOU with category can be created when admin disable the same category #35540
• [No QA] [TS migration] Migrate 'camera-roll.js' mock to TypeScript #35558
• [TS Migration] Improve Form  #35584
• Fix/33976: Workspace name in request flow is wrong color and navigating back #35594
• Fix/34611: Remove old merchant page #35641
• [TS Migration] NewDatePicker #35642
• [No QA] [TS migration] Migrate fs promises mock #35898
• Order correctly emoji skin tone #35979
• Add workspace description #36058
• [Workspace] Fix tooltip for new workspace button #36100
• Fix: Expense View Header  #36109
• [No QA] [TS migration] Migrate 'UrlTest.js' test to TypeScript #36112
• [New architecture] Upgrade react-native-android-location-enabler #36122
• [New Architecture] Upgrade react-native-safe-area-context #36137
• [New Architecture] Upgrade react-native-image-picker #36158
• [New Architecture] Upgrade react-native-haptic-feedback #36160
• Fix refreshing page causes double navigation on workspace page #36206
• Android - Scan - Icons in Scan receipt context menu appear after delay #36275
• [HybridApp] Fix NewDot internal links in HybridApp #36280
• Fix bug with Hidden is not shown on the header of avatar for Hidden contact #36290
• Fix: "Recent" and "All" appear in report field selection list when there is no result #36304
• Fix report preview settlement button text is less visible on Android #36315
• feat: Debug console view #36337
• Add support for redirecting user to a target URL when they click on the magic link code #36390
• Fix bug with Clicking on avatar of invited workspace does not open avatar in full screen view #36395
• [No QA] Add GTM call as a file #36471
• [NO QA] Fix DetailsPage typescript conflict #36474
• Fixed currency pressable ui and padding issues #36497
• Add the policy tax trackingEnabled #36521
• Revert "Simplify native attachment gallery paging context and improve code" #36524
• [No QA] Add verbose flag when using cloudflare cli #36540
• [CP Staging][No QA] Do not show push notifications for whispers targeted to others #36570
• [CP Staging] Set the error correctly on payment cancellation #36631
• [No QA] Bump cloudflare version #36753
• [CP Staging] Update nextStep on payment cancellation #36798
• [CP Staging] Fix/36574: Add condition to check required merchant #36810

Internal QA:

• [Android] Make notification content private when private mode is enabled #36475 - @Julesssss

Deploy Blockers:

• [$500] Expense - No error when saving an empty merchant in created workspace request #36574
• [$500] Login - Expensify logo is too close to the top of the screen #36575
• [$500] Web - Troubleshoot - Troubleshoot RHP does not open smoothly #36576
• [$500] Expense - Workspace under "To" field is highlighted after opening user avatar #36577
• [$500] Workspace - System message for workspace description edit shows from "" to "x" #36595
• [HOLD for payment 2024-03-14] [$500] Workspace - System message for workspace description edit with mark down is not gray #36598
• [$500] [HOLD for payment 2024-02-26] Cancel payment - Red dot persists in LHN after dismissing payment cancellation error #36599
• Profile - Data is not loaded when go back online after page resetting with “Troubleshooting” #36601
• Unable to return to home page when logging in via link with target path #36603
• [$500] IOU - System message is not shown after completing send money request flow #36643
• [HOLD for payment 2024-03-22] [$1000] Settings - Performance and heat issues on the "Troubleshoot" option #36645
• [$500] Connect BA - User can return to the fields already filled in and edit the Tax ID #36646
• [HOLD for payment 2024-04-25] Web - Endless loading on Private section when login via Abracadabra #36647
• [$500] Profile - Infinite loading on Private section when changes made offline & back online #36678
• [$500] iOS - Settings - A black line appears above the animation #36687
• [HOLD for payment 2024-02-26] [$500] Cancel payment - No red dot in expense preview in main chat when payment cancellation fails #36695
• [Payment Due 18 March] [$500] Cancel payment - Cancellation is not updated in real time when it is not the latest request #36703
• [HOLD for payment 2024-02-26] [$500] Cancel payment - "Next step" does not update after cancelling payment until page is refreshed #36705

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.42-0 🚀

[Julesssss]

I verified the InternalQA issue here. Checking off.

[Beamanator]

Reducing #36575 to NAB status

[Beamanator]

Also demoting #36576 since there's nothing broken, and this is hopefully not a high traffic page

[Beamanator]

Similarly, demoting #36577 b/c it's weird but not necessarily a blocker

[Julesssss]

Checking off blocker #36595 as it's a minor issue

[Beamanator]

Demoting #36601 since it's a Troubleshooting action

[Beamanator]

Also demoted #36598 as it's a very minor issue

[kavimuru]

Regression is at 70%. Unchecked PRs are pending validation.

[kavimuru]

Regression is 6% left.
#34080 is failing in mweb chrome with #36597 and repro in PROD checking it off
#35294 is failing with #36651 in web and repro in PROD checking it off
#34719 is pending validation in all the platforms but Web
#35306 is pending validation in Desktop
#36304 is pending validation in Desktop
Open blockers:
#36574
#36599
#36603
#36643
#36645
#36646
#36647

[marcaaron]

Checking off #36645 as it does not seem urgent

[kavimuru]

Regression is 1% left.

#34719 is failing with KI #33540 (reopened the issue) OK to check it off?
#35306 is failing with #36601
#36304 is failing with #36602 and repro in PROD checking it off
Open blockers:
#36574
#36599
#36603
#36643
#36646
#36678
#36687
#36695

[kavimuru]

Regression is completed

#34719 is failing with KI #33540 (reopened the issue) OK to check it off?
#35306 is failing with #36601
Open blockers:
#36574
#36599
#36603
#36643
#36678
#36687
#36695
#36703
#36705

[Beamanator]

#36687 - couldn't reproduce, so marked NAB - it's also a very tiny bug and only on the troubleshooting page

[Beamanator]

#35306 is failing with #36601

We decided the issue isn't a blocker, so I checked off the PR too

[Beamanator]

Calling #36703 NAB since it's a backend issue & isn't critical, more of a nice to have

[Beamanator]

#36599 and #36695 just got fixed by #36631

[Beamanator]

Checked off #36643 b/c it got closed as expected behavior

[chiragsalian]

#34719. Checking it off. From this comment it looks like we're good to proceed.

@Expensify/applauseleads

• [$500] Profile - Infinite loading on Private section when changes made offline & back online #36678 - can you retest, it looks like we're unable to reproduce this issue.

#36705 - it looks like the PR to fix the issue was CP-d. From the checklist the CP'd PR was checked off by @kbecciv so I'm assuming they tested it and it ran well and since it was linked to the issue #36705 which has the same steps as the PR i'm going to check it off the list.

[kbecciv]

@chiragsalian QA team checked CP #36798 and it passed, checked off.

[kbecciv]

CP #36810 is Pass, checking off

[chiragsalian]

Look like this issue - #36574, has a PR that was CP-d. It looks like you checked off the PR so i guess you tested it. Can you check if that means we're good to check off its issue too i.e., #36574.

Let me know if there is anything else pending on our end.

[kbecciv]

@chiragsalian
Pending 1 DB:

1. [$500] Profile - Infinite loading on Private section when changes made offline & back online #36678

[kavimuru]

@chiragsalian #36574 can be checked off, CP #36810 is validated and it is a pass.
Only DB is #36678

[chiragsalian]

Yup i asked about #36678 in the earlier comment here. We are unable to reproduce it. Can you or someone else retest this to confirm if the issue still persists.

[kavimuru]

@chiragsalian checking

[kavimuru]

@chiragsalian not able to reproduce #36678 by the tester who reported and me.
#36678 (comment)

[chiragsalian]

Cool, i checked off #36574 and #36678

[chiragsalian]