prevent profile view of expensify notification email #35385

mkhutornyi · 2024-01-30T11:41:10Z

Details

Fixed Issues

$ #32500
PROPOSAL: #32500 (comment)

Tests

Same as QA step

Verify that no errors appear in the JS console

Offline tests

Same as QA step

QA Steps

Case 1:

Open New Expensify app
Navigate to any conversation
Request money from another account by uploading a non-legible receipt (a random pic).
Wait for smartscan to finish. It should fail.
Navigate to the IOU details
Create a thread with a system message about a receipt scanning failure
In the thread header, hover on the "Expensify" avatar
Verify that notifications@expensify.com doesn't show in tooltip
Click on avatar
In the RHP that appears, click on "Members"
In "Members," click on "Expensify" (verify that subtitle is "Hidden")
Verify that "Expensify" is not clickable

Case 2:

Open New Expensify app
Navigate to any conversation
Send any message containing https://staging.new.expensify.com/a/11665625 (In dev test: https://dev.new.expensify.com:8082/a/11665625)
Click on that link
Verify that not found page shows

Case 3:

Open New Expensify app
Navigate to any conversation
Try to mention @notifications@expensify.com
Verify that this email doesn't show in mentions list

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-01-30T12:23:26Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2024-01-31T14:29:16Z

@mkhutornyi Could you please merge main.

fedirjh · 2024-01-31T14:29:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2024-01-31.at.16.54.51-converted.mp4

Android: mWeb Chrome

CleanShot.2024-01-31.at.17.02.50.mp4

iOS: Native

CleanShot.2024-01-31.at.17.15.12.mp4

iOS: mWeb Safari

CleanShot.2024-01-31.at.17.19.26.mp4

MacOS: Chrome / Safari

CleanShot.2024-01-31.at.17.21.24.mp4

CleanShot.2024-02-08.at.22.08.06.mp4

MacOS: Desktop

CleanShot.2024-01-31.at.17.24.22.mp4

… into fix-32500

mkhutornyi · 2024-01-31T14:40:39Z

src/pages/ReportParticipantsPage.tsx

@@ -76,7 +76,7 @@ function ReportParticipantsPage({report, personalDetails}: ReportParticipantsPag

    const participants = getAllParticipants(report, personalDetails, translate).map((participant) => ({
        ...participant,
-        isDisabled: participant?.accountID ? ReportUtils.isOptimisticPersonalDetail(participant.accountID) : false,


The conflict came from TS migration.
They changed this logic so when accountID doesn't exist, isDisabled is false, which doesn't make sense to me.
I think we should disable when no accountID which was original logic.

Do we know why they changed it? Feel free to ask them

Sweet thank you 🙂. Lets see if we get an answer there and then I think we can merge if nothing comes up from that.

Alright, lets not hold this up any longer on their response. @mkhutornyi can you fix the merge conflict and then I'll approve and merge?

src/pages/ReportParticipantsPage.js

fedirjh · 2024-02-06T14:12:52Z

cc @mkhutornyi Could we move this forward? Thank you.

mkhutornyi · 2024-02-07T10:32:22Z

pushing changes today

… into fix-32500

fedirjh

Looks good, left some comments about the code.

src/components/UserDetailsTooltip/BaseUserDetailsTooltip/index.tsx

src/CONST.ts

src/pages/ReportParticipantsPage.tsx

src/pages/home/report/ReportActionItemSingle.tsx

… into fix-32500

mkhutornyi · 2024-02-08T21:55:10Z

Thanks for the feedback. All are addressed

fedirjh

Looks good to me

blimpich · 2024-02-09T01:55:36Z

Will review these changes tomorrow morning. It's late for me.

src/CONST.ts

blimpich · 2024-02-09T22:42:48Z

src/pages/ReportParticipantsPage.tsx

@@ -76,7 +76,7 @@ function ReportParticipantsPage({report, personalDetails}: ReportParticipantsPag

    const participants = getAllParticipants(report, personalDetails, translate).map((participant) => ({
        ...participant,
-        isDisabled: participant?.accountID ? ReportUtils.isOptimisticPersonalDetail(participant.accountID) : false,


Do we know why they changed it? Feel free to ask them

… into fix-32500

OSBotify · 2024-02-14T19:20:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-15T05:36:01Z

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-19T23:34:09Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

prevent profile view of expensify notification email

05595d6

mkhutornyi marked this pull request as ready for review January 30, 2024 12:23

mkhutornyi requested a review from a team as a code owner January 30, 2024 12:23

melvin-bot bot requested review from fedirjh and removed request for a team January 30, 2024 12:23

Merge branch 'main' of https://github.com/mkhutornyi/Expensify-Frontend…

e22ceac

… into fix-32500

mkhutornyi commented Jan 31, 2024

View reviewed changes

fedirjh reviewed Jan 31, 2024

View reviewed changes

src/pages/ReportParticipantsPage.js Outdated Show resolved Hide resolved

mkhutornyi added 3 commits February 7, 2024 11:47

Merge branch 'main' of https://github.com/mkhutornyi/Expensify-Frontend…

a9465a5

… into fix-32500

hide notification email from mentions

5724f5e

hide expensify notification email everywhere

8f5229d

mkhutornyi requested a review from fedirjh February 7, 2024 11:47

fedirjh suggested changes Feb 8, 2024

View reviewed changes

src/components/UserDetailsTooltip/BaseUserDetailsTooltip/index.tsx Outdated Show resolved Hide resolved

src/CONST.ts Show resolved Hide resolved

src/pages/ReportParticipantsPage.tsx Outdated Show resolved Hide resolved

src/pages/home/report/ReportActionItemSingle.tsx Show resolved Hide resolved

mkhutornyi added 2 commits February 8, 2024 22:47

Merge branch 'main' of https://github.com/mkhutornyi/Expensify-Frontend…

b9d7a25

… into fix-32500

apply suggestions from review

72a2bd4

mkhutornyi requested a review from fedirjh February 8, 2024 21:57

fedirjh approved these changes Feb 8, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich February 8, 2024 22:06

blimpich requested changes Feb 9, 2024

View reviewed changes

mkhutornyi added 2 commits February 12, 2024 12:16

Merge branch 'main' of https://github.com/mkhutornyi/Expensify-Frontend…

929db53

… into fix-32500

avoid typecast

7aaa9a4

fedirjh mentioned this pull request Feb 13, 2024

[HOLD for payment 2024-02-26] [$500] [MEDIUM] Smartscan: Thread - You can go to the notifications@expensify.com profile and send a private message #32500

Closed

6 tasks

Merge branch 'main' of https://github.com/mkhutornyi/Expensify-Frontend…

404dfb3

… into fix-32500

blimpich approved these changes Feb 14, 2024

View reviewed changes

blimpich merged commit be5ee07 into Expensify:main Feb 14, 2024
15 checks passed

github-actions bot mentioned this pull request Feb 15, 2024

Deploy Checklist: New Expensify 2024-02-15 #36558

Closed

73 tasks

NikkiWines mentioned this pull request May 31, 2024

Allow system account chat to be listed in LHN, fix chat icons #41290

Merged

49 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

prevent profile view of expensify notification email #35385

prevent profile view of expensify notification email #35385

mkhutornyi commented Jan 30, 2024 •

edited

Loading

melvin-bot bot commented Jan 30, 2024

fedirjh commented Jan 31, 2024

fedirjh commented Jan 31, 2024 •

edited

Loading

mkhutornyi Jan 31, 2024

blimpich Feb 9, 2024

mkhutornyi Feb 12, 2024

blimpich Feb 12, 2024

blimpich Feb 14, 2024

fedirjh commented Feb 6, 2024

mkhutornyi commented Feb 7, 2024

fedirjh left a comment

mkhutornyi commented Feb 8, 2024

fedirjh left a comment

blimpich commented Feb 9, 2024

blimpich Feb 9, 2024

OSBotify commented Feb 14, 2024

OSBotify commented Feb 15, 2024

OSBotify commented Feb 19, 2024

prevent profile view of expensify notification email #35385

prevent profile view of expensify notification email #35385

Conversation

mkhutornyi commented Jan 30, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 30, 2024

fedirjh commented Jan 31, 2024

fedirjh commented Jan 31, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mkhutornyi Jan 31, 2024

Choose a reason for hiding this comment

blimpich Feb 9, 2024

Choose a reason for hiding this comment

mkhutornyi Feb 12, 2024

Choose a reason for hiding this comment

blimpich Feb 12, 2024

Choose a reason for hiding this comment

blimpich Feb 14, 2024

Choose a reason for hiding this comment

fedirjh commented Feb 6, 2024

mkhutornyi commented Feb 7, 2024

fedirjh left a comment

Choose a reason for hiding this comment

mkhutornyi commented Feb 8, 2024

fedirjh left a comment

Choose a reason for hiding this comment

blimpich commented Feb 9, 2024

blimpich Feb 9, 2024

Choose a reason for hiding this comment

OSBotify commented Feb 14, 2024

OSBotify commented Feb 15, 2024

OSBotify commented Feb 19, 2024

mkhutornyi commented Jan 30, 2024 •

edited

Loading

fedirjh commented Jan 31, 2024 •

edited

Loading