Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to return to home page when logging in via link with target path #36603

Closed
2 of 6 tasks
kbecciv opened this issue Feb 15, 2024 · 13 comments
Closed
2 of 6 tasks

Unable to return to home page when logging in via link with target path #36603

kbecciv opened this issue Feb 15, 2024 · 13 comments
Assignees
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Feb 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.42-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #36390

Action Performed:

  1. Launch New Expensify app.
  2. Log in.
  3. Copy the magic link.
  4. Change it to staging link and add ?exitTo=/settings/preferences at the end of the link.
  5. Paste it on external app.
  6. Tap on the modified magic link with target path.
  7. After login, return to previous page via device back navigation and also app back button.

Expected Result:

App returns to Home when returning via back button.

Actual Result:

The app closes when using device back navigation, and the app back button is not responsive.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6380850_1708012632625.1708010216351_36390_Android___1_.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Feb 15, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Feb 15, 2024

We think that this bug might be related #vip-vsb
CC @quinthar

Copy link

melvin-bot bot commented Feb 15, 2024

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@AndrewGable
Copy link
Contributor

Looking into this now

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@AndrewGable
Copy link
Contributor

@allroundexperts @techievivek - Do you think this is related to the PR mentioned here #36390?

@AndrewGable
Copy link
Contributor

I don't think this needs to block deploy, but we should look into it

@AndrewGable
Copy link
Contributor

Also cc PR author @rayane-djouah for the same question.

@rayane-djouah
Copy link
Contributor

@allroundexperts @techievivek - Do you think this is related to the PR mentioned here #36390?

Yes, it's related to the mentioned PR, I will raise a follow up PR ASAP.

@techievivek techievivek self-assigned this Feb 22, 2024
@techievivek
Copy link
Contributor

techievivek commented Feb 22, 2024

@rayane-djouah, Will you be able to push a PR today? As we mentioned earlier, this is part of wave9-collect-signups, so we are looking to get this fixed ASAP. Thanks.

@rayane-djouah
Copy link
Contributor

will raise a PR today

@rayane-djouah
Copy link
Contributor

PR ready for review

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Mar 19, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

This issue has not been updated in over 15 days. @AndrewGable, @techievivek eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Mar 19, 2024
@techievivek
Copy link
Contributor

This is completed and doesn't require any payment since this is an improvement of another feature where the contributor was compensated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants