Add support for redirecting user to a target URL when they click on the magic link code #36390

rayane-djouah · 2024-02-13T01:17:35Z

Details

Add support for redirecting user to a target URL when they click on the magic link code

Fixed Issues

Tests

Precondition:
Copy the target path (the part after https://dev.new.expensify.com/) of any url from the app
Example: /settings/profile or /r/1442936292319950

Logout if you already logged in.
Start the sign in process with an email.
Copy the magic link received by email.
Add to the end of the magic link ?exitTo=valid_target_path_in_newDot examples:
https://dev.new.expensify.com/v/16379227/110480?exitTo=/settings/profile
https://dev.new.expensify.com/v/16379227/110480?exitTo=/r/1442936292319950
Paste the link in a web browser and click enter.
for native ios and android run:
npx uri-scheme open new-expensify://v/14826403/497893?exitTo=/settings/preferences --ios
npx uri-scheme open new-expensify://v/14826403/293211?exitTo=/settings/preferences --android
for desktop paste the link in this format in the web browser:
new-expensify:/v/14826403/818329?exitTo=/settings/preferences
Verify that the user is signed in and redirected automatically to the target path in the app.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Precondition:
Copy the target path (the part after https://staging.new.expensify.com/) of any url from the app
Example: /settings/profile or /r/1442936292319950

Logout if you already logged in.
Start the sign in process with an email.
Copy the magic link received by email.
Add to the end of the magic link ?exitTo=valid_target_path_in_newDot examples:
https://staging.new.expensify.com/v/16379227/110480?exitTo=/settings/profile
https://staging.new.expensify.com/v/16379227/110480?exitTo=/r/1442936292319950
Paste the link in a web browser and click enter. for native platforms, use a note app.
Verify that the user is signed in and redirected automatically to the target path in the app.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.Recording.2024-02-13.115636.mp4

Android: mWeb Chrome

mweb.chrome.Recording.2024-02-13.111846.mp4

iOS: Native

ios.Recording.2024-02-13.141218.mp4

ps: my ios simulator is very slow

iOS: mWeb Safari

mweb.safari.Recording.2024-02-13.135935.mp4

running into issues with my simulator, I'm searching for a solution.

MacOS: Chrome / Safari

web.Recording.2024-02-13.111312.mp4

If the user is not logged in (and initiated the login process on the same browser)

1.Recording.2024-02-13.015036.mp4

If the user is not logged in (and initiated the login process in another browser)

3.Recording.2024-02-13.015229.mp4

If the user is already logged in

2.Recording.2024-02-13.015620.mp4

MacOS: Desktop

desktop.Recording.2024-02-13.114449.mp4

…am) when they click on the magic link code

melvin-bot · 2024-02-13T11:03:43Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-02-13T20:05:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-14.at.12.35.32.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-14.at.12.33.02.PM.mov

iOS: Native

Screen.Recording.2024-02-14.at.12.31.31.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-14.at.12.30.14.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-14.at.12.26.23.PM.mov

MacOS: Desktop

Screen.Recording.2024-02-14.at.12.29.00.PM.mov

src/pages/ValidateLoginPage/index.tsx

allroundexperts

I see a lot of code being repeated. Can you please clean this up a little?

MitchExpensify · 2024-02-14T02:25:16Z

Do you have an ETA on when you'll be able to resolve @allroundexperts comments, @rayane-djouah ? Thanks! This is a high priority issue for us 🙇

rayane-djouah · 2024-02-14T05:13:10Z

I updated the PR based on @allroundexperts comments

allroundexperts · 2024-02-14T05:24:26Z

Reviewing again now!

src/pages/ValidateLoginPage/index.tsx

rayane-djouah · 2024-02-14T05:47:29Z

Updated
@allroundexperts

src/pages/ValidateLoginPage/index.tsx

src/libs/actions/Session/index.ts

src/pages/ValidateLoginPage/index.tsx

techievivek

Changes look good to me, but the similar lines of code seem to be all over the place. It would be great to DRY up this more so it's easy to understand. Or maybe I am wrong that it can't be DRYed up more.

techievivek · 2024-02-14T07:03:44Z

I think this is fine; I don't see much scope of DRYing it up further. @allroundexperts Do you have any thoughts about it?

rayane-djouah · 2024-02-14T07:14:09Z

Updated

allroundexperts · 2024-02-14T07:15:24Z

I think this is fine; I don't see much scope of DRYing it up further. @allroundexperts Do you have any thoughts about it?

Agreed. Testing this now.

allroundexperts

Looks good!

techievivek

Look so much cleaner with the recent commit, thanks.

OSBotify · 2024-02-14T07:54:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-15T05:37:19Z

🚀 Deployed to staging by https://github.com/techievivek in version: 1.4.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-19T23:35:27Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add support for redirecting user to a target URL(via exitTo query par…

0273307

…am) when they click on the magic link code

rayane-djouah mentioned this pull request Feb 13, 2024

[HOLD for payment 2024-02-26] [$500] Add support for redirecting user to a target URL(via exitTo query param) when they click on the magic link code #36325

Closed

rayane-djouah added 2 commits February 13, 2024 10:27

fix lint error

64e1f3f

run prettier

b7fba90

rayane-djouah marked this pull request as ready for review February 13, 2024 11:03

rayane-djouah requested a review from a team as a code owner February 13, 2024 11:03

melvin-bot bot requested review from allroundexperts and removed request for a team February 13, 2024 11:03

allroundexperts reviewed Feb 13, 2024

View reviewed changes

src/pages/ValidateLoginPage/index.tsx Outdated Show resolved Hide resolved

allroundexperts suggested changes Feb 13, 2024

View reviewed changes

rayane-djouah added 2 commits February 13, 2024 21:41

DRY code

80b7cdc

remove unused imports

5e135e0

rayane-djouah requested a review from allroundexperts February 13, 2024 20:45

allroundexperts reviewed Feb 14, 2024

View reviewed changes

src/pages/ValidateLoginPage/index.tsx Outdated Show resolved Hide resolved

rayane-djouah added 2 commits February 14, 2024 06:43

DRY code

ed573fc

readd comment

16e9324

rayane-djouah requested a review from allroundexperts February 14, 2024 05:46

allroundexperts reviewed Feb 14, 2024

View reviewed changes

src/pages/ValidateLoginPage/index.tsx Outdated Show resolved Hide resolved

rayane-djouah requested a review from allroundexperts February 14, 2024 06:11

techievivek reviewed Feb 14, 2024

View reviewed changes

src/libs/actions/Session/index.ts Outdated Show resolved Hide resolved

techievivek reviewed Feb 14, 2024

View reviewed changes

src/pages/ValidateLoginPage/index.tsx Outdated Show resolved Hide resolved

techievivek reviewed Feb 14, 2024

View reviewed changes

DRY code

68db06b

rayane-djouah requested a review from techievivek February 14, 2024 07:13

fix lint error

643df64

allroundexperts approved these changes Feb 14, 2024

View reviewed changes

techievivek approved these changes Feb 14, 2024

View reviewed changes

techievivek merged commit 00fc955 into Expensify:main Feb 14, 2024
16 checks passed

techievivek assigned rayane-djouah Feb 14, 2024

rayane-djouah deleted the add-support-for-redirecting-user-to-a-target-url-when-they-click-on-the-magic-link-code branch February 14, 2024 08:12

github-actions bot mentioned this pull request Feb 15, 2024

Deploy Checklist: New Expensify 2024-02-15 #36558

Closed

73 tasks

kbecciv mentioned this pull request Feb 15, 2024

Unable to return to home page when logging in via link with target path #36603

Closed

6 tasks

rayane-djouah restored the add-support-for-redirecting-user-to-a-target-url-when-they-click-on-the-magic-link-code branch February 23, 2024 15:03

rayane-djouah mentioned this pull request Feb 23, 2024

Fixes for feature: Add support for redirecting user to a target URL when they click on the magic link code #37145

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for redirecting user to a target URL when they click on the magic link code #36390

Add support for redirecting user to a target URL when they click on the magic link code #36390

rayane-djouah commented Feb 13, 2024 •

edited

Loading

melvin-bot bot commented Feb 13, 2024

allroundexperts commented Feb 13, 2024 •

edited

Loading

allroundexperts left a comment

MitchExpensify commented Feb 14, 2024

rayane-djouah commented Feb 14, 2024

allroundexperts commented Feb 14, 2024

rayane-djouah commented Feb 14, 2024

techievivek left a comment •

edited

Loading

techievivek commented Feb 14, 2024

rayane-djouah commented Feb 14, 2024

allroundexperts commented Feb 14, 2024

allroundexperts left a comment

techievivek left a comment

OSBotify commented Feb 14, 2024

OSBotify commented Feb 15, 2024

OSBotify commented Feb 19, 2024

Add support for redirecting user to a target URL when they click on the magic link code #36390

Add support for redirecting user to a target URL when they click on the magic link code #36390

Conversation

rayane-djouah commented Feb 13, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 13, 2024

allroundexperts commented Feb 13, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts left a comment

Choose a reason for hiding this comment

MitchExpensify commented Feb 14, 2024

rayane-djouah commented Feb 14, 2024

allroundexperts commented Feb 14, 2024

rayane-djouah commented Feb 14, 2024

techievivek left a comment • edited Loading

Choose a reason for hiding this comment

techievivek commented Feb 14, 2024

rayane-djouah commented Feb 14, 2024

allroundexperts commented Feb 14, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

techievivek left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 14, 2024

OSBotify commented Feb 15, 2024

OSBotify commented Feb 19, 2024

rayane-djouah commented Feb 13, 2024 •

edited

Loading

allroundexperts commented Feb 13, 2024 •

edited

Loading

techievivek left a comment •

edited

Loading