[HOLD for payment 2024-03-22] [$1000] Settings - Performance and heat issues on the "Troubleshoot" option

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing #35306
Version Number: 1.4.42.0
Reproducible in staging?: y
Reproducible in production?: New feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Navigate to Account settings - About - Troubleshoot
2. Background the app
3. Foreground the app
4. Swipe up and down

Expected Result:

Swiping should be smooth. The phone shouldn't heat up or crash.

Actual Result:

Low performance when I foreground the app. The phone heats up if I stay on the page. It even crashed once.
The issue disappears if I navigate back and to the "Troubleshoot" again.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6381225_1708030928625.20240215_185611.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dd3351f4b07d85c0
• Upwork Job ID: 1758255599540744192
• Last Price Increase: 2024-02-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dd3351f4b07d85c0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[marcaaron]

Trying to repro now.

[marcaaron]

It seems like a possible memory leak or something. I do notice things get slightly more janky. But doesn't seem like a blocker if the only way to reproduce it is to go to this particular page and background the app.

[melvin-bot]

@hoangzinh, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[laurenreidexpensify]

Asking here to get another repro of this

[hayata-suenaga]

sorry I always click a wrong button 😓

[ikevin127]

Will have the PR ready in about 1 hour 🚀

@hayata-suenaga Would unassigning / re-assigning me generate the automatic Upwork offer ?
If not it's fine, we can sort it out later after the regression period 🙌

[ikevin127]

PR ready for review! 🚀

[mallenexpensify]

@ikevin127 , @hoangzinh , hired ya both, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01dd3351f4b07d85c0

[hoangzinh]

Accepted. Thanks @mallenexpensify

[ikevin127]

Accepted, thank you!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• FIX: Performance and heat issues on the 'Troubleshoot' page #38093

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment (Needs manual offer from BZ)
• @ikevin127 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ikevin127]

@mallenexpensify All good for payment here ?

[mallenexpensify]

Contributor: @ikevin127 paid $1000 via Upwork
Contributor+: @hoangzinh paid $1000 via Upwork.

@hoangzinh plz fill out the BZ checklist above.

Thx!

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: feat: Troubleshooting page & resetting Onyx state #35306
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: feat: Troubleshooting page & resetting Onyx state #35306 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: ❌ I think it's an edge case and just performance improvement. Moreover, We gonna move "Troubleshoot" out of "About" setting here, so it avoids 2 Lotties animation.

[mallenexpensify]

Thanks @hoangzinh