[HOLD for payment 2024-03-18] [HIGH] [Instant Submit] for Collect: Improve creating expenses on Instant Submit paid plans, from NewDot

[Beamanator]

Holding on https://github.com/Expensify/Expensify/issues/360667

Instant Submit for Collect Workspaces Design Doc

Tracking GH issue: https://github.com/Expensify/Expensify/issues/334111

Goal for this issue: Make sure these flows work perfectly in NewDot, for Paid plans on Instant Submit

1. In Workspace chat, click report preview of a report to open the expense report
2. Request money (this currently isn't possible for submitted reports, in NewDot)
3. Verify the request / expense gets added to that correct expense report
   • Related to [HOLD for payment 2024-02-09] [HIGH] Ensure the expense is added to report from which it was requested from #34906 (comment)
4. Navigate back to the workspace chat & request money there
5. Verify the request / expense gets added to the most recently created expense report
   1. It looks like we currently optimistically try to find an OPEN report in NewDot to add a money request to & if we don't find one, we optimistically create a new Report Preview. We will need to update this to look for Processing as well, only if the policy is Instant Submit!
   2. We're also having a discussion about "do we need this to be added to the most recent expense report or any" in slack here.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f9e4f88d7ec8247b
• Upwork Job ID: 1749734239297155072
• Last Price Increase: 2024-01-23

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f9e4f88d7ec8247b

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @hoangzinh (Internal)

[Beamanator]

Technically all backend changes are ready on staging, so I'll take this off hold soon!

[Beamanator]

Looking for volunteer via Hot Pick label

[melvin-bot]

@hoangzinh, @youssef-lr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[youssef-lr]

Starting work on this one today.

[youssef-lr]

Still being worked on.

[youssef-lr]

I should have an update by EOD tomorrow. I'm switching focus temporarily to investigate a high priority issue affecting some large customers https://expensify.slack.com/archives/CC7NECV4L/p1706641694016129

[melvin-bot]

@hoangzinh, @youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[youssef-lr]

On it today again.

[melvin-bot]

@hoangzinh, @youssef-lr Huh... This is 4 days overdue. Who can take care of this?

[youssef-lr]

I should have an update in a couple of days.

[youssef-lr]

App PR is ready, but held on an Auth PR.

[trjExpensify]

App PR merged and on staging!

[youssef-lr]

Not yet @trjExpensify :(

This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[trjExpensify]

Huh, is this wrong then? #36388 (comment)

[youssef-lr]

oh weird it really wasn't showing for me.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.49-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Improve creating expenses on Collect with Instant Submit #36388

If no regressions arise, payment will be issued on 2024-03-18. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment (Needs manual offer from BZ)

[garrettmknight]

Assigning myself to handle BZ stuff.

[garrettmknight]

Updating to daily to pay on Monday. @hoangzinh are you getting paid via NewDot these days? Linking SO to for myself update if you are.

[hoangzinh]

Hi @garrettmknight nope, I'm still getting paid via Upwork 😢

[garrettmknight]

Bummer - offer is out to you!

[hoangzinh]

Accepted. Thanks @garrettmknight

[garrettmknight]

Paid, closing