[HOLD for payment 2024-02-09] [HIGH] Ensure the expense is added to report from which it was requested from

[mountiny]

### Problem

Users can go to expense report detail and request money from within that expense report. The correct money request reportID is passed to the backend but its never used actually. We do get the linked money request report as any other time which isn't guaranteed to be the same as we can have multiple open or processing reports

FYI this is being discussed in this internal slack thread

Solution

Make sure to use the provided money request report when provided in the createIOUTransaction call.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016be31384661b2a09
• Upwork Job ID: 1749503890650640384
• Last Price Increase: 2024-01-22

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016be31384661b2a09

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[mountiny]

Auth change is ready to be reviewed and merged, tests are passing, but I have found out there must have been some changes in the App and we are not necessarily sending the reportID of a report from which we have requested the money from

I will have to handle those changes too

[mountiny]

Still need to complete the App PR, will focus on that tomorrow

[mountiny]

PR is in review, addressed initial round of feedback

[melvin-bot]

Triggered auto assignment to @muttmuure (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[mountiny]

This is done basically

$500 to @eVoloshchak for review and testing please

[mountiny]

@eVoloshchak could you please propose a testRail case for this? specifically on Collect policy with bunch of Open reports to the testers can verify the expense is correctly added to that expense report

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Wave6] Enable requesting on specific report #35246

If no regressions arise, payment will be issued on 2024-02-09. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

https://github.com/Expensify/Expensify/issues/370624

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @eVoloshchak owed $500 via NewDot

BugZero Checklist (@muttmuure)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1749503890650640384/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[muttmuure]

$500 - @eVoloshchak

[melvin-bot]

@eVoloshchak, @mountiny, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

@eVoloshchak please can you submit a regression test

[eVoloshchak]

Regression Test Proposal

Preconditions:

• Have a Collect policy set up to work with NewDot
• Employee is a member of said policy

Test steps:

1. As the Employee, go to OldDot and create a New Report
2. Create multiple empty draft/open reports
3. Go to any of those expense reports
4. From the Composer + button, request money -> Manual
5. Verify that the request was added to the particular report you've requested it from
6. Repeat steps 3-5 for Scan and Distance

Do we agree 👍 or 👎

[JmillsExpensify]

$500 approved for @eVoloshchak based on this comment.

[mountiny]

Lets add this regression test and we can close this

[melvin-bot]

@eVoloshchak, @mountiny, @muttmuure Eep! 4 days overdue now. Issues have feelings too...

[muttmuure]

Created