[HOLD for payment 2024-02-07] [$500] shipping physical card doesn't appear to work, and I still see the prompt to get physical card

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.31-1
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706120463724819

Action Performed:

1. issue >$0 limit to a user
2. With that user, go to settings > wallet > expensify card
3. Select get physical card
4. Enter info and select Ship card

Expected Result:

card should ship, and I should see the button to Activate physical card in card settings

Actual Result:

I land back in the card settings, and still see Get physical card button (video will show that I am stuck in a loop here)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1.709.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019d53011b40230b72
• Upwork Job ID: 1750277395232059392
• Last Price Increase: 2024-01-24
• Automatic offers:
• Ollyws | Reviewer | 28123888
• dukenv0307 | Contributor | 28123889

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019d53011b40230b72

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[jliexpensify]

This is a core feature so we should get this fixed ASAP!

[ghost]

Just a quick question. How can we get Expensify card for testing purpose? Do we need to login using some testing account ? Or can we get some test BA to setup and get the card ?

[dukenv0307]

This is a core feature so we should get this fixed ASAP!

@jliexpensify we have a simple solution here, I can raise the PR ASAP if assigned

Proposal

Please re-state the problem that we are trying to solve in this issue.

I land back in the card settings, and still see Get physical card button (video will show that I am stuck in a loop here)

What is the root cause of that problem?

In here, we already optimistically set the card state to NOT_ACTIVATED when clicking "Ship card", which should have shown the "Activate physical card" button here.

Unfortunately, the cardID that we're using for that optimistic state setting operation is the cardID of the virtual card, not the physical card. That's why it's still show Get physical card when coming back to previous screen because the state of the physical card is unchanged. It only changes after the back-end returns response.

What changes do you think we should make in order to solve the problem?

We should pass the physical cardID to requestPhysicalExpensifyCard and optimistically set the state of that card to NOT_ACTIVATED instead.

We can do that by updating the code here to look for the physical card instead.

const physicalCard = _.find(domainCards, (card) => !card.isVirtual) || {};
const cardID = physicalCard.cardID;

(Same logic to look for physical card as used in other places like here)

What alternative solutions did you explore? (Optional)

Alternatively, we can make the Ship card experience an online-only one, that means we can have a loading indicator on that screen when the user presses Ship card, and only comes back to the previous screen after the API to RequestPhysicalExpensifyCard is successful. When the loading is on, we can either prevent the user from going back, of if going back, also show a loading indicator in the CTA button (or the full screen)

[Ollyws]

@dukenv0307 Thanks for the proposal, it looks good but how are you testing this on dev?

[dukenv0307]

@Ollyws Here's the steps we can use to test:

1. Login to a new account
2. Open Settings -> Wallet (important to open this first before setting the mock card data)
3. Set the following cards data to Onyx by running in browser devtools, it contains both a virtual card and physical card that are similar to the real data (if we have access to cards)

Onyx.set(`cardList`, {
    234523452345: {
        cardID: 234523452345,
        state: 3,
        bank: 'Expensify Card',
        availableSpend:10000,
        domainName: 'Expensify',
        lastFourPAN: '',
        isVirtual: true,
        cardholderFirstName: "Test",
        cardholderLastName: "Test",
    },
    234523452346: {
        cardID: 234523452346,
        state: 2,
        bank: 'Expensify Card',
        availableSpend:10000,
        domainName: 'Expensify',
        lastFourPAN: '2345',
        isVirtual: false,
    },
});

4. We can see the card appearing in Assigned cards section of Wallet, click on that card
5. Now we can continue with step 3, 4 in the OP

Since the above are mock data, the API request when clicking Ship card will fail, clicking around to other places in Wallet might not work, ... but you can validate that the solution is working by seeing the button title after clicking Ship card, checking Onyx data, ...

[Ollyws]

Thanks @dukenv0307.
@dukenv0307's proposal LGTM.
It would be good to have the error feedback displayed if the API call fails but I think that's a little out of scope for this issue.
🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@Ollyws this PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix logic request physical card #35303

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment automatic offer (Reviewer)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Ollyws]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR:

#28453

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/28453/files#r1481330880

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• Determine if we should create a regression test for this bug.

Yes

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. issue >$0 limit to a user
2. With that user, go to settings > wallet > expensify card
3. Select get physical card
4. Enter info and select Ship card
5. Verify that: see the button to Activate physical card in card settings

Do we agree 👍 or 👎

[jliexpensify]

Payment Summary

• Contributor: @dukenv0307 $500
• C+: @Ollyws $500

Upwork job

[jliexpensify]

Paid and job closed!