Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a language/location selector #3518

Closed
iwiznia opened this issue Jun 10, 2021 · 6 comments · Fixed by #3606
Closed

Add a language/location selector #3518

iwiznia opened this issue Jun 10, 2021 · 6 comments · Fixed by #3606
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@iwiznia
Copy link
Contributor

iwiznia commented Jun 10, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem

It's not currently possible to change the locale in the Electron app, which makes it impossible for people using the app to test the spanish translations.

Expected Result:

We want to add a language/location selector to the preferences section.
This selector needs to be under a new beta.
The available options should be the current available locales in src/languages.
The value it should display and change is the Onyx key PREFERRED_LOCALE

View all open jobs on Upwork

@iwiznia iwiznia added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jun 10, 2021
@MelvinBot
Copy link

Triggered auto assignment to @greg-schroeder (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jun 10, 2021
@JmillsExpensify
Copy link

A great reason for doing this now is that it's not currently possible, at least based on my attempts, to use localization in the Electron app.

@greg-schroeder
Copy link
Contributor

greg-schroeder commented Jun 10, 2021

Hi @iwiznia could we add a short problem statement to this issue that explains why it's valuable to add this now? It seems like the issue just says we want to do it, but it's unclear why or what problem it solves to a reader at first glance. Perhaps adding something about what @JmillsExpensify said above to the OP would be a good start.

@iwiznia
Copy link
Contributor Author

iwiznia commented Jun 11, 2021

Done

@MelvinBot
Copy link

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@greg-schroeder greg-schroeder removed their assignment Jun 11, 2021
@greg-schroeder
Copy link
Contributor

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants