Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for the options in the language selector #3606

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

jasperhuangg
Copy link
Contributor

Details

I realized I forgot to include translations for the options in the language selector in #3567. This PR fixes that

Fixed Issues

Fixes #3518

Tests

  1. Open the preferences page.
  2. Verify that the Language Picker component and its corresponding label render correctly.
  3. Use the picker to change the language. Verify that the language is updated throughout the app.

QA Steps

Same as the above tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Screen Shot 2021-06-16 at 10 31 48 AM

Screen Shot 2021-06-16 at 10 31 55 AM

android

Simulator Screen Shot - iPhone 12 - 2021-06-16 at 10 35 26

@jasperhuangg jasperhuangg requested a review from madmax330 June 16, 2021 02:44
@jasperhuangg jasperhuangg self-assigned this Jun 16, 2021
@jasperhuangg jasperhuangg marked this pull request as ready for review June 16, 2021 03:16
@jasperhuangg jasperhuangg requested a review from a team as a code owner June 16, 2021 03:16
@jasperhuangg jasperhuangg removed the request for review from a team June 16, 2021 03:16
@MelvinBot MelvinBot requested a review from timszot June 16, 2021 03:16
Copy link
Contributor

@timszot timszot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madmax330 madmax330 merged commit 766259c into main Jun 16, 2021
@madmax330 madmax330 deleted the jasper-languageSelectorOtherChanges branch June 16, 2021 17:26
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.69-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@kavimuru
Copy link

App crashes when changing the language

Expected Result:

The language is updated throughout the app.

Actual Result:

App crashes every time.

Actions Performed:

  1. Launch the app and login
  2. Open the preferences page.
  3. Tap the Language Picker component
  4. Use the picker to change the language

Platform:

iOS ✔️
mWeb
Android ✔️

Build:

1.0.70-0

Notes/Images/Video:

App.crashed.when.switching.language.mp4

iPhone 8 Crash.txt

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Jun 16, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@roryabraham
Copy link
Contributor

Got a fix for this ready

@roryabraham roryabraham mentioned this pull request Jun 17, 2021
5 tasks
@roryabraham
Copy link
Contributor

Hmmm so the crash is still happening for me on 1.0.70.8, and it's also happening when trying to reopen after a crash

@isagoico
Copy link

+1 on that, we're able to reproduce the same issue in 1.0.71-0

@roryabraham
Copy link
Contributor

Still reproducible on iOS 1.0.73.2

@roryabraham
Copy link
Contributor

roryabraham commented Jun 24, 2021

Okay, we really need to fix this. It seems to only be reproducible on staging, but I will try to see if I can reproduce with a static build.

@roryabraham
Copy link
Contributor

I was able to reproduce with a static build, then from there I was able to use Xcode to connect to the process using Debug -> Connect to process. Then I was able to catch this log before the app crashes:

*** Terminating app due to uncaught exception 'RCTFatalException: Unhandled JS Exception: Error: Requiring unknown module "./locale/es".', reason: 'Unhandled JS Exception: Error: Requiring unknown module "./locale/es"., stack:
h@2:1417
d@2:958
pt@1070:16808
Mt@1070:17844
vt@1070:16907
s@1069:230
timestampToDateTime@1069:748
timestampToDateTime@1060:989
ReportActionItemDate@1510:439
Mr@94:41826
vl@94:51676
ni@94:78588
Za@94:78516
Ja@94:78281
Ya@94:75443
Ya@(null):(null)
<unknown>@94:26095
<unknown>@192:3806
Pt@94:26042
Rt@94:25977
Ba@94:72937
enqueueSetState@94:31235
<unknown>@593:1350
<unknown>@479:2474
Mr@480:9437
T@479:2179
<unknown>@479:3499
f@114:154
<unknown>@114:863
k@120:535
x@120:933
callImmediates@120:3022
value@45:2846
<unknown>@45:1022
value@45:2538
value@45:992
value@(null):(null)
value@(null):(null)
'
terminating with uncaught exception of type NSException
(lldb) 

@roryabraham
Copy link
Contributor

Okay, have a fix pending

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a language/location selector
7 participants