-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations for the options in the language selector #3606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚀 Deployed to staging in version: 1.0.69-1🚀
|
App crashes when changing the languageExpected Result:The language is updated throughout the app. Actual Result:App crashes every time. Actions Performed:
Platform:iOS ✔️ Build:1.0.70-0 Notes/Images/Video:App.crashed.when.switching.language.mp4 |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Got a fix for this ready |
Hmmm so the crash is still happening for me on |
+1 on that, we're able to reproduce the same issue in 1.0.71-0 |
Still reproducible on iOS |
Okay, we really need to fix this. It seems to only be reproducible on staging, but I will try to see if I can reproduce with a static build. |
I was able to reproduce with a static build, then from there I was able to use Xcode to connect to the process using
|
Okay, have a fix pending |
🚀 Deployed to production in version: 1.0.73-3🚀
|
Details
I realized I forgot to include translations for the options in the language selector in #3567. This PR fixes that
Fixed Issues
Fixes #3518
Tests
QA Steps
Same as the above tests
Tested On
Screenshots