Deploy Checklist: Expensify.cash 2021-06-15

[OSBotify]

Release Version: 1.0.73-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Update staging to 1.0.16-0 #2287
• Prevent users blocked from concierge from sending messages #2932
• [No QA] Use full Git history to populate StagingDeployCash #3173
• Set password #3190
• button styling fixed #3193
• 🍒 Cherry pick PR #3208 to staging 🍒 #3214
• fixed slow emoji entry & Keyboard focus #3392
• Fix: [Android] Opening camera/gallery does not work on Android 11 #3420
• Set the focus on Edit Box after edit action. #3441
• Add info about internationalization / localization #3444
• Store User_IsFromPublicDomain in Onyx #3460
• Add modal for inviting users to a workspace #3463
• Update Permissions logic to fix IOU regression #3481
• [NO-QA] Bump Onyx commit to fix IOU regression #3483
• Use hrefAttrs for links #3486
• Fix PDF Attachments not scrollable #3487
• 🍒 Cherry pick PR #3486 to staging 🍒 #3495
• 🍒 Cherry pick PR #3483 to staging 🍒 #3497
• Decline/cancel IOU feedback. #3498
• Skip most PR checks on automated pull requests #3499
• 🍒 Cherry pick PR #3481 to staging 🍒 #3501
• Migrate BankAccount_SetupWithdrawalAccount API #3507
• Context Menu rendering #3515
• [NO QA]Feature: Critical Error Handling #3527
• Update version to 1.0.66-13 on staging #3531
• Update version to 1.0.67-0 on staging #3533
• Add beta for default rooms #3534
• Fix infinite spinner when signing into an account after signing out #3535
• Introduce Default Rooms into EChat #3540
• Add a modal screen for creating a new workspace #3547
• Update version to 1.0.68-0 on staging #3549
• Upgrade react-native-document-picker to 5.1.0 #3550
• fixed scrolling when focusing on the edit box for old message #3551
• Replace invalid prop for drawer #3552
• 🍒 Cherry pick PR #3550 to staging 🍒 #3554
• Add capturing event listeners to the KeyboardShortcut library #3555
• 🍒 Cherry pick PR #3555 to staging 🍒 #3557
• Refactor index files for Popover.  #3558
• 🍒 Cherry pick PR #3535 to staging 🍒 #3564
• Added language selector in the preferences page #3567
• [No QA] Move reproduction steps above expected/actual results in issue template #3570
• 3272 update message date overnight #3573
• Display full-screen loading indicator while fetching currency data #3577
• Handle unauthenticated users when creating a new workspace #3578
• Fix random warnings #3579
• Remove SMS domains from tooltips #3580
• fix: Document Picker crash on IOS #3581
• [No QA] VBA Requestor Step (UI Only) #3582
• 🍒 Cherry pick PR #3581 to staging 🍒 #3584
• [No QA] Add BeneficialOwnersStep (UI Only) #3585
• Create Validation Step #3587
• Add missing spanish tranlsation #3589
• [No QA] Add stepToOpen route parameter to verified bank account flow #3596
• Use encrypted auth token for images #3597
• Added workspace Settings Modal #3602
• Translations for the options in the language selector #3606
• Fix Header Bouncing on start (Android) #3610
• Add latest bank + paycheck icons #3611
• Add an option to global create menu for “New Workspace” #3612
• CSS Hack to fix safari text inputs #3613
• [HOLD Web-Expensify #31129] PR template updated to work well with AwaitingPayment functionality #3619
• VBA Company Step (UI only) #3620
• [No QA] Display workspaces in settings page #3630
• Hook up company step to setupWithdrawalAccount #3632
• #3559 fix initial route after relogin #3634
• fix menu placement is broken on mobile #3635
• Fix language selector #3638
• [No QA] Connect New Workspace Page with the backend #3639
• [No QA] Add better logging for StagingDeployCash #3642
• [No QA] Fetch StagingDeployCash issues in all states #3647
• [No QA] Fix StagingDeployCash bug #3650
• Fix IOU request sent to new phone number account #3651
• [No QA] Fix StagingDeployCash isAutomatedPullRequest check #3656
• [No QA] Add check for isUsingExpensifyCard #3664
• Add new action page for payment methods #3667
• Clean up Checkboxes #3668
• Debounce search page and reduce number of tooltips created #3669
• [No QA] Remove forked dependency from GHA #3670
• Refactor IOU Components to /ReportActionItem folder & rename #3674
• Default participantsList to empty array to prevent crash in IOU feature #3675
• [No QA] Checkout repo before attempting to update StagingDeployCash #3676
• [No QA] Use lowercase "id" for policy object in Onyx #3678
• [No QA] fix popover for native devices #3684
• chg: Block context menu on message being edited #3685
• Add Validation to BankAccount + CompanyStep + better handling for Plaid #3686
• Hook Request Step up to setupWithdrawalAccount #3689
• [No QA] fix focus state is undefined #3693
• [NO QA] Set up the request call API functions #3695
• Localization consts for Request Call Page #3696
• Create the RequestCallPage #3697
• [No QA] Make GitHub Actions build asynchronously #3702
• Feature: Send image with text via composer #3708
• Fix: ScrollBar staying in the middle of the modal (iOS) #3709
• [No QA] Improve VBA deep link routing #3711
• Add Venmo to intent filter list in AndroidManifest.xml #3713
• Add jdk install instructions to README #3714
• [No QA] Set the user preferences correctly on Onyx #3717
• Improve error message when attempting to run the iOS app alongside the desktop and web in development #3718
• Don't focus input until screen transition has ended #3719
• Update CONTRIBUTING.md #3720
• [No QA] Additional Validation for RequestorStep + ACHContractStep #3724
• Display phone number on DetailsPage for SMS logins with display names #3728
• Fixed swipe on composer #3733
• Send the sequenceNumber when deleting a report comment #3734
• [No QA] Remove style guide rule for refs #3735
• Feature: Make lonely emojis bigger #3738
• Fix NotificationResponse race condition #3740
• Change order of global create menu #3744
• Add notification preference to simplified report object #3746
• Change blocked from concierge prop default to empty object #3748
• Preload locales to fix native crash #3749

Deploy Blockers:

• Set the focus on Edit Box after edit action. #3441
• [HOLD for payment 21 June] iOS - Attachment picker flickers and unable to select for choose document #3543
• IOU - Request Money - Unable to write in field What's this for? #3598
• mWeb - Safari- Page gets distorted tapping add phone number in profile #3604
• Translations for the options in the language selector #3606
• Request money - Endless loading spinner when requesting money from phone number account #3614
• Android/iOS - Chat - Long pressing on sent message doesn't open menu properly #3633
• Android - Chat - App crashes when sending 2 emojis consecutively #3691
• Android - Payment -Missing the dropdown for payment option, so Pay with Venmo isn't visible #3692

cc @Expensify/applauseleads

[mvtglobally]

Starting QA

[isagoico]

So far during regression we've found these 5 issues:

• Set the focus on Edit Box after edit action. #3441 (comment)
• mWeb - Safari- Page gets distorted tapping add phone number in profile #3604
• mWeb-Android - Login - White screen displayed for a while after login #3603
• Android - Crash when editing a message  #3599
• IOU - Request Money - Unable to write in field What's this for? #3598
• Payments - Unable to change PayPal account in Setting, green button always enabled. #3609

We're still testing the regression TR. There were a lot of PRs yesterday and also classic regression, that's why it has taken us a bit more than usual. We will post here when regression is done.

[isagoico]

Testing is almost finished, adding the summary in a little bit

[isagoico]

Regression is finished:
Issues found:
#3598
#3603
#3604
#3614
#3609
#3193
#3599

PRs are finished too:
1 Comment logged
#3441 (comment)

Venmo TCs are blocked due to: #3614

[isagoico]

Starting QA 🚀

[isagoico]

Regression is finished!
Issues found:

• Scrollbar appears in the middle of conversation '"View details" option #3637
• mWeb - User is able to open several action menus for messages #3636
• Android/iOS - Chat - Long pressing on sent message doesn't open menu properly #3633
• iPad - Login - App freezes after login in landscape orientation  #3631

PRs are finished too:
1 comment added:

1. Translations for the options in the language selector #3606 (comment)

Thanks!

[roryabraham]

Got a fix for #3606 incoming

[roryabraham]

PR is here

[roryabraham]

Please don't add the lock label yet - I am testing something

[roryabraham]

Manually added #3612 because this checklist is currently broken

[roryabraham]

Update: Hoping this PR will fix the deploy checklist and prevent us having to manually update it in the future.

[roryabraham]

Update: now hoping this PR will fix the deploy checklist 😓

[roryabraham]

Okay, the @isagoico the checklist should start behaving more as it should, and should not need to be manually updated with deferred PRs anymore. There's maybe a few issues remaining, but I can create follow-ups for those.

[isagoico]

@roryabraham That's great news! so we should be good to start QA now right?

[roryabraham]

@isagoico Yep 👍

[mvtglobally]

Starting QA

[marcaaron]

Heads up I've checked off the following PRs related to the project behind the freePlan beta as we do not need them QA'd yet thanks!

#3611
#3612
#3620

[isagoico]

Regression is finished.
No issues found today.

PRs are finished too:
2 comments added:

1. Context Menu rendering #3515 (comment)
2. Translations for the options in the language selector #3606 (comment)

Crash is still reproducible for #3606

Leaving the Lock label for a while just in case a prod deploy is required today. @roryabraham Let us know if we can remove.

[roryabraham]

Removed the label

[mvtglobally]

starting QA

[isagoico]

Just noticed I didn't send the summary yet:
Regression is finished
Issues found:

1. Android - Payment -Missing the dropdown for payment option, so Pay with Venmo isn't visible #3692
2. Android - Chat - App crashes when sending 2 emojis consecutively #3691

PRs are finished too:
No comments added
Only 2 PR are missing to check off because of #3567 (comment)

Thanks!

[isagoico]

Starting QA

[roryabraham]

@isagoico This deploy checklist is too unruly ... let's leave the LockCashDeploys label on this issue until all the deploy blockers are resolved via CP's.

[isagoico]

Sure will do, let us know if any of the CPs needs to be tested and we'll take care of them.

[isagoico]

Regression is finished
1 issue found today:

1. Web - IOU - No decimal place appears for some currencies in preview modal #3710

PRs are finished too:
1 comment added:

1. fixed slow emoji entry & Keyboard focus #3392 (comment)

Thanks!

[roryabraham]

Manually removed the following PRs from the checklist:

• Add Validation to BankAccount + CompanyStep + better handling for Plaid #3686
• [NO QA] Set up the request call API functions #3695
• Localization consts for Request Call Page #3696
• [No QA] Make GitHub Actions build asynchronously #3702
• Fix: ScrollBar staying in the middle of the modal (iOS) #3709
• Add jdk install instructions to README #3714
• [No QA] Set the user preferences correctly on Onyx #3717

They were not deployed and not supposed to be added, issue here

[roryabraham]

CPing a fix to the last deploy blocker, which should be resolved in 1.0.73-3 🤞

[roryabraham]

Oh, and this checklist is going to be populated with a bunch of stuff not included in this release, because this issue is not fixed yet.

[mvtglobally]

@roryabraham keep us posted when we can start QA

[roryabraham]

Verifed that #3606 is fixed in 1.0.73-3, so I'm going to close out this checklist and run a prod deploy

[roryabraham]

Many of these issues should not be added to the checklist because of this issue (really need to fix this), but I expect them to be added to the next checklist, so I'm going to check them off manually:

• Prevent users blocked from concierge from sending messages #2932
• fixed slow emoji entry & Keyboard focus #3392
• Skip most PR checks on automated pull requests #3499
• Introduce Default Rooms into EChat #3540
• Added language selector in the preferences page #3567
• 🍒 Cherry pick PR #3581 to staging 🍒 #3584
• Create Validation Step #3587
• Use encrypted auth token for images #3597
• Added workspace Settings Modal #3602
• Translations for the options in the language selector #3606
• [HOLD Web-Expensify #31129] PR template updated to work well with AwaitingPayment functionality #3619
• [No QA] Add check for isUsingExpensifyCard #3664
• Clean up Checkboxes #3668
• Add Validation to BankAccount + CompanyStep + better handling for Plaid #3686
• Hook Request Step up to setupWithdrawalAccount #3689
• [No QA] fix focus state is undefined #3693
• [NO QA] Set up the request call API functions #3695
• Localization consts for Request Call Page #3696
• Create the RequestCallPage #3697
• [No QA] Make GitHub Actions build asynchronously #3702
• Feature: Send image with text via composer #3708
• Fix: ScrollBar staying in the middle of the modal (iOS) #3709
• [No QA] Improve VBA deep link routing #3711
• Add Venmo to intent filter list in AndroidManifest.xml #3713
• Add jdk install instructions to README #3714
• [No QA] Set the user preferences correctly on Onyx #3717
• Improve error message when attempting to run the iOS app alongside the desktop and web in development #3718
• Don't focus input until screen transition has ended #3719
• Update CONTRIBUTING.md #3720
• [No QA] Additional Validation for RequestorStep + ACHContractStep #3724
• Display phone number on DetailsPage for SMS logins with display names #3728
• Fixed swipe on composer #3733
• Send the sequenceNumber when deleting a report comment #3734
• [No QA] Remove style guide rule for refs #3735
• Feature: Make lonely emojis bigger #3738
• Fix NotificationResponse race condition #3740
• Change order of global create menu #3744
• Add notification preference to simplified report object #3746
• Change blocked from concierge prop default to empty object #3748
• Preload locales to fix native crash #3749

[roryabraham]