Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staging to 1.0.16-0 #2287

Merged
merged 61 commits into from
Apr 8, 2021
Merged

Update staging to 1.0.16-0 #2287

merged 61 commits into from
Apr 8, 2021

Conversation

roryabraham
Copy link
Contributor

Details

For a while now, the Github Workflow that's supposed to update the staging branch has been silently failing (example). We haven't noticed because for the time being we've been deploying staging from the master branch. Issue to change that is here.

So when we went to run a production deploy, we deployed the latest version from staging, which was 1.0.13-4. https://github.com/Expensify/Expensify.cash/releases/tag/1.0.13-4

To resolve (without needing to go through QA again), we can:

  1. Create a PR from the latest QA'd tag, 1.0.16-0 to staging. (i.e: this PR)

image

  1. Merge this PR to get staging up-to-date with our latest staging version
  2. Close the StagingDeployCash to trigger a new production deploy.

jasperhuangg and others added 30 commits March 18, 2021 11:03
…pensify.cash into jasper-setPasswordEmailLink
@roryabraham roryabraham requested a review from AndrewGable April 8, 2021 00:18
@roryabraham roryabraham requested a review from a team as a code owner April 8, 2021 00:18
@roryabraham roryabraham self-assigned this Apr 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2021

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


10 out of 11 committers have signed the CLA.
@jasperhuangg
@parasharrajat
@marcaaron
@Maftalion
@roryabraham
@Jag96
@deetergp
@alex-mechler
@tgolen
@iwiznia
@ctkochan22
You can retrigger this bot by commenting recheck in this Pull Request

@MelvinBot MelvinBot requested review from joelbettner and removed request for a team April 8, 2021 00:18
Copy link
Contributor

@AndrewGable AndrewGable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don't think GitHub actions is going to be happy with this PR, so I will have to merge with broken CLA checks.

@AndrewGable AndrewGable merged commit d2f1fff into staging Apr 8, 2021
@AndrewGable AndrewGable deleted the Rory-UpdateStagingTo1-0-16 branch April 8, 2021 00:21
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.43-9🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.44-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.